mirror of
https://github.com/git/git
synced 2024-07-17 02:57:48 +00:00
tests: order arguments to git-rev-list properly
It is a common mistake to put positional arguments before flags when invoking git-rev-list. Order the positional arguments last. This patch skips git-rev-list invocations which include the --not flag, since the ordering of flags and positional arguments affects the behavior. This patch also skips invocations of git-rev-list that occur in command substitution in which the exit code is discarded, since fixing those properly will require a more involved cleanup. Signed-off-by: Matthew DeVore <matvore@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Matthew DeVore
Junio C Hamano
parent
b00b6ace5c
commit
8d6ba49563
|
|
@ -35,7 +35,7 @@ test_expect_success 'setup bare clone for server' '
|
|||
test_expect_success 'do partial clone 1' '
|
||||
git clone --no-checkout --filter=blob:none "file://$(pwd)/srv.bare" pc1 &&
|
||||
|
||||
git -C pc1 rev-list HEAD --quiet --objects --missing=print >revs &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/?//" |
|
||||
sort >observed.oids &&
|
||||
|
|
@ -48,10 +48,10 @@ test_expect_success 'do partial clone 1' '
|
|||
|
||||
# checkout master to force dynamic object fetch of blobs at HEAD.
|
||||
test_expect_success 'verify checkout with dynamic object fetch' '
|
||||
git -C pc1 rev-list HEAD --quiet --objects --missing=print >observed &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print HEAD >observed &&
|
||||
test_line_count = 4 observed &&
|
||||
git -C pc1 checkout master &&
|
||||
git -C pc1 rev-list HEAD --quiet --objects --missing=print >observed &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print HEAD >observed &&
|
||||
test_line_count = 0 observed
|
||||
'
|
||||
|
||||
|
|
@ -74,7 +74,8 @@ test_expect_success 'push new commits to server' '
|
|||
# have the new blobs.
|
||||
test_expect_success 'partial fetch inherits filter settings' '
|
||||
git -C pc1 fetch origin &&
|
||||
git -C pc1 rev-list master..origin/master --quiet --objects --missing=print >observed &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print \
|
||||
master..origin/master >observed &&
|
||||
test_line_count = 5 observed
|
||||
'
|
||||
|
||||
|
|
@ -82,7 +83,8 @@ test_expect_success 'partial fetch inherits filter settings' '
|
|||
# we should only get 1 new blob (for the file in origin/master).
|
||||
test_expect_success 'verify diff causes dynamic object fetch' '
|
||||
git -C pc1 diff master..origin/master -- file.1.txt &&
|
||||
git -C pc1 rev-list master..origin/master --quiet --objects --missing=print >observed &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print \
|
||||
master..origin/master >observed &&
|
||||
test_line_count = 4 observed
|
||||
'
|
||||
|
||||
|
|
@ -91,7 +93,8 @@ test_expect_success 'verify diff causes dynamic object fetch' '
|
|||
test_expect_success 'verify blame causes dynamic object fetch' '
|
||||
git -C pc1 blame origin/master -- file.1.txt >observed.blame &&
|
||||
test_cmp expect.blame observed.blame &&
|
||||
git -C pc1 rev-list master..origin/master --quiet --objects --missing=print >observed &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print \
|
||||
master..origin/master >observed &&
|
||||
test_line_count = 0 observed
|
||||
'
|
||||
|
||||
|
|
@ -111,7 +114,8 @@ test_expect_success 'push new commits to server for file.2.txt' '
|
|||
# Verify we have all the new blobs.
|
||||
test_expect_success 'override inherited filter-spec using --no-filter' '
|
||||
git -C pc1 fetch --no-filter origin &&
|
||||
git -C pc1 rev-list master..origin/master --quiet --objects --missing=print >observed &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print \
|
||||
master..origin/master >observed &&
|
||||
test_line_count = 0 observed
|
||||
'
|
||||
|
||||
|
|
@ -133,8 +137,8 @@ test_expect_success 'push new commits to server for file.3.txt' '
|
|||
test_expect_success 'manual prefetch of missing objects' '
|
||||
git -C pc1 fetch --filter=blob:none origin &&
|
||||
|
||||
git -C pc1 rev-list master..origin/master --quiet --objects --missing=print \
|
||||
>revs &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print \
|
||||
master..origin/master >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/?//" |
|
||||
sort >observed.oids &&
|
||||
|
|
@ -142,8 +146,8 @@ test_expect_success 'manual prefetch of missing objects' '
|
|||
test_line_count = 6 observed.oids &&
|
||||
git -C pc1 fetch-pack --stdin "file://$(pwd)/srv.bare" <observed.oids &&
|
||||
|
||||
git -C pc1 rev-list master..origin/master --quiet --objects --missing=print \
|
||||
>revs &&
|
||||
git -C pc1 rev-list --quiet --objects --missing=print \
|
||||
master..origin/master >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/?//" |
|
||||
sort >observed.oids &&
|
||||
|
|
|
|||
|
|
@ -271,7 +271,7 @@ test_expect_success 'partial clone' '
|
|||
grep "version 2" trace &&
|
||||
|
||||
# Ensure that the old version of the file is missing
|
||||
git -C client rev-list master --quiet --objects --missing=print \
|
||||
git -C client rev-list --quiet --objects --missing=print master \
|
||||
>observed.oids &&
|
||||
grep "$(git -C server rev-parse message1:a.txt)" observed.oids &&
|
||||
|
||||
|
|
@ -297,7 +297,7 @@ test_expect_success 'partial fetch' '
|
|||
grep "version 2" trace &&
|
||||
|
||||
# Ensure that the old version of the file is missing
|
||||
git -C client rev-list other --quiet --objects --missing=print \
|
||||
git -C client rev-list --quiet --objects --missing=print other \
|
||||
>observed.oids &&
|
||||
grep "$(git -C server rev-parse message1:a.txt)" observed.oids &&
|
||||
|
||||
|
|
|
|||
|
|
@ -25,7 +25,8 @@ test_expect_success 'verify blob:none omits all 5 blobs' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r1 rev-list HEAD --quiet --objects --filter-print-omitted --filter=blob:none >revs &&
|
||||
git -C r1 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=blob:none HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -34,12 +35,12 @@ test_expect_success 'verify blob:none omits all 5 blobs' '
|
|||
'
|
||||
|
||||
test_expect_success 'verify emitted+omitted == all' '
|
||||
git -C r1 rev-list HEAD --objects >revs &&
|
||||
git -C r1 rev-list --objects HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sort >expected &&
|
||||
|
||||
git -C r1 rev-list HEAD --objects --filter-print-omitted --filter=blob:none \
|
||||
>revs &&
|
||||
git -C r1 rev-list --objects --filter-print-omitted --filter=blob:none \
|
||||
HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -68,7 +69,8 @@ test_expect_success 'verify blob:limit=500 omits all blobs' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r2 rev-list HEAD --quiet --objects --filter-print-omitted --filter=blob:limit=500 >revs &&
|
||||
git -C r2 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=blob:limit=500 HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -77,11 +79,12 @@ test_expect_success 'verify blob:limit=500 omits all blobs' '
|
|||
'
|
||||
|
||||
test_expect_success 'verify emitted+omitted == all' '
|
||||
git -C r2 rev-list HEAD --objects >revs &&
|
||||
git -C r2 rev-list --objects HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sort >expected &&
|
||||
|
||||
git -C r2 rev-list HEAD --objects --filter-print-omitted --filter=blob:limit=500 >revs &&
|
||||
git -C r2 rev-list --objects --filter-print-omitted \
|
||||
--filter=blob:limit=500 HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -94,7 +97,8 @@ test_expect_success 'verify blob:limit=1000' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r2 rev-list HEAD --quiet --objects --filter-print-omitted --filter=blob:limit=1000 >revs &&
|
||||
git -C r2 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=blob:limit=1000 HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -107,7 +111,8 @@ test_expect_success 'verify blob:limit=1001' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r2 rev-list HEAD --quiet --objects --filter-print-omitted --filter=blob:limit=1001 >revs &&
|
||||
git -C r2 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=blob:limit=1001 HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -120,7 +125,8 @@ test_expect_success 'verify blob:limit=1k' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r2 rev-list HEAD --quiet --objects --filter-print-omitted --filter=blob:limit=1k >revs &&
|
||||
git -C r2 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=blob:limit=1k HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -129,7 +135,8 @@ test_expect_success 'verify blob:limit=1k' '
|
|||
'
|
||||
|
||||
test_expect_success 'verify blob:limit=1m' '
|
||||
git -C r2 rev-list HEAD --quiet --objects --filter-print-omitted --filter=blob:limit=1m >revs &&
|
||||
git -C r2 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=blob:limit=1m HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -162,7 +169,8 @@ test_expect_success 'verify sparse:path=pattern1 omits top-level files' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r3 rev-list HEAD --quiet --objects --filter-print-omitted --filter=sparse:path=../pattern1 >revs &&
|
||||
git -C r3 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=sparse:path=../pattern1 HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -175,7 +183,8 @@ test_expect_success 'verify sparse:path=pattern2 omits both sparse2 files' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r3 rev-list HEAD --quiet --objects --filter-print-omitted --filter=sparse:path=../pattern2 >revs &&
|
||||
git -C r3 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=sparse:path=../pattern2 HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -200,7 +209,8 @@ test_expect_success 'verify sparse:oid=OID omits top-level files' '
|
|||
|
||||
oid=$(git -C r3 ls-files -s pattern | awk -f print_2.awk) &&
|
||||
|
||||
git -C r3 rev-list HEAD --quiet --objects --filter-print-omitted --filter=sparse:oid=$oid >revs &&
|
||||
git -C r3 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=sparse:oid=$oid HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -213,7 +223,8 @@ test_expect_success 'verify sparse:oid=oid-ish omits top-level files' '
|
|||
awk -f print_2.awk ls_files_result |
|
||||
sort >expected &&
|
||||
|
||||
git -C r3 rev-list HEAD --quiet --objects --filter-print-omitted --filter=sparse:oid=master:pattern >revs &&
|
||||
git -C r3 rev-list --quiet --objects --filter-print-omitted \
|
||||
--filter=sparse:oid=master:pattern HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/~//" |
|
||||
sort >observed &&
|
||||
|
|
@ -235,7 +246,7 @@ test_expect_success 'rev-list W/ --missing=print' '
|
|||
rm r1/.git/objects/$id
|
||||
done &&
|
||||
|
||||
git -C r1 rev-list --quiet HEAD --missing=print --objects >revs &&
|
||||
git -C r1 rev-list --quiet --missing=print --objects HEAD >revs &&
|
||||
awk -f print_1.awk revs |
|
||||
sed "s/?//" |
|
||||
sort >observed &&
|
||||
|
|
|
|||
Loading…
Reference in a new issue