mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
ident: reject bogus email addresses with IDENT_STRICT
If we come up with a hostname like "foo.(none)" because the user's machine is not fully qualified, we should reject this in strict mode (e.g., when we are making a commit object), just as we reject an empty gecos username. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
f9bc573fda
commit
8c5b1ae1b2
6
ident.c
6
ident.c
|
@ -288,6 +288,12 @@ const char *fmt_ident(const char *name, const char *email,
|
|||
name = pw->pw_name;
|
||||
}
|
||||
|
||||
if (strict && email == git_default_email.buf &&
|
||||
strstr(email, "(none)")) {
|
||||
fputs(env_hint, stderr);
|
||||
die("unable to auto-detect email address (got '%s')", email);
|
||||
}
|
||||
|
||||
if (want_date) {
|
||||
if (date_str && date_str[0]) {
|
||||
if (parse_date(date_str, date, sizeof(date)) < 0)
|
||||
|
|
Loading…
Reference in a new issue