development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-28 03:59:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'jc/archive-list-with-extra-args' into maint-2.43

Browse source 
"git archive --list extra garbage" silently ignored excess command
line parameters, which has been corrected.

* jc/archive-list-with-extra-args:
  archive: "--list" does not take further options
This commit is contained in:
Junio C Hamano 2024-02-08 16:22:04 -08:00
parent a593e2fbce d6b6cd1393
commit 878f8c42dc
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
archive.c
View file

@ -685,6 +685,8 @@ static int parse_archive_args(int argc, const char **argv,
base = "";
if (list) {
if (argc)
die(_("extra command line parameter '%s'"), *argv);
for (i = 0; i < nr_archivers; i++)
if (!is_remote || archivers[i]->flags & ARCHIVER_REMOTE)
printf("%s\n", archivers[i]->name);

10
t/t5000-tar-tree.sh
View file

@ -124,6 +124,16 @@ test_expect_success 'setup' '
EOF
'
test_expect_success '--list notices extra parameters' '
test_must_fail git archive --list blah &&
test_must_fail git archive --remote=. --list blah
'
test_expect_success 'end-of-options is correctly eaten' '
git archive --list --end-of-options &&
git archive --remote=. --list --end-of-options
'
test_expect_success 'populate workdir' '
mkdir a &&
echo simple textfile >a/a &&