mirror of
https://github.com/git/git
synced 2024-10-29 17:08:46 +00:00
lock_ref_for_update(): avoid a symref resolution
If we're overwriting a symref with a SHA-1, we need to resolve the value of the symref (1) to check against update->old_sha1 and (2) to write to its reflog. However, we've already read the symref itself and know its referent. So there is no need to read the symref's value through the symref; we can read the referent directly. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
e3f510393c
commit
841caad903
1 changed files with 1 additions and 1 deletions
|
@ -3479,7 +3479,7 @@ static int lock_ref_for_update(struct ref_update *update,
|
|||
* the transaction, so we have to read it here
|
||||
* to record and possibly check old_sha1:
|
||||
*/
|
||||
if (read_ref_full(update->refname, 0,
|
||||
if (read_ref_full(referent.buf, 0,
|
||||
lock->old_oid.hash, NULL)) {
|
||||
if (update->flags & REF_HAVE_OLD) {
|
||||
strbuf_addf(err, "cannot lock ref '%s': "
|
||||
|
|
Loading…
Reference in a new issue