development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-01 06:05:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

patch-id: ignore newline at end of file in diff_flush_patch_id()

Browse source 
Whitespace is ignored when calculating patch IDs.  This is done by
removing all whitespace from diff lines before hashing them, including
a newline at the end of a file.  If that newline is missing, however,
diff reports that fact in a separate line containing "\ No newline at
end of file\n", and this marker is hashed like a context line.

This goes against our goal of making patch IDs independent of
whitespace.  Use the same heuristic that 2485eab55c (git-patch-id: do
not trip over "no newline" markers, 2011-02-17) added to git patch-id
instead and skip diff lines that start with a backslash and a space
and are longer than twelve characters.

Reported-by: Tilman Vogel <tilman.vogel@web.de>
Initial-test-by: Tilman Vogel <tilman.vogel@web.de>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
René Scharfe 2020-08-19 00:08:54 +02:00 committed by Junio C Hamano
parent 47ae905ffb
commit 82a62015a7
2 changed files with 25 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
diff.c
View file

@ -6044,6 +6044,8 @@ static void patch_id_consume(void *priv, char *line, unsigned long len)
struct patch_id_t *data = priv;
int new_len;
if (len > 12 && starts_with(line, "\\ "))
return;
new_len = remove_space(line, len);
the_hash_algo->update_fn(data->ctx, line, new_len);

23
t/t3500-cherry.sh
View file

@ -55,4 +55,27 @@ test_expect_success \
expr "$(echo $(git cherry master my-topic-branch) )" : "+ [^ ]* - .*"
'
test_expect_success 'cherry ignores whitespace' '
git switch --orphan=upstream-with-space &&
test_commit initial file &&
>expect &&
git switch --create=feature-without-space &&
# A spaceless file on the feature branch. Expect a match upstream.
printf space >file &&
git add file &&
git commit -m"file without space" &&
git log --format="- %H" -1 >>expect &&
# A further change. Should not match upstream.
test_commit change file &&
git log --format="+ %H" -1 >>expect &&
git switch upstream-with-space &&
# Same as the spaceless file, just with spaces and on upstream.
test_commit "file with space" file "s p a c e" file-with-space &&
git cherry upstream-with-space feature-without-space >actual &&
test_cmp expect actual
'
test_done