mirror of
https://github.com/git/git
synced 2024-10-06 00:29:28 +00:00
sparse-checkout: create leading directory
When creating the sparse-checkout file, Git does not create the leading directory, "$GIT_DIR/info", if it does not exist. This causes problems if the repository does not have that directory. Therefore, ensure that the leading directory is created. This is the only "open" in builtin/sparse-checkout.c that does not have a leading directory check. (The other one in write_patterns_and_update() does.) Note that the test needs to explicitly specify a template when running "git init" because the default template used in the tests has the "info/" directory included. Helped-by: Jose Lopes <jabolopes@google.com> Signed-off-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
e9d7761bb9
commit
7f44842ac1
|
@ -450,6 +450,9 @@ static int sparse_checkout_init(int argc, const char **argv)
|
|||
FILE *fp;
|
||||
|
||||
/* assume we are in a fresh repo, but update the sparse-checkout file */
|
||||
if (safe_create_leading_directories(sparse_filename))
|
||||
die(_("unable to create leading directories of %s"),
|
||||
sparse_filename);
|
||||
fp = xfopen(sparse_filename, "w");
|
||||
if (!fp)
|
||||
die(_("failed to open '%s'"), sparse_filename);
|
||||
|
|
|
@ -71,6 +71,12 @@ test_expect_success 'git sparse-checkout init' '
|
|||
check_files repo a
|
||||
'
|
||||
|
||||
test_expect_success 'git sparse-checkout init in empty repo' '
|
||||
test_when_finished rm -rf empty-repo blank-template &&
|
||||
git init --template= empty-repo &&
|
||||
git -C empty-repo sparse-checkout init
|
||||
'
|
||||
|
||||
test_expect_success 'git sparse-checkout list after init' '
|
||||
git -C repo sparse-checkout list >actual &&
|
||||
cat >expect <<-\EOF &&
|
||||
|
|
Loading…
Reference in a new issue