mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
bisect--helper: simplify exit code computation
We _already_ have a function to determine whether a given `enum bisect_error` value is non-zero but still _actually_ indicates success. Let's use it instead of duplicating the logic. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
a38d39a4c5
commit
7a8d7aaa47
|
@ -1440,12 +1440,5 @@ int cmd_bisect(int argc, const char **argv, const char *prefix)
|
|||
res = fn(argc, argv, prefix);
|
||||
}
|
||||
|
||||
/*
|
||||
* Handle early success
|
||||
* From check_merge_bases > check_good_are_ancestors_of_bad > bisect_next_all
|
||||
*/
|
||||
if ((res == BISECT_INTERNAL_SUCCESS_MERGE_BASE) || (res == BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND))
|
||||
res = BISECT_OK;
|
||||
|
||||
return -res;
|
||||
return is_bisect_success(res) ? 0 : -res;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue