mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
t0000: drop "known breakage" test
Having a simulated "known breakage" test means that the test suite will always tell us there is a bug to be fixed, even though it is only simulated. The right way to test this is in a sub-test, that can also check that we provide the correct exit status and output. Fortunately, we already have such a test (added much later by5ebf89e
). We could arguably get rid of the simulated success test immediately above, as well, as it is also redundant with the tests added in5ebf89e
. However, it does not have the annoying behavior of the "known breakage" test. It may also be easier to debug if the test suite is truly broken, since it is not a test-within-a-test, as the later tests are. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
a63c12c9be
commit
738a8beac4
|
@ -41,9 +41,6 @@ test_expect_success '.git/objects should have 3 subdirectories' '
|
||||||
test_expect_success 'success is reported like this' '
|
test_expect_success 'success is reported like this' '
|
||||||
:
|
:
|
||||||
'
|
'
|
||||||
test_expect_failure 'pretend we have a known breakage' '
|
|
||||||
false
|
|
||||||
'
|
|
||||||
|
|
||||||
run_sub_test_lib_test () {
|
run_sub_test_lib_test () {
|
||||||
name="$1" descr="$2" # stdin is the body of the test code
|
name="$1" descr="$2" # stdin is the body of the test code
|
||||||
|
|
Loading…
Reference in a new issue