development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-09-30 05:37:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

builtin/bundle: have unbundle check for repo before opening its bundle

Browse source 
The `git bundle unbundle` subcommand requires a repository to unbundle
the contents into. As thus, the subcommand checks whether we have a
startup repository in the first place, and if not it dies.

This check happens after we have already opened the bundle though. This
causes a segfault when running outside of a repository starting with
c8aed5e8da (repository: stop setting SHA1 as the default object hash,
2024-05-07) because we have no hash function set up, but we do try to
parse refs advertised by the bundle's header.

The next commit will fix that underlying issue by defaulting to the SHA1
object format for bundles, which will also fix the described segfault here.
But as we know that we will die anyway, we can do better than that and
avoid some vain work by moving the check for a repository before we try
to open the bundle.

Reported-by: ArcticLampyrid <ArcticLampyrid@outlook.com>
Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt 2024-08-13 11:18:08 +02:00 committed by Junio C Hamano
parent 39bf06adf9
commit 7298bcc573
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
builtin/bundle.c
View file

@ -207,12 +207,13 @@ static int cmd_bundle_unbundle(int argc, const char **argv, const char *prefix)
builtin_bundle_unbundle_usage, options, &bundle_file);
/* bundle internals use argv[1] as further parameters */
if (!startup_info->have_repository)
die(_("Need a repository to unbundle."));
if ((bundle_fd = open_bundle(bundle_file, &header, NULL)) < 0) {
ret = 1;
goto cleanup;
}
if (!startup_info->have_repository)
die(_("Need a repository to unbundle."));
if (progress)
strvec_pushl(&extra_index_pack_args, "-v", "--progress-title",
_("Unbundling objects"), NULL);

7
t/t6020-bundle-misc.sh
View file

@ -652,4 +652,11 @@ test_expect_success 'send a bundle to standard output' '
test_cmp expect actual
'
test_expect_success 'unbundle outside of a repository' '
git bundle create some.bundle HEAD &&
echo "fatal: Need a repository to unbundle." >expect &&
nongit test_must_fail git bundle unbundle "$(pwd)/some.bundle" 2>err &&
test_cmp expect err
'
test_done