From 6ac1b2a3b8bd970e9fc175c42927f00d4d465bbf Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 14 Dec 2011 15:07:09 +0100 Subject: [PATCH] compat/setenv.c: error if name contains '=' According to POSIX, setenv should error out with EINVAL if it's asked to set an environment variable whose name contains an equals sign. Implement this detail in our compatibility-fallback. Signed-off-by: Erik Faye-Lund Signed-off-by: Junio C Hamano --- compat/setenv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/setenv.c b/compat/setenv.c index 89947b7134..fc1439a643 100644 --- a/compat/setenv.c +++ b/compat/setenv.c @@ -6,7 +6,7 @@ int gitsetenv(const char *name, const char *value, int replace) size_t namelen, valuelen; char *envstr; - if (!name || !value) { + if (!name || strchr(name, '=') || !value) { errno = EINVAL; return -1; }