development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-28 12:09:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

record_author_date(): fix memory leak on malformed commit

Browse source 
If we hit the end-of-header without finding an "author"
line, we just return from the function. We should jump to
the fail_exit path to clean up the buffer that we may have
allocated.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2014-08-27 03:56:31 -04:00 committed by Junio C Hamano
parent fe6eb7f2c5
commit 6876618cea
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
commit.c
View file

@ -594,7 +594,7 @@ static void record_author_date(struct author_date_slab *author_date,
line_end = strchrnul(buf, '\n');
if (!skip_prefix(buf, "author ", &ident_line)) {
if (!line_end[0] || line_end[1] == '\n')
return; /* end of header */
goto fail_exit; /* end of header */
continue;
}
if (split_ident_line(&ident,