development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-01 06:05:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'js/diff-cached-fsmonitor-fix'

Browse source 
"git diff --cached" codepath did not fill the necessary stat
information for a file when fsmonitor knows it is clean and ended
up behaving as if it is not clean, which has been corrected.

* js/diff-cached-fsmonitor-fix:
  diff-lib: fix check_removed when fsmonitor is on
This commit is contained in:
Junio C Hamano 2023-09-20 10:44:57 -07:00
parent bd49a2998a 6a044a2048
commit 671eaaac0c
2 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
diff-lib.c
View file

@ -36,14 +36,14 @@
* exists for ce that is a submodule -- it is a submodule that is not
* checked out). Return negative for an error.
*/
static int check_removed(const struct index_state *istate, const struct cache_entry *ce, struct stat *st)
static int check_removed(const struct cache_entry *ce, struct stat *st)
{
assert(is_fsmonitor_refreshed(istate));
if (!(ce->ce_flags & CE_FSMONITOR_VALID) && lstat(ce->name, st) < 0) {
if (lstat(ce->name, st) < 0) {
if (!is_missing_file_error(errno))
return -1;
return 1;
}
if (has_symlink_leading_path(ce->name, ce_namelen(ce)))
return 1;
if (S_ISDIR(st->st_mode)) {
@ -149,7 +149,7 @@ void run_diff_files(struct rev_info *revs, unsigned int option)
memset(&(dpath->parent[0]), 0,
sizeof(struct combine_diff_parent)*5);
changed = check_removed(istate, ce, &st);
changed = check_removed(ce, &st);
if (!changed)
wt_mode = ce_mode_from_stat(ce, st.st_mode);
else {
@ -229,7 +229,7 @@ void run_diff_files(struct rev_info *revs, unsigned int option)
} else {
struct stat st;
changed = check_removed(istate, ce, &st);
changed = check_removed(ce, &st);
if (changed) {
if (changed < 0) {
perror(ce->name);
@ -303,7 +303,7 @@ static int get_stat_data(const struct index_state *istate,
if (!cached && !ce_uptodate(ce)) {
int changed;
struct stat st;
changed = check_removed(istate, ce, &st);
changed = check_removed(ce, &st);
if (changed < 0)
return -1;
else if (changed) {

5
t/t7527-builtin-fsmonitor.sh
View file

@ -809,6 +809,11 @@ my_match_and_clean () {
status --porcelain=v2 >actual.without &&
test_cmp actual.with actual.without &&
git -C super --no-optional-locks diff-index --name-status HEAD >actual.with &&
git -C super --no-optional-locks -c core.fsmonitor=false \
diff-index --name-status HEAD >actual.without &&
test_cmp actual.with actual.without &&
git -C super/dir_1/dir_2/sub reset --hard &&
git -C super/dir_1/dir_2/sub clean -d -f
}