mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
An off-by-one bug found by valgrind
Insufficient memory is allocated in index-pack.c to hold the *.idx name. One more byte should be allocated to hold the terminating 0. Signed-off-by: Pavel Roskin <proski@gnu.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
parent
9470657ad0
commit
6689f08735
|
@ -440,7 +440,7 @@ int main(int argc, char **argv)
|
|||
if (len < 5 || strcmp(pack_name + len - 5, ".pack"))
|
||||
die("packfile name '%s' does not end with '.pack'",
|
||||
pack_name);
|
||||
index_name_buf = xmalloc(len - 1);
|
||||
index_name_buf = xmalloc(len);
|
||||
memcpy(index_name_buf, pack_name, len - 5);
|
||||
strcpy(index_name_buf + len - 5, ".idx");
|
||||
index_name = index_name_buf;
|
||||
|
|
Loading…
Reference in a new issue