mirror of
https://github.com/git/git
synced 2024-10-28 19:25:47 +00:00
t9100-git-svn-basic.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
bdf20f5edd
commit
6560857550
1 changed files with 4 additions and 4 deletions
|
@ -265,18 +265,18 @@ test_expect_success 'able to dcommit to a subdirectory' "
|
|||
git update-index --add d &&
|
||||
git commit -m '/bar/d should be in the log' &&
|
||||
git svn dcommit -i bar &&
|
||||
test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\" &&
|
||||
test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\" &&
|
||||
mkdir newdir &&
|
||||
echo new > newdir/dir &&
|
||||
git update-index --add newdir/dir &&
|
||||
git commit -m 'add a new directory' &&
|
||||
git svn dcommit -i bar &&
|
||||
test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\" &&
|
||||
test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\" &&
|
||||
echo foo >> newdir/dir &&
|
||||
git update-index newdir/dir &&
|
||||
git commit -m 'modify a file in new directory' &&
|
||||
git svn dcommit -i bar &&
|
||||
test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\"
|
||||
test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\"
|
||||
"
|
||||
|
||||
test_expect_success 'dcommit should not fail with a touched file' '
|
||||
|
@ -295,7 +295,7 @@ test_expect_success 'able to set-tree to a subdirectory' "
|
|||
git update-index d &&
|
||||
git commit -m 'update /bar/d' &&
|
||||
git svn set-tree -i bar HEAD &&
|
||||
test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\"
|
||||
test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\"
|
||||
"
|
||||
|
||||
test_expect_success 'git-svn works in a bare repository' '
|
||||
|
|
Loading…
Reference in a new issue