development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-02 14:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

test-string-list.c: Fix some sparse warnings

Browse source 
In particular, sparse complains as follows:

        SP test-string-list.c
    test-string-list.c:10:6: warning: symbol 'parse_string_list' was not \
        declared. Should it be static?
    test-string-list.c:18:6: warning: symbol 'write_list' was not \
        declared. Should it be static?
    test-string-list.c:25:6: warning: symbol 'write_list_compact' was not \
        declared. Should it be static?
    test-string-list.c:38:5: warning: symbol 'prefix_cb' was not \
        declared. Should it be static?

In order to suppress the warnings, since the above symbols do not
need more than file scope, we simply include the static modifier
in their declaration.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ramsay Jones 2012-09-15 17:18:42 +01:00 committed by Junio C Hamano
parent 5f0fc64513
commit 6511987854
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test-string-list.c
View file

@ -7,7 +7,7 @@
* list (as opposed to "", which indicates a string list containing a
* single empty string). list->strdup_strings must be set.
*/
void parse_string_list(struct string_list *list, const char *arg)
static void parse_string_list(struct string_list *list, const char *arg)
{
if (!strcmp(arg, "-"))
return;
@ -15,14 +15,14 @@ void parse_string_list(struct string_list *list, const char *arg)
(void)string_list_split(list, arg, ':', -1);
}
void write_list(const struct string_list *list)
static void write_list(const struct string_list *list)
{
int i;
for (i = 0; i < list->nr; i++)
printf("[%d]: \"%s\"\n", i, list->items[i].string);
}
void write_list_compact(const struct string_list *list)
static void write_list_compact(const struct string_list *list)
{
int i;
if (!list->nr)
@ -35,7 +35,7 @@ void write_list_compact(const struct string_list *list)
}
}
int prefix_cb(struct string_list_item *item, void *cb_data)
static int prefix_cb(struct string_list_item *item, void *cb_data)
{
const char *prefix = (const char *)cb_data;
return !prefixcmp(item->string, prefix);