mirror of
https://github.com/git/git
synced 2024-08-25 02:35:46 +00:00
add: don't complain when adding empty project root
This behavior was added in07d7bed
(add: don't complain when adding empty project root - 2009-04-28) then broken by84b8b5d
(remove match_pathspec() in favor of match_pathspec_depth() - 2013-07-14). Reinstate it. Noticed-by: Thomas Ferris Nicolaisen <tfnico@gmail.com> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
d2446dfd7f
commit
64ed07cee0
|
@ -544,7 +544,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)
|
||||||
|
|
||||||
for (i = 0; i < pathspec.nr; i++) {
|
for (i = 0; i < pathspec.nr; i++) {
|
||||||
const char *path = pathspec.items[i].match;
|
const char *path = pathspec.items[i].match;
|
||||||
if (!seen[i] &&
|
if (!seen[i] && path[0] &&
|
||||||
((pathspec.items[i].magic &
|
((pathspec.items[i].magic &
|
||||||
(PATHSPEC_GLOB | PATHSPEC_ICASE)) ||
|
(PATHSPEC_GLOB | PATHSPEC_ICASE)) ||
|
||||||
!file_exists(path))) {
|
!file_exists(path))) {
|
||||||
|
|
|
@ -272,6 +272,25 @@ test_expect_success '"add non-existent" should fail' '
|
||||||
! (git ls-files | grep "non-existent")
|
! (git ls-files | grep "non-existent")
|
||||||
'
|
'
|
||||||
|
|
||||||
|
test_expect_success 'git add -A on empty repo does not error out' '
|
||||||
|
rm -fr empty &&
|
||||||
|
git init empty &&
|
||||||
|
(
|
||||||
|
cd empty &&
|
||||||
|
git add -A . &&
|
||||||
|
git add -A
|
||||||
|
)
|
||||||
|
'
|
||||||
|
|
||||||
|
test_expect_success '"git add ." in empty repo' '
|
||||||
|
rm -fr empty &&
|
||||||
|
git init empty &&
|
||||||
|
(
|
||||||
|
cd empty &&
|
||||||
|
git add .
|
||||||
|
)
|
||||||
|
'
|
||||||
|
|
||||||
test_expect_success 'git add --dry-run of existing changed file' "
|
test_expect_success 'git add --dry-run of existing changed file' "
|
||||||
echo new >>track-this &&
|
echo new >>track-this &&
|
||||||
git add --dry-run track-this >actual 2>&1 &&
|
git add --dry-run track-this >actual 2>&1 &&
|
||||||
|
|
Loading…
Reference in a new issue