mirror of
https://github.com/git/git
synced 2024-08-28 20:20:07 +00:00
merge: do not pass unused opt->value parameter
The option_parse_strategy() callback does not look at opt->value; instead it calls append_strategy(), which manipulates the global use_strategies array directly. But the OPT_CALLBACK declaration assigns "&use_strategies" to opt->value. One could argue this is good, as it tells the reader what we generally expect the callback to do. But it is also bad, because it can mislead you into thinking that swapping out "&use_strategies" there might have any effect. Let's switch it to pass NULL (which is what every other "does not bother to look at opt->value" callback does). If you want to know what the callback does, it's easy to read the function itself. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
34bf44f2d5
commit
62c5358a5e
|
@ -264,7 +264,7 @@ static struct option builtin_merge_options[] = {
|
||||||
OPT_RERERE_AUTOUPDATE(&allow_rerere_auto),
|
OPT_RERERE_AUTOUPDATE(&allow_rerere_auto),
|
||||||
OPT_BOOL(0, "verify-signatures", &verify_signatures,
|
OPT_BOOL(0, "verify-signatures", &verify_signatures,
|
||||||
N_("verify that the named commit has a valid GPG signature")),
|
N_("verify that the named commit has a valid GPG signature")),
|
||||||
OPT_CALLBACK('s', "strategy", &use_strategies, N_("strategy"),
|
OPT_CALLBACK('s', "strategy", NULL, N_("strategy"),
|
||||||
N_("merge strategy to use"), option_parse_strategy),
|
N_("merge strategy to use"), option_parse_strategy),
|
||||||
OPT_STRVEC('X', "strategy-option", &xopts, N_("option=value"),
|
OPT_STRVEC('X', "strategy-option", &xopts, N_("option=value"),
|
||||||
N_("option for selected merge strategy")),
|
N_("option for selected merge strategy")),
|
||||||
|
|
Loading…
Reference in a new issue