development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-07-17 02:57:48 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

submodule--helper: fix "errmsg_str" memory leak

Browse source 
Fix a memory leak introduced in e83e3333b5 (submodule: port submodule
subcommand 'summary' from shell to C, 2020-08-13), we sometimes append
to the "errmsg", and need to free the "struct strbuf".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2022-09-01 01:14:14 +02:00 committed by Junio C Hamano
parent 87a683482a
commit 61adac6c4b
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
builtin/submodule--helper.c
View file

@ -973,6 +973,7 @@ static void generate_submodule_summary(struct summary_cb *info,
free(displaypath); free(displaypath);
free(src_abbrev); free(src_abbrev);
free(dst_abbrev); free(dst_abbrev);
strbuf_release(&errmsg);
} }
static void prepare_submodule_summary(struct summary_cb *info, static void prepare_submodule_summary(struct summary_cb *info,