development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-30 04:01:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

apply.c:update_pre_post_images(): the preimage can be truncated

Browse source 
5166714 (apply: Allow blank context lines to match beyond EOF,
2010-03-06) and then later 0c3ef98 (apply: Allow blank *trailing*
context lines to match beyond EOF, 2010-04-08) taught "git apply"
to trim new blank lines at the end in the patch text when matching
the contents being patched and the preimage recorded in the patch,
under --whitespace=fix mode.

When a preimage is modified to match the current contents in
preparation for such a "fixed" patch application, the context lines
in the postimage must be updated to match (otherwise, it would
reintroduce whitespace breakages), and update_pre_post_images()
function is responsible for doing this.  However, this function was
not updated to take into account a case where the removal of
trailing blank lines reduces the number of lines in the preimage,
and triggered an assertion error.

The logic to fix the postimage by copying the corrected context
lines from the preimage was not prepared to handle this case,
either, but it was protected by the assert() and only got exposed
when the assertion is corrected.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2012-10-12 15:53:46 -07:00
parent bafc478f16
commit 5de7166d46
1 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
builtin/apply.c
View file

@ -2086,7 +2086,7 @@ static void update_pre_post_images(struct image *preimage,
char *buf, char *buf,
size_t len, size_t postlen) size_t len, size_t postlen)
{ {
int i, ctx; int i, ctx, reduced;
char *new, *old, *fixed; char *new, *old, *fixed;
struct image fixed_preimage; struct image fixed_preimage;
@ -2096,8 +2096,10 @@ static void update_pre_post_images(struct image *preimage,
* free "oldlines". * free "oldlines".
*/ */
prepare_image(&fixed_preimage, buf, len, 1); prepare_image(&fixed_preimage, buf, len, 1);
assert(fixed_preimage.nr == preimage->nr); assert(postlen
for (i = 0; i < preimage->nr; i++) ? fixed_preimage.nr == preimage->nr
: fixed_preimage.nr <= preimage->nr);
for (i = 0; i < fixed_preimage.nr; i++)
fixed_preimage.line[i].flag = preimage->line[i].flag; fixed_preimage.line[i].flag = preimage->line[i].flag;
free(preimage->line_allocated); free(preimage->line_allocated);
*preimage = fixed_preimage; *preimage = fixed_preimage;
@ -2117,7 +2119,8 @@ static void update_pre_post_images(struct image *preimage,
else else
new = old; new = old;
fixed = preimage->buf; fixed = preimage->buf;
for (i = ctx = 0; i < postimage->nr; i++) {
for (i = reduced = ctx = 0; i < postimage->nr; i++) {
size_t len = postimage->line[i].len; size_t len = postimage->line[i].len;
if (!(postimage->line[i].flag & LINE_COMMON)) { if (!(postimage->line[i].flag & LINE_COMMON)) {
/* an added line -- no counterparts in preimage */ /* an added line -- no counterparts in preimage */
@ -2136,8 +2139,15 @@ static void update_pre_post_images(struct image *preimage,
fixed += preimage->line[ctx].len; fixed += preimage->line[ctx].len;
ctx++; ctx++;
} }
if (preimage->nr <= ctx)
die(_("oops")); /*
* preimage is expected to run out, if the caller
* fixed addition of trailing blank lines.
*/
if (preimage->nr <= ctx) {
reduced++;
continue;
}
/* and copy it in, while fixing the line length */ /* and copy it in, while fixing the line length */
len = preimage->line[ctx].len; len = preimage->line[ctx].len;
@ -2150,6 +2160,7 @@ static void update_pre_post_images(struct image *preimage,
/* Fix the length of the whole thing */ /* Fix the length of the whole thing */
postimage->len = new - postimage->buf; postimage->len = new - postimage->buf;
postimage->nr -= reduced;
} }
static int match_fragment(struct image *img, static int match_fragment(struct image *img,