mirror of
https://github.com/git/git
synced 2024-08-28 12:09:19 +00:00
mktag tests: don't create "mytag" twice
Change a test added ine0aaf781f6
(mktag.c: improve verification of tagger field and tests, 2008-03-27) to not create "mytag", which should only be created and verified at the end in an earlier test added in446c6faec6
(New tests and en-passant modifications to mktag., 2006-07-29). While we're at it let's prevent a similar logic error from creeping into the test by asserting that "mytag" doesn't exist before we create it. Let's do this by moving the test to use "update-ref", instead of our own homebrew ad-hoc refstore update. We're not really testing for anything yet by creating the tag at the end here. A subsequent commit will change that. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
317c176279
commit
5c2303e0c7
|
@ -222,7 +222,7 @@ EOF
|
|||
|
||||
test_expect_success \
|
||||
'allow empty tag email' \
|
||||
'git mktag <tag.sig >.git/refs/tags/mytag'
|
||||
'git mktag <tag.sig'
|
||||
|
||||
############################################################
|
||||
# 16. disallow spaces in tag email
|
||||
|
@ -348,16 +348,9 @@ tagger T A Gger <tagger@example.com> 1206478233 -0500
|
|||
|
||||
EOF
|
||||
|
||||
test_expect_success \
|
||||
'create valid tag' \
|
||||
'git mktag <tag.sig >.git/refs/tags/mytag'
|
||||
|
||||
############################################################
|
||||
# 25. check mytag
|
||||
|
||||
test_expect_success \
|
||||
'check mytag' \
|
||||
'git tag -l | grep mytag'
|
||||
|
||||
test_expect_success 'create valid tag' '
|
||||
git mktag <tag.sig >hash &&
|
||||
git update-ref refs/tags/mytag $(cat hash) $(test_oid zero)
|
||||
'
|
||||
|
||||
test_done
|
||||
|
|
Loading…
Reference in a new issue