mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
t9119-git-svn-info.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
1d9e86f80d
commit
57da04965d
|
@ -8,7 +8,7 @@ test_description='git svn info'
|
|||
|
||||
# Tested with: svn, version 1.4.4 (r25188)
|
||||
# Tested with: svn, version 1.6.[12345689]
|
||||
v=`svn_cmd --version | sed -n -e 's/^svn, version \(1\.[0-9]*\.[0-9]*\).*$/\1/p'`
|
||||
v=$(svn_cmd --version | sed -n -e 's/^svn, version \(1\.[0-9]*\.[0-9]*\).*$/\1/p')
|
||||
case $v in
|
||||
1.[456].*)
|
||||
;;
|
||||
|
|
Loading…
Reference in a new issue