development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-11-05 01:58:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

shallow: fix memory leak when registering shallow roots

Browse source 
When registering shallow roots, we unset the list of parents of the
to-be-registered commit if it's already been parsed. This causes us to
leak memory though because we never free this list. Fix this.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt 2023-11-06 11:45:57 +01:00 committed by Junio C Hamano
parent 40e9136ff6
commit 568cc818cc
3 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
shallow.c
View file

@ -38,8 +38,10 @@ int register_shallow(struct repository *r, const struct object_id *oid)
oidcpy(&graft->oid, oid);
graft->nr_parent = -1;
if (commit && commit->object.parsed)
if (commit && commit->object.parsed) {
free_commit_list(commit->parents);
commit->parents = NULL;
}
return register_commit_graft(r, graft, 0);
}

2
t/t5311-pack-bitmaps-shallow.sh
View file

@ -1,6 +1,8 @@
#!/bin/sh
test_description='check bitmap operation with shallow repositories'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh
# We want to create a situation where the shallow, grafted

1
t/t5530-upload-pack-error.sh
View file

@ -2,6 +2,7 @@
test_description='errors in upload-pack'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh
D=$(pwd)