development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-26 11:09:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'sa/send-email-smtp-batch-data-limit' into maint

Browse source 
When "git send-email" wanted to talk over Net::SMTP::SSL,
Net::Cmd::datasend() did not like to be fed too many bytes at the
same time and failed to send messages.  Send the payload one line
at a time to work around the problem.

* sa/send-email-smtp-batch-data-limit:
  git-send-email.perl: Fixed sending of many/huge changes/patches
This commit is contained in:
Junio C Hamano 2015-11-05 12:18:06 -08:00
parent 684fea3794 f60c483d1d
commit 53be145209
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
git-send-email.perl
View file

@ -1365,7 +1365,11 @@ sub send_message {
$smtp->mail( $raw_from ) or die $smtp->message;
$smtp->to( @recipients ) or die $smtp->message;
$smtp->data or die $smtp->message;
$smtp->datasend("$header\n$message") or die $smtp->message;
$smtp->datasend("$header\n") or die $smtp->message;
my @lines = split /^/, $message;
foreach my $line (@lines) {
$smtp->datasend("$line") or die $smtp->message;
}
$smtp->dataend() or die $smtp->message;
$smtp->code =~ /250|200/ or die "Failed to send $subject\n".$smtp->message;
}