mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
compat/fnmatch/fnmatch.c: Fix a sparse error
Sparse issues the following error and warnings: SP compat/fnmatch/fnmatch.c .../fnmatch.c:144:17: warning: Using plain integer as NULL pointer .../fnmatch.c:238:67: warning: Using plain integer as NULL pointer .../fnmatch.c:303:40: error: too many arguments for function getenv The error is caused by the extern declaration for the getenv function not including the function prototype. Without the prototype, sparse effectively sees the declaration as 'char *getenv(void)'. In order to suppress the error, we simply include the function prototype. In order to suppress the warnings, we include the <stddef.h> header which provides an appropriate definition of the NULL macro, rather than using the (inappropriate) default definition at fnmatch.c:132. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
5b62e6374a
commit
4fc8fb48e9
|
@ -25,6 +25,7 @@
|
||||||
# define _GNU_SOURCE 1
|
# define _GNU_SOURCE 1
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
#include <stddef.h>
|
||||||
#include <errno.h>
|
#include <errno.h>
|
||||||
#include <fnmatch.h>
|
#include <fnmatch.h>
|
||||||
#include <ctype.h>
|
#include <ctype.h>
|
||||||
|
@ -121,7 +122,7 @@
|
||||||
whose names are inconsistent. */
|
whose names are inconsistent. */
|
||||||
|
|
||||||
# if !defined _LIBC && !defined getenv
|
# if !defined _LIBC && !defined getenv
|
||||||
extern char *getenv ();
|
extern char *getenv (const char *name);
|
||||||
# endif
|
# endif
|
||||||
|
|
||||||
# ifndef errno
|
# ifndef errno
|
||||||
|
|
Loading…
Reference in a new issue