mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
git-p4: open temporary patch file for write only
The patchRCSKeywords method creates a temporary file in which to store the patched output data. Previously this file was opened in "w+" mode (write and read), but the code never reads the contents of the file while open, so it only needs to be opened in "w" mode (write-only). Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
9732e2229c
commit
4cf67ae1b6
|
@ -1754,7 +1754,7 @@ def patchRCSKeywords(self, file, regexp):
|
|||
# Attempt to zap the RCS keywords in a p4 controlled file matching the given regex
|
||||
(handle, outFileName) = tempfile.mkstemp(dir='.')
|
||||
try:
|
||||
with os.fdopen(handle, "w+") as outFile, open(file, "r") as inFile:
|
||||
with os.fdopen(handle, "w") as outFile, open(file, "r") as inFile:
|
||||
for line in inFile.readlines():
|
||||
outFile.write(regexp.sub(r'$\1$', line))
|
||||
# Forcibly overwrite the original file
|
||||
|
|
Loading…
Reference in a new issue