Merge branch 'jn/log-m-does-not-imply-p'

Earlier "git log -m" was changed to always produce patch output,
which would break existing scripts, which has been reverted.

* jn/log-m-does-not-imply-p:
  Revert 'diff-merges: let "-m" imply "-p"'
This commit is contained in:
Junio C Hamano 2021-08-11 12:36:18 -07:00
commit 4c90d8908a
3 changed files with 6 additions and 7 deletions

View file

@ -49,9 +49,10 @@ ifdef::git-log[]
--diff-merges=m::: --diff-merges=m:::
-m::: -m:::
This option makes diff output for merge commits to be shown in This option makes diff output for merge commits to be shown in
the default format. The default format could be changed using the default format. `-m` will produce the output only if `-p`
is given as well. The default format could be changed using
`log.diffMerges` configuration parameter, which default value `log.diffMerges` configuration parameter, which default value
is `separate`. `-m` implies `-p`. is `separate`.
+ +
--diff-merges=first-parent::: --diff-merges=first-parent:::
--diff-merges=1::: --diff-merges=1:::
@ -61,8 +62,7 @@ ifdef::git-log[]
--diff-merges=separate::: --diff-merges=separate:::
This makes merge commits show the full diff with respect to This makes merge commits show the full diff with respect to
each of the parents. Separate log entry and diff is generated each of the parents. Separate log entry and diff is generated
for each parent. This is the format that `-m` produced for each parent.
historically.
+ +
--diff-merges=combined::: --diff-merges=combined:::
--diff-merges=c::: --diff-merges=c:::

View file

@ -107,7 +107,6 @@ int diff_merges_parse_opts(struct rev_info *revs, const char **argv)
if (!strcmp(arg, "-m")) { if (!strcmp(arg, "-m")) {
set_to_default(revs); set_to_default(revs);
revs->merges_imply_patch = 1;
} else if (!strcmp(arg, "-c")) { } else if (!strcmp(arg, "-c")) {
set_combined(revs); set_combined(revs);
revs->merges_imply_patch = 1; revs->merges_imply_patch = 1;

View file

@ -455,8 +455,8 @@ diff-tree --stat --compact-summary initial mode
diff-tree -R --stat --compact-summary initial mode diff-tree -R --stat --compact-summary initial mode
EOF EOF
test_expect_success 'log -m matches log -m -p' ' test_expect_success 'log -m matches pure log' '
git log -m -p master >result && git log master >result &&
process_diffs result >expected && process_diffs result >expected &&
git log -m >result && git log -m >result &&
process_diffs result >actual && process_diffs result >actual &&