development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-11-05 18:59:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

MinGW: truncate exit()'s argument to lowest 8 bits

Browse source 
For some reason, MinGW's bash cannot reliably detect failure of the child
process if a negative value is passed to exit(). This fixes it by
truncating the exit code in all calls of exit().

This issue was worked around in run_builtin() of git.c (2488df84 builtin
run_command: do not exit with -1, 2007-11-15). This workaround is no longer
necessary and is reverted.

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Sixt 2009-07-05 20:57:46 +02:00 committed by Junio C Hamano
parent 606475f317
commit 47e3de0e79
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
compat/mingw.h
View file

@ -92,6 +92,8 @@ static inline int fcntl(int fd, int cmd, long arg)
errno = EINVAL; errno = EINVAL;
return -1; return -1;
} }
/* bash cannot reliably detect negative return codes as failure */
#define exit(code) exit((code) & 0xff)
/* /*
* simple adaptors * simple adaptors

2
git.c
View file

@ -245,7 +245,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
status = p->fn(argc, argv, prefix); status = p->fn(argc, argv, prefix);
if (status) if (status)
return status & 0xff; return status;
/* Somebody closed stdout? */ /* Somebody closed stdout? */
if (fstat(fileno(stdout), &st)) if (fstat(fileno(stdout), &st))