mirror of
https://github.com/git/git
synced 2024-08-27 19:49:21 +00:00
reftable/stack: unconditionally reload stack after commit
After we have committed an addition to the reftable stack we call `reftable_stack_reload()` to reload the stack and thus reflect the changes that were just added. This function will only conditionally reload the stack in case `stack_uptodate()` tells us that the stack needs reloading. This check is wasteful though because we already know that the stack needs reloading. Call `reftable_stack_reload_maybe_reuse()` instead, which will unconditionally reload the stack. This is merely a conceptual fix, the code in question was not found to cause any problems in practice. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
718a93ecc0
commit
456333eb4d
|
@ -585,7 +585,7 @@ int reftable_addition_commit(struct reftable_addition *add)
|
|||
add->new_tables = NULL;
|
||||
add->new_tables_len = 0;
|
||||
|
||||
err = reftable_stack_reload(add->stack);
|
||||
err = reftable_stack_reload_maybe_reuse(add->stack, 1);
|
||||
if (err)
|
||||
goto done;
|
||||
|
||||
|
|
Loading…
Reference in a new issue