development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-28 03:59:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

gitweb: Quote hash keys, and do not use barewords keys

Browse source 
Ensure that in all references to an element of a hash, the
key is singlequoted, instead of using bareword: use $hash{'key'}
instead of $hash{key}

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Jakub Narebski 2007-04-01 22:22:21 +02:00 committed by Junio C Hamano
parent a23f0a73d1
commit 3be8e720d9
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
gitweb/gitweb.perl
View file

@ -19,7 +19,7 @@
binmode STDOUT, ':utf8';
BEGIN {
CGI->compile() if $ENV{MOD_PERL};
CGI->compile() if $ENV{'MOD_PERL'};
}
our $cgi = new CGI;
@ -1870,16 +1870,16 @@ sub git_print_page_nav {
my %arg = map { $_ => {action=>$_} } @navs;
if (defined $head) {
for (qw(commit commitdiff)) {
$arg{$_}{hash} = $head;
$arg{$_}{'hash'} = $head;
}
if ($current =~ m/^(tree | log | shortlog | commit | commitdiff | search)$/x) {
for (qw(shortlog log)) {
$arg{$_}{hash} = $head;
$arg{$_}{'hash'} = $head;
}
}
}
$arg{tree}{hash} = $treehead if defined $treehead;
$arg{tree}{hash_base} = $treebase if defined $treebase;
$arg{'tree'}{'hash'} = $treehead if defined $treehead;
$arg{'tree'}{'hash_base'} = $treebase if defined $treebase;
print "<div class=\"page_nav\">\n" .
(join " | ",
@ -1927,9 +1927,9 @@ sub git_print_header_div {
my ($action, $title, $hash, $hash_base) = @_;
my %args = ();
$args{action} = $action;
$args{hash} = $hash if $hash;
$args{hash_base} = $hash_base if $hash_base;
$args{'action'} = $action;
$args{'hash'} = $hash if $hash;
$args{'hash_base'} = $hash_base if $hash_base;
print "<div class=\"header\">\n" .
$cgi->a({-href => href(%args), -class => "title"},