From 3b08e5b8c9130f57a38e51557dbb173b9edda5ba Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Thu, 14 Feb 2008 01:34:40 -0500 Subject: [PATCH] Include the fast-import marks table in crash reports If fast-import was not run with --export-marks but we are crashing the frontend application developer may still benefit from having that information available to them. We now include the marks table as part of the crash report if --export-marks was not supplied on the command line. Signed-off-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- fast-import.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fast-import.c b/fast-import.c index 8ef607f7db..117f38c0f1 100644 --- a/fast-import.c +++ b/fast-import.c @@ -372,6 +372,8 @@ static void write_branch_report(FILE *rpt, struct branch *b) fputc('\n', rpt); } +static void dump_marks_helper(FILE *, uintmax_t, struct mark_set *); + static void write_crash_report(const char *err) { char *loc = git_path("fast_import_crash_%d", getpid()); @@ -443,6 +445,14 @@ static void write_crash_report(const char *err) } } + fputc('\n', rpt); + fputs("Marks\n", rpt); + fputs("-----\n", rpt); + if (mark_file) + fprintf(rpt, " exported to %s\n", mark_file); + else + dump_marks_helper(rpt, 0, marks); + fputc('\n', rpt); fputs("-------------------\n", rpt); fputs("END OF CRASH REPORT\n", rpt);