t: local VAR="VAL" (quote positional parameters)

Future-proof test scripts that do

	local VAR=VAL

without quoting VAL (which is OK in POSIX but broken in some shells)
that is a positional parameter, e.g. $4.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2024-04-05 17:08:59 -07:00
parent be34b51049
commit 341aad8d41
4 changed files with 5 additions and 5 deletions

View file

@ -20,7 +20,7 @@ test_checkout_workers () {
BUG "too few arguments to test_checkout_workers"
fi &&
local expected_workers=$1 &&
local expected_workers="$1" &&
shift &&
local trace_file=trace-test-checkout-workers &&

View file

@ -427,7 +427,7 @@ test_expect_success '"add" worktree with orphan branch, lock, and reason' '
# Note: Quoted arguments containing spaces are not supported.
test_wt_add_orphan_hint () {
local context="$1" &&
local use_branch=$2 &&
local use_branch="$2" &&
shift 2 &&
local opts="$*" &&
test_expect_success "'worktree add' show orphan hint in bad/orphan HEAD w/ $context" '

View file

@ -64,7 +64,7 @@ test_expect_success 'log --grep does not find non-reencoded values (latin1)' '
'
triggers_undefined_behaviour () {
local engine=$1
local engine="$1"
case $engine in
fixed)
@ -85,7 +85,7 @@ triggers_undefined_behaviour () {
}
mismatched_git_log () {
local pattern=$1
local pattern="$1"
LC_ALL=$is_IS_locale git log --encoding=ISO-8859-1 --format=%s \
--grep=$pattern

View file

@ -1765,7 +1765,7 @@ test_parse_ls_tree_oids () {
# Choose a port number based on the test script's number and store it in
# the given variable name, unless that variable already contains a number.
test_set_port () {
local var=$1 port
local var="$1" port
if test $# -ne 1 || test -z "$var"
then