mirror of
https://github.com/git/git
synced 2024-08-28 12:09:19 +00:00
t0004: fix timing bug
The test created an initial commit, made .git/objects unwritable and then exercised various codepaths to create loose commit, tree and blob objects to make sure the commands notice failures from these attempts. However, the initial commit was not preceded with test_tick, which made its object name depend on the timestamp. The names of all the later tree and blob objects the test tried to create were static. If the initial commit's object name happened to begin with the same two hexdigits as the tree or blob objects the test later attempted to create, the fan-out directory in which these tree or blob would be created is already created when the initial commit was made, and the object creation succeeds, and commands being tested should not notice any failure --- in short, the test was bogus. This makes the fan-out directories also unwritable, and adds test_tick before the commit object creation to make the test repeatable. The contents of the file to create a blob from "a" to "60" is to force the name of the blob object to begin with "1b", which shares the fan-out directory with the initial commit that is created with the test. This was useful when diagnosing the breakage of this test. Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
b4958181a9
commit
329636b435
|
@ -8,6 +8,7 @@ test_expect_success setup '
|
||||||
|
|
||||||
>file &&
|
>file &&
|
||||||
git add file &&
|
git add file &&
|
||||||
|
test_tick &&
|
||||||
git commit -m initial &&
|
git commit -m initial &&
|
||||||
echo >file &&
|
echo >file &&
|
||||||
git add file
|
git add file
|
||||||
|
@ -17,11 +18,11 @@ test_expect_success setup '
|
||||||
test_expect_success 'write-tree should notice unwritable repository' '
|
test_expect_success 'write-tree should notice unwritable repository' '
|
||||||
|
|
||||||
(
|
(
|
||||||
chmod a-w .git/objects
|
chmod a-w .git/objects .git/objects/?? &&
|
||||||
test_must_fail git write-tree
|
test_must_fail git write-tree
|
||||||
)
|
)
|
||||||
status=$?
|
status=$?
|
||||||
chmod 775 .git/objects
|
chmod 775 .git/objects .git/objects/??
|
||||||
(exit $status)
|
(exit $status)
|
||||||
|
|
||||||
'
|
'
|
||||||
|
@ -29,11 +30,11 @@ test_expect_success 'write-tree should notice unwritable repository' '
|
||||||
test_expect_success 'commit should notice unwritable repository' '
|
test_expect_success 'commit should notice unwritable repository' '
|
||||||
|
|
||||||
(
|
(
|
||||||
chmod a-w .git/objects
|
chmod a-w .git/objects .git/objects/?? &&
|
||||||
test_must_fail git commit -m second
|
test_must_fail git commit -m second
|
||||||
)
|
)
|
||||||
status=$?
|
status=$?
|
||||||
chmod 775 .git/objects
|
chmod 775 .git/objects .git/objects/??
|
||||||
(exit $status)
|
(exit $status)
|
||||||
|
|
||||||
'
|
'
|
||||||
|
@ -41,12 +42,12 @@ test_expect_success 'commit should notice unwritable repository' '
|
||||||
test_expect_success 'update-index should notice unwritable repository' '
|
test_expect_success 'update-index should notice unwritable repository' '
|
||||||
|
|
||||||
(
|
(
|
||||||
echo a >file &&
|
echo 6O >file &&
|
||||||
chmod a-w .git/objects
|
chmod a-w .git/objects .git/objects/?? &&
|
||||||
test_must_fail git update-index file
|
test_must_fail git update-index file
|
||||||
)
|
)
|
||||||
status=$?
|
status=$?
|
||||||
chmod 775 .git/objects
|
chmod 775 .git/objects .git/objects/??
|
||||||
(exit $status)
|
(exit $status)
|
||||||
|
|
||||||
'
|
'
|
||||||
|
@ -55,11 +56,11 @@ test_expect_success 'add should notice unwritable repository' '
|
||||||
|
|
||||||
(
|
(
|
||||||
echo b >file &&
|
echo b >file &&
|
||||||
chmod a-w .git/objects
|
chmod a-w .git/objects .git/objects/?? &&
|
||||||
test_must_fail git add file
|
test_must_fail git add file
|
||||||
)
|
)
|
||||||
status=$?
|
status=$?
|
||||||
chmod 775 .git/objects
|
chmod 775 .git/objects .git/objects/??
|
||||||
(exit $status)
|
(exit $status)
|
||||||
|
|
||||||
'
|
'
|
||||||
|
|
Loading…
Reference in a new issue