mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
completion: extract completing ctags symbol names into helper function
The previous commit doubled the number of __git_match_ctag()'s positional parameters, and, to keep the position of existing parameters for the sake of backwards compatibility, the prefix, current word and suffix parameters ended up in different order than in other functions accepting the same parameters. Then there is a condition checking the existence of the tag file before invoking this function. We could still live with this if there were only a single callsite, but the next commit will add a few more, so it's worth providing a cleaner interface. Add the wrapper function __git_complete_symbol(), which encompasses the condition for checking the presence of the tag file and filling COMPREPLY, and accepts '--opt=val'-style options with default values that keep callsites simpler. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
7826a7865c
commit
2f779f9176
|
@ -1529,6 +1529,34 @@ __git_match_ctag () {
|
|||
" "$2"
|
||||
}
|
||||
|
||||
# Complete symbol names from a tag file.
|
||||
# Usage: __git_complete_symbol [<option>]...
|
||||
# --tags=<file>: The tag file to list symbol names from instead of the
|
||||
# default "tags".
|
||||
# --pfx=<prefix>: A prefix to be added to each symbol name.
|
||||
# --cur=<word>: The current symbol name to be completed. Defaults to
|
||||
# the current word to be completed.
|
||||
# --sfx=<suffix>: A suffix to be appended to each symbol name instead
|
||||
# of the default space.
|
||||
__git_complete_symbol () {
|
||||
local tags=tags pfx="" cur_="${cur-}" sfx=" "
|
||||
|
||||
while test $# != 0; do
|
||||
case "$1" in
|
||||
--tags=*) tags="${1##--tags=}" ;;
|
||||
--pfx=*) pfx="${1##--pfx=}" ;;
|
||||
--cur=*) cur_="${1##--cur=}" ;;
|
||||
--sfx=*) sfx="${1##--sfx=}" ;;
|
||||
*) return 1 ;;
|
||||
esac
|
||||
shift
|
||||
done
|
||||
|
||||
if test -r "$tags"; then
|
||||
__gitcomp_direct "$(__git_match_ctag "$cur_" "$tags" "$pfx" "$sfx")"
|
||||
fi
|
||||
}
|
||||
|
||||
_git_grep ()
|
||||
{
|
||||
__git_has_doubledash && return
|
||||
|
@ -1554,10 +1582,7 @@ _git_grep ()
|
|||
|
||||
case "$cword,$prev" in
|
||||
2,*|*,-*)
|
||||
if test -r tags; then
|
||||
__gitcomp_direct "$(__git_match_ctag "$cur" tags "" " ")"
|
||||
return
|
||||
fi
|
||||
__git_complete_symbol && return
|
||||
;;
|
||||
esac
|
||||
|
||||
|
|
Loading…
Reference in a new issue