mirror of
https://github.com/git/git
synced 2024-08-27 11:39:22 +00:00
add -i: use the built-in version when feature.experimental is set
We have had parallel implementations of "add -i/-p" since 2.25 and have been using them from various codepaths since 2.26 days, but never made the built-in version the default. We have found and fixed a handful of corner case bugs in the built-in version, and it may be a good time to start switching over the user base from the scripted version to the built-in version. Let's enable the built-in version for those who opt into the feature.experimental guinea-pig program to give wider exposure. Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
3a238e539b
commit
2df2d81ddd
|
@ -192,9 +192,15 @@ int run_add_interactive(const char *revision, const char *patch_mode,
|
||||||
int use_builtin_add_i =
|
int use_builtin_add_i =
|
||||||
git_env_bool("GIT_TEST_ADD_I_USE_BUILTIN", -1);
|
git_env_bool("GIT_TEST_ADD_I_USE_BUILTIN", -1);
|
||||||
|
|
||||||
if (use_builtin_add_i < 0)
|
if (use_builtin_add_i < 0) {
|
||||||
git_config_get_bool("add.interactive.usebuiltin",
|
int experimental;
|
||||||
&use_builtin_add_i);
|
if (!git_config_get_bool("add.interactive.usebuiltin",
|
||||||
|
&use_builtin_add_i))
|
||||||
|
; /* ok */
|
||||||
|
else if (!git_config_get_bool("feature.experimental", &experimental) &&
|
||||||
|
experimental)
|
||||||
|
use_builtin_add_i = 1;
|
||||||
|
}
|
||||||
|
|
||||||
if (use_builtin_add_i == 1) {
|
if (use_builtin_add_i == 1) {
|
||||||
enum add_p_mode mode;
|
enum add_p_mode mode;
|
||||||
|
|
Loading…
Reference in a new issue