development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-09-29 21:27:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

t-reftable-block: use xstrfmt() instead of xstrdup()

Browse source 
Use xstrfmt() to assign a formatted string to a ref record's
refname instead of xstrdup(). This helps save the overhead of
a local 'char' buffer as well as makes the test more compact.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Chandra Pratap 2024-08-21 18:00:57 +05:30 committed by Junio C Hamano
parent 31216ee28a
commit 29ee6d5a20
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
t/unit-tests/t-reftable-block.c
View file

@ -44,10 +44,7 @@ static void t_block_read_write(void)
check_int(ret, ==, REFTABLE_API_ERROR);
for (i = 0; i < N; i++) {
char name[100];
snprintf(name, sizeof(name), "branch%02"PRIuMAX, (uintmax_t)i);
rec.u.ref.refname = xstrdup(name);
rec.u.ref.refname = xstrfmt("branch%02"PRIuMAX, (uintmax_t)i);
rec.u.ref.value_type = REFTABLE_REF_VAL1;
memset(rec.u.ref.value.val1, i, GIT_SHA1_RAWSZ);