development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-24 18:26:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

verify-tag: update variable name and type

Browse source 
The run_gpg_verify() function has two variables, size and len.

This may come off as confusing when reading the code. Clarify which one
pertains to the length of the tag headers by renaming len to
payload_size. Additionally, change the type of payload_size to size_t to
match the return type of parse_signature.

Signed-off-by: Santiago Torres <santiago@nyu.edu>
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Santiago Torres 2016-04-19 13:47:18 -04:00 committed by Junio C Hamano
parent 3e1e7454cc
commit 20972f54d3
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
builtin/verify-tag.c
View file

@ -21,20 +21,21 @@ static const char * const verify_tag_usage[] = {
static int run_gpg_verify(const char *buf, unsigned long size, unsigned flags)
{
struct signature_check sigc;
int len;
size_t payload_size;
int ret;
memset(&sigc, 0, sizeof(sigc));
len = parse_signature(buf, size);
payload_size = parse_signature(buf, size);
if (size == len) {
if (size == payload_size) {
if (flags & GPG_VERIFY_VERBOSE)
write_in_full(1, buf, len);
write_in_full(1, buf, payload_size);
return error("no signature found");
}
ret = check_signature(buf, len, buf + len, size - len, &sigc);
ret = check_signature(buf, payload_size, buf + payload_size,
size - payload_size, &sigc);
print_signature_buffer(&sigc, flags);
signature_check_clear(&sigc);