development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-08-28 12:09:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_must_be_empty: make sure the file exists, not just empty

Browse source 
The helper function test_must_be_empty is meant to make sure the
given file is empty, but its implementation is:

	if test -s "$1"
	then
		... not empty, we detected a failure ...
	fi

Surely, the file having non-zero size is a sign that the condition
"the file must be empty" is violated, but it misses the case where
the file does not even exist.  It is an accident waiting to happen
with a buggy test like this:

	git frotz 2>error-message &&
	test_must_be_empty errro-message

that won't get caught until you deliberately break 'git frotz' and
notice why the test does not fail.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2018-02-27 13:27:29 -08:00
parent 38e79b1fda
commit 11395a3b4b
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
t/test-lib-functions.sh
View file

@ -718,7 +718,11 @@ verbose () {
# otherwise.
test_must_be_empty () {
if test -s "$1"
if ! test -f "$1"
then
echo "'$1' is missing"
return 1
elif test -s "$1"
then
echo "'$1' is not empty, it contains:"
cat "$1"