development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-07-02 15:48:44 +00:00
Code Issues Projects Releases Wiki Activity

generate-cmdlist.sh: don't call get_categories() from category_list()

Browse Source 
This isn't for optimization as the get_categories() is a purely shell
function, but rather for ease of readability, let's just inline these
two lines. We'll be changing this code some more in subsequent commits
to make this worth it.

Rename the get_categories() function to get_category_line(), since
that's what it's doing now.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2021-11-05 15:08:02 +01:00 committed by Junio C Hamano
parent 191eb491ed
commit 0f05f22516
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
generate-cmdlist.sh
View File

@ -9,7 +9,7 @@ command_list () {
eval "grep -ve '^#' $exclude_programs" <"$1"
}
get_categories () {
get_category_line () {
tr ' ' '\012' |
LC_ALL=C sort -u
}
@ -17,7 +17,8 @@ get_categories () {
category_list () {
command_list "$1" |
cut -c 40- |
get_categories |
tr ' ' '\012' |
LC_ALL=C sort -u |
grep -v '^$'
}
@ -66,7 +67,7 @@ print_command_list () {
while read cmd rest
do
printf " { \"$cmd\", $(get_synopsis $cmd), 0"
for cat in $(echo "$rest" | get_categories)
for cat in $(echo "$rest" | get_category_line)
do
printf " | CAT_$cat"
done