mirror of
https://github.com/git/git
synced 2024-08-28 20:20:07 +00:00
diff test: reading a directory as a file need not error out
There is no guarantee that strbuf_read_file must error out for directories. On some operating systems (e.g., Debian GNU/kFreeBSD wheezy), reading a directory gives its raw content: $ head -c5 < / | cat -A ^AM-|^_^@^L$ As a result, 'git diff -O/' succeeds instead of erroring out on these systems, causing t4056.5 "orderfile is a directory" to fail. On some weird OS it might even make sense to pass a directory to the -O option and this is not a common user mistake that needs catching. Remove the test. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
6d8940b562
commit
0df49bef95
|
@ -68,10 +68,6 @@ test_expect_success POSIXPERM,SANITY 'unreadable orderfile' '
|
|||
test_must_fail git diff -Ounreadable_file --name-only HEAD^..HEAD
|
||||
'
|
||||
|
||||
test_expect_success 'orderfile is a directory' '
|
||||
test_must_fail git diff -O/ --name-only HEAD^..HEAD
|
||||
'
|
||||
|
||||
for i in 1 2
|
||||
do
|
||||
test_expect_success "orderfile using option ($i)" '
|
||||
|
|
Loading…
Reference in a new issue