2008-09-29 20:28:57 +00:00
|
|
|
#!/bin/sh
|
|
|
|
#
|
|
|
|
# Copyright(C) 2008 Stephen Habermann & Andreas Ericsson
|
|
|
|
#
|
|
|
|
test_description='git rebase -p should preserve merges
|
|
|
|
|
|
|
|
Run "git rebase -p" and check that merges are properly carried along
|
|
|
|
'
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
2018-10-31 20:02:02 +00:00
|
|
|
if ! test_have_prereq REBASE_P; then
|
|
|
|
skip_all='skipping git rebase -p tests, as asked for'
|
|
|
|
test_done
|
|
|
|
fi
|
|
|
|
|
2008-09-29 20:28:57 +00:00
|
|
|
GIT_AUTHOR_EMAIL=bogus_email_address
|
|
|
|
export GIT_AUTHOR_EMAIL
|
|
|
|
|
2008-12-15 10:05:30 +00:00
|
|
|
# Clone 2 (conflicting merge):
|
|
|
|
#
|
|
|
|
# A1--A2--B3 <-- origin/master
|
|
|
|
# \ \
|
|
|
|
# B1------M <-- topic
|
|
|
|
# \
|
|
|
|
# B2 <-- origin/topic
|
|
|
|
#
|
git-rebase--interactive.sh: preserve-merges fails on merges created with no-ff
'git rebase' uses 'git merge' to preserve merges (-p). This preserves
the original merge commit correctly, except when the original merge
commit was created by 'git merge --no-ff'. In this case, 'git rebase'
will fail to preserve the merge, because during 'git rebase', 'git
merge' will simply fast-forward and skip the commit. For example:
B
/ \
A---M
/
---o---O---P---Q
If we try to rebase M onto P, we lose the merge commit and this happens:
A---B
/
---o---O---P---Q
To correct this, we simply do a "no fast-forward" on all merge commits
when rebasing. Since by the time we decided to do a 'git merge' inside
'git rebase', it means there was a merge originally, so 'git merge'
should always create a merge commit regardless of what the merge
branches look like. This way, when rebase M onto P from the above
example, we get:
B
/ \
A---M
/
---o---O---P---Q
Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-04-28 04:35:55 +00:00
|
|
|
# Clone 3 (no-ff merge):
|
|
|
|
#
|
|
|
|
# A1--A2--B3 <-- origin/master
|
|
|
|
# \
|
|
|
|
# B1------M <-- topic
|
|
|
|
# \ /
|
|
|
|
# \--A3 <-- topic2
|
|
|
|
# \
|
|
|
|
# B2 <-- origin/topic
|
2013-08-21 18:48:57 +00:00
|
|
|
#
|
|
|
|
# Clone 4 (same as Clone 3)
|
2008-09-29 20:28:57 +00:00
|
|
|
|
|
|
|
test_expect_success 'setup for merge-preserving rebase' \
|
|
|
|
'echo First > A &&
|
|
|
|
git add A &&
|
2009-11-28 18:38:55 +00:00
|
|
|
git commit -m "Add A1" &&
|
2008-09-29 20:28:57 +00:00
|
|
|
git checkout -b topic &&
|
|
|
|
echo Second > B &&
|
|
|
|
git add B &&
|
2009-11-28 18:38:55 +00:00
|
|
|
git commit -m "Add B1" &&
|
2008-09-29 20:28:57 +00:00
|
|
|
git checkout -f master &&
|
|
|
|
echo Third >> A &&
|
2009-11-28 18:38:55 +00:00
|
|
|
git commit -a -m "Modify A2" &&
|
2008-12-15 10:05:30 +00:00
|
|
|
echo Fifth > B &&
|
|
|
|
git add B &&
|
|
|
|
git commit -m "Add different B" &&
|
2008-09-29 20:28:57 +00:00
|
|
|
|
2008-12-15 10:05:30 +00:00
|
|
|
git clone ./. clone2 &&
|
2010-09-07 01:42:54 +00:00
|
|
|
(
|
|
|
|
cd clone2 &&
|
|
|
|
git checkout -b topic origin/topic &&
|
|
|
|
test_must_fail git merge origin/master &&
|
|
|
|
echo Resolved >B &&
|
|
|
|
git add B &&
|
|
|
|
git commit -m "Merge origin/master into topic"
|
2010-09-06 18:39:54 +00:00
|
|
|
) &&
|
2008-09-29 20:28:57 +00:00
|
|
|
|
git-rebase--interactive.sh: preserve-merges fails on merges created with no-ff
'git rebase' uses 'git merge' to preserve merges (-p). This preserves
the original merge commit correctly, except when the original merge
commit was created by 'git merge --no-ff'. In this case, 'git rebase'
will fail to preserve the merge, because during 'git rebase', 'git
merge' will simply fast-forward and skip the commit. For example:
B
/ \
A---M
/
---o---O---P---Q
If we try to rebase M onto P, we lose the merge commit and this happens:
A---B
/
---o---O---P---Q
To correct this, we simply do a "no fast-forward" on all merge commits
when rebasing. Since by the time we decided to do a 'git merge' inside
'git rebase', it means there was a merge originally, so 'git merge'
should always create a merge commit regardless of what the merge
branches look like. This way, when rebase M onto P from the above
example, we get:
B
/ \
A---M
/
---o---O---P---Q
Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-04-28 04:35:55 +00:00
|
|
|
git clone ./. clone3 &&
|
|
|
|
(
|
|
|
|
cd clone3 &&
|
|
|
|
git checkout -b topic2 origin/topic &&
|
|
|
|
echo Sixth > A &&
|
|
|
|
git commit -a -m "Modify A3" &&
|
|
|
|
git checkout -b topic origin/topic &&
|
|
|
|
git merge --no-ff topic2
|
|
|
|
) &&
|
|
|
|
|
2013-08-21 18:48:57 +00:00
|
|
|
git clone ./. clone4 &&
|
|
|
|
(
|
|
|
|
cd clone4 &&
|
|
|
|
git checkout -b topic2 origin/topic &&
|
|
|
|
echo Sixth > A &&
|
|
|
|
git commit -a -m "Modify A3" &&
|
|
|
|
git checkout -b topic origin/topic &&
|
|
|
|
git merge --no-ff topic2
|
|
|
|
) &&
|
|
|
|
|
2008-09-29 20:28:57 +00:00
|
|
|
git checkout topic &&
|
|
|
|
echo Fourth >> B &&
|
|
|
|
git commit -a -m "Modify B2"
|
|
|
|
'
|
|
|
|
|
2008-12-15 10:05:31 +00:00
|
|
|
test_expect_success '--continue works after a conflict' '
|
2008-12-15 10:05:30 +00:00
|
|
|
(
|
|
|
|
cd clone2 &&
|
|
|
|
git fetch &&
|
|
|
|
test_must_fail git rebase -p origin/topic &&
|
|
|
|
test 2 = $(git ls-files B | wc -l) &&
|
|
|
|
echo Resolved again > B &&
|
|
|
|
test_must_fail git rebase --continue &&
|
2008-12-22 21:16:51 +00:00
|
|
|
grep "^@@@ " .git/rebase-merge/patch &&
|
2008-12-15 10:05:30 +00:00
|
|
|
git add B &&
|
|
|
|
git rebase --continue &&
|
|
|
|
test 1 = $(git rev-list --all --pretty=oneline | grep "Modify A" | wc -l) &&
|
|
|
|
test 1 = $(git rev-list --all --pretty=oneline | grep "Add different" | wc -l) &&
|
|
|
|
test 1 = $(git rev-list --all --pretty=oneline | grep "Merge origin" | wc -l)
|
|
|
|
)
|
2008-09-29 20:28:57 +00:00
|
|
|
'
|
|
|
|
|
git-rebase--interactive.sh: preserve-merges fails on merges created with no-ff
'git rebase' uses 'git merge' to preserve merges (-p). This preserves
the original merge commit correctly, except when the original merge
commit was created by 'git merge --no-ff'. In this case, 'git rebase'
will fail to preserve the merge, because during 'git rebase', 'git
merge' will simply fast-forward and skip the commit. For example:
B
/ \
A---M
/
---o---O---P---Q
If we try to rebase M onto P, we lose the merge commit and this happens:
A---B
/
---o---O---P---Q
To correct this, we simply do a "no fast-forward" on all merge commits
when rebasing. Since by the time we decided to do a 'git merge' inside
'git rebase', it means there was a merge originally, so 'git merge'
should always create a merge commit regardless of what the merge
branches look like. This way, when rebase M onto P from the above
example, we get:
B
/ \
A---M
/
---o---O---P---Q
Signed-off-by: Andrew Wong <andrew.kw.w@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-04-28 04:35:55 +00:00
|
|
|
test_expect_success 'rebase -p preserves no-ff merges' '
|
|
|
|
(
|
|
|
|
cd clone3 &&
|
|
|
|
git fetch &&
|
|
|
|
git rebase -p origin/topic &&
|
|
|
|
test 3 = $(git rev-list --all --pretty=oneline | grep "Modify A" | wc -l) &&
|
|
|
|
test 1 = $(git rev-list --all --pretty=oneline | grep "Merge branch" | wc -l)
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2013-08-21 18:48:57 +00:00
|
|
|
test_expect_success 'rebase -p ignores merge.log config' '
|
|
|
|
(
|
|
|
|
cd clone4 &&
|
|
|
|
git fetch &&
|
|
|
|
git -c merge.log=1 rebase -p origin/topic &&
|
|
|
|
echo >expected &&
|
|
|
|
git log --format="%b" -1 >current &&
|
|
|
|
test_cmp expected current
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2008-09-29 20:28:57 +00:00
|
|
|
test_done
|