2005-12-14 22:48:19 +00:00
|
|
|
#!/bin/sh
|
|
|
|
#
|
|
|
|
# Copyright (c) 2005 Amos Waterland
|
|
|
|
#
|
|
|
|
|
2009-08-05 03:31:59 +00:00
|
|
|
test_description='git rebase assorted tests
|
2005-12-14 22:48:19 +00:00
|
|
|
|
2009-08-05 03:31:59 +00:00
|
|
|
This test runs git rebase and checks that the author information is not lost
|
|
|
|
among other things.
|
2005-12-14 22:48:19 +00:00
|
|
|
'
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
2010-06-16 07:12:40 +00:00
|
|
|
GIT_AUTHOR_NAME=author@name
|
|
|
|
GIT_AUTHOR_EMAIL=bogus@email@address
|
|
|
|
export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL
|
2005-12-14 22:48:19 +00:00
|
|
|
|
2010-07-23 17:05:24 +00:00
|
|
|
test_expect_success 'prepare repository with topic branches' '
|
|
|
|
git config core.logAllRefUpdates true &&
|
|
|
|
echo First >A &&
|
|
|
|
git update-index --add A &&
|
|
|
|
git commit -m "Add A." &&
|
2008-11-11 00:15:49 +00:00
|
|
|
git checkout -b force-3way &&
|
|
|
|
echo Dummy >Y &&
|
|
|
|
git update-index --add Y &&
|
|
|
|
git commit -m "Add Y." &&
|
|
|
|
git checkout -b filemove &&
|
|
|
|
git reset --soft master &&
|
|
|
|
mkdir D &&
|
|
|
|
git mv A D/A &&
|
|
|
|
git commit -m "Move A." &&
|
|
|
|
git checkout -b my-topic-branch master &&
|
2010-07-23 17:05:24 +00:00
|
|
|
echo Second >B &&
|
|
|
|
git update-index --add B &&
|
|
|
|
git commit -m "Add B." &&
|
|
|
|
git checkout -f master &&
|
|
|
|
echo Third >>A &&
|
|
|
|
git update-index A &&
|
|
|
|
git commit -m "Modify A." &&
|
|
|
|
git checkout -b side my-topic-branch &&
|
|
|
|
echo Side >>C &&
|
|
|
|
git add C &&
|
|
|
|
git commit -m "Add C" &&
|
|
|
|
git checkout -f my-topic-branch &&
|
|
|
|
git tag topic
|
2007-07-04 20:09:10 +00:00
|
|
|
'
|
|
|
|
|
2009-05-23 15:31:02 +00:00
|
|
|
test_expect_success 'rebase on dirty worktree' '
|
2010-07-23 17:05:24 +00:00
|
|
|
echo dirty >>A &&
|
|
|
|
test_must_fail git rebase master
|
|
|
|
'
|
2009-05-23 15:31:02 +00:00
|
|
|
|
|
|
|
test_expect_success 'rebase on dirty cache' '
|
2010-07-23 17:05:24 +00:00
|
|
|
git add A &&
|
|
|
|
test_must_fail git rebase master
|
|
|
|
'
|
2009-05-23 15:31:02 +00:00
|
|
|
|
2007-07-04 20:09:10 +00:00
|
|
|
test_expect_success 'rebase against master' '
|
2010-07-23 17:05:24 +00:00
|
|
|
git reset --hard HEAD &&
|
|
|
|
git rebase master
|
|
|
|
'
|
2005-12-14 22:48:19 +00:00
|
|
|
|
2019-03-03 17:11:55 +00:00
|
|
|
test_expect_success 'rebase sets ORIG_HEAD to pre-rebase state' '
|
2019-03-03 17:11:54 +00:00
|
|
|
git checkout -b orig-head topic &&
|
|
|
|
pre="$(git rev-parse --verify HEAD)" &&
|
|
|
|
git rebase master &&
|
|
|
|
test_cmp_rev "$pre" ORIG_HEAD &&
|
2019-11-12 23:07:45 +00:00
|
|
|
test_cmp_rev ! "$pre" HEAD
|
2019-03-03 17:11:54 +00:00
|
|
|
'
|
|
|
|
|
2013-06-14 13:17:52 +00:00
|
|
|
test_expect_success 'rebase, with <onto> and <upstream> specified as :/quuxery' '
|
2013-06-14 13:17:50 +00:00
|
|
|
test_when_finished "git branch -D torebase" &&
|
|
|
|
git checkout -b torebase my-topic-branch^ &&
|
|
|
|
upstream=$(git rev-parse ":/Add B") &&
|
|
|
|
onto=$(git rev-parse ":/Add A") &&
|
|
|
|
git rebase --onto $onto $upstream &&
|
|
|
|
git reset --hard my-topic-branch^ &&
|
|
|
|
git rebase --onto ":/Add A" ":/Add B" &&
|
|
|
|
git checkout my-topic-branch
|
|
|
|
'
|
|
|
|
|
2010-07-23 17:05:24 +00:00
|
|
|
test_expect_success 'the rebase operation should not have destroyed author information' '
|
|
|
|
! (git log | grep "Author:" | grep "<>")
|
|
|
|
'
|
2005-12-14 22:48:19 +00:00
|
|
|
|
2010-07-23 17:05:24 +00:00
|
|
|
test_expect_success 'the rebase operation should not have destroyed author information (2)' "
|
|
|
|
git log -1 |
|
|
|
|
grep 'Author: $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL>'
|
|
|
|
"
|
2010-06-16 07:12:40 +00:00
|
|
|
|
2009-03-01 10:20:03 +00:00
|
|
|
test_expect_success 'HEAD was detached during rebase' '
|
2010-07-23 17:05:24 +00:00
|
|
|
test $(git rev-parse HEAD@{1}) != $(git rev-parse my-topic-branch@{1})
|
2009-03-01 10:20:03 +00:00
|
|
|
'
|
|
|
|
|
2013-04-23 22:51:14 +00:00
|
|
|
test_expect_success 'rebase from ambiguous branch name' '
|
|
|
|
git checkout -b topic side &&
|
|
|
|
git rebase master
|
|
|
|
'
|
|
|
|
|
2014-03-19 11:02:15 +00:00
|
|
|
test_expect_success 'rebase off of the previous branch using "-"' '
|
|
|
|
git checkout master &&
|
|
|
|
git checkout HEAD^ &&
|
|
|
|
git rebase @{-1} >expect.messages &&
|
|
|
|
git merge-base master HEAD >expect.forkpoint &&
|
|
|
|
|
|
|
|
git checkout master &&
|
|
|
|
git checkout HEAD^ &&
|
|
|
|
git rebase - >actual.messages &&
|
|
|
|
git merge-base master HEAD >actual.forkpoint &&
|
|
|
|
|
|
|
|
test_cmp expect.forkpoint actual.forkpoint &&
|
|
|
|
# the next one is dubious---we may want to say "-",
|
|
|
|
# instead of @{-1}, in the message
|
|
|
|
test_i18ncmp expect.messages actual.messages
|
|
|
|
'
|
|
|
|
|
2007-09-17 00:24:57 +00:00
|
|
|
test_expect_success 'rebase a single mode change' '
|
2010-07-23 17:05:24 +00:00
|
|
|
git checkout master &&
|
2013-06-07 06:11:41 +00:00
|
|
|
git branch -D topic &&
|
2010-07-23 17:05:24 +00:00
|
|
|
echo 1 >X &&
|
|
|
|
git add X &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m prepare &&
|
|
|
|
git checkout -b modechange HEAD^ &&
|
|
|
|
echo 1 >X &&
|
|
|
|
git add X &&
|
|
|
|
test_chmod +x A &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m modechange &&
|
|
|
|
GIT_TRACE=1 git rebase master
|
2007-09-17 00:24:57 +00:00
|
|
|
'
|
|
|
|
|
2008-11-11 00:15:49 +00:00
|
|
|
test_expect_success 'rebase is not broken by diff.renames' '
|
2013-03-24 21:06:03 +00:00
|
|
|
test_config diff.renames copies &&
|
2008-11-11 00:15:49 +00:00
|
|
|
git checkout filemove &&
|
|
|
|
GIT_TRACE=1 git rebase force-3way
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'setup: recover' '
|
|
|
|
test_might_fail git rebase --abort &&
|
|
|
|
git reset --hard &&
|
|
|
|
git checkout modechange
|
|
|
|
'
|
|
|
|
|
2009-02-09 05:40:42 +00:00
|
|
|
test_expect_success 'Show verbose error when HEAD could not be detached' '
|
2010-07-23 17:05:24 +00:00
|
|
|
>B &&
|
t3400: make test clean up after itself
This test intentionally creates a file which causes rebase to fail, thus
it is important that this file be deleted before subsequent tests are
run which are not expecting such a failure. In the past, the common way
to ensure cleanup (regardless of whether the test succeeded or failed)
was either for the next test to perform the previous test's cleanup as
its first step or to do the cleanup at global scope outside of any
tests. With the introduction of 'test_when_finished', however, tests can
be responsible for their own cleanup. Therefore, update this test to
clean up after itself.
A bit of history: This 'rm' invocation was moved from within the body of
the following test to global scope by bffd750adf (rebase: improve error
message when upstream argument is missing, 2010-05-31), which postdates,
by about a month, introduction of 'test_when_finished' in 3bf7886705
(test-lib: Let tests specify commands to be run at end of test,
2010-05-02).
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-02-23 10:14:06 +00:00
|
|
|
test_when_finished "rm -f B" &&
|
2010-07-23 17:05:24 +00:00
|
|
|
test_must_fail git rebase topic 2>output.err >output.out &&
|
2016-06-17 20:21:08 +00:00
|
|
|
test_i18ngrep "The following untracked working tree files would be overwritten by checkout:" output.err &&
|
|
|
|
test_i18ngrep B output.err
|
2009-02-09 05:40:42 +00:00
|
|
|
'
|
2010-05-31 22:51:32 +00:00
|
|
|
|
2011-02-10 01:54:02 +00:00
|
|
|
test_expect_success 'fail when upstream arg is missing and not on branch' '
|
|
|
|
git checkout topic &&
|
2012-03-04 04:41:26 +00:00
|
|
|
test_must_fail git rebase
|
2011-02-10 01:54:02 +00:00
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'fail when upstream arg is missing and not configured' '
|
|
|
|
git checkout -b no-config topic &&
|
2012-03-04 04:41:26 +00:00
|
|
|
test_must_fail git rebase
|
2011-02-10 01:54:02 +00:00
|
|
|
'
|
|
|
|
|
2019-12-04 21:25:11 +00:00
|
|
|
test_expect_success 'rebase works with format.useAutoBase' '
|
2019-12-04 21:24:50 +00:00
|
|
|
test_config format.useAutoBase true &&
|
|
|
|
git checkout topic &&
|
|
|
|
git rebase master
|
|
|
|
'
|
|
|
|
|
2020-02-15 21:36:29 +00:00
|
|
|
test_expect_success 'default to common base in @{upstream}s reflog if no upstream arg (--merge)' '
|
2014-01-09 19:47:34 +00:00
|
|
|
git checkout -b default-base master &&
|
2011-02-10 01:54:02 +00:00
|
|
|
git checkout -b default topic &&
|
2011-12-08 13:10:17 +00:00
|
|
|
git config branch.default.remote . &&
|
2014-01-09 19:47:34 +00:00
|
|
|
git config branch.default.merge refs/heads/default-base &&
|
2020-02-15 21:36:29 +00:00
|
|
|
git rebase --merge &&
|
|
|
|
git rev-parse --verify default-base >expect &&
|
|
|
|
git rev-parse default~1 >actual &&
|
|
|
|
test_cmp expect actual &&
|
|
|
|
git checkout default-base &&
|
|
|
|
git reset --hard HEAD^ &&
|
|
|
|
git checkout default &&
|
|
|
|
git rebase --merge &&
|
|
|
|
git rev-parse --verify default-base >expect &&
|
|
|
|
git rev-parse default~1 >actual &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
2020-02-15 21:36:41 +00:00
|
|
|
test_expect_success 'default to common base in @{upstream}s reflog if no upstream arg (--apply)' '
|
2020-02-15 21:36:29 +00:00
|
|
|
git checkout -B default-base master &&
|
|
|
|
git checkout -B default topic &&
|
|
|
|
git config branch.default.remote . &&
|
|
|
|
git config branch.default.merge refs/heads/default-base &&
|
2020-02-15 21:36:41 +00:00
|
|
|
git rebase --apply &&
|
2014-01-09 19:47:34 +00:00
|
|
|
git rev-parse --verify default-base >expect &&
|
|
|
|
git rev-parse default~1 >actual &&
|
|
|
|
test_cmp expect actual &&
|
|
|
|
git checkout default-base &&
|
|
|
|
git reset --hard HEAD^ &&
|
|
|
|
git checkout default &&
|
2020-02-15 21:36:41 +00:00
|
|
|
git rebase --apply &&
|
2014-01-09 19:47:34 +00:00
|
|
|
git rev-parse --verify default-base >expect &&
|
2013-12-09 23:16:16 +00:00
|
|
|
git rev-parse default~1 >actual &&
|
|
|
|
test_cmp expect actual
|
2010-05-31 22:51:32 +00:00
|
|
|
'
|
2009-02-09 05:40:42 +00:00
|
|
|
|
2014-07-16 19:23:49 +00:00
|
|
|
test_expect_success 'cherry-picked commits and fork-point work together' '
|
|
|
|
git checkout default-base &&
|
|
|
|
echo Amended >A &&
|
|
|
|
git commit -a --no-edit --amend &&
|
|
|
|
test_commit B B &&
|
|
|
|
test_commit new_B B "New B" &&
|
|
|
|
test_commit C C &&
|
|
|
|
git checkout default &&
|
|
|
|
git reset --hard default-base@{4} &&
|
|
|
|
test_commit D D &&
|
|
|
|
git cherry-pick -2 default-base^ &&
|
|
|
|
test_commit final_B B "Final B" &&
|
|
|
|
git rebase &&
|
|
|
|
echo Amended >expect &&
|
2018-10-05 21:54:04 +00:00
|
|
|
test_cmp expect A &&
|
2014-07-16 19:23:49 +00:00
|
|
|
echo "Final B" >expect &&
|
2018-10-05 21:54:04 +00:00
|
|
|
test_cmp expect B &&
|
2014-07-16 19:23:49 +00:00
|
|
|
echo C >expect &&
|
2018-10-05 21:54:04 +00:00
|
|
|
test_cmp expect C &&
|
2014-07-16 19:23:49 +00:00
|
|
|
echo D >expect &&
|
2018-10-05 21:54:04 +00:00
|
|
|
test_cmp expect D
|
2014-07-16 19:23:49 +00:00
|
|
|
'
|
|
|
|
|
2020-02-15 21:36:41 +00:00
|
|
|
test_expect_success 'rebase --apply -q is quiet' '
|
2010-07-23 17:05:24 +00:00
|
|
|
git checkout -b quiet topic &&
|
2020-02-15 21:36:41 +00:00
|
|
|
git rebase --apply -q master >output.out 2>&1 &&
|
2013-06-09 18:29:20 +00:00
|
|
|
test_must_be_empty output.out
|
2009-06-16 22:33:01 +00:00
|
|
|
'
|
|
|
|
|
2020-02-15 21:36:28 +00:00
|
|
|
test_expect_success 'rebase --merge -q is quiet' '
|
|
|
|
git checkout -B quiet topic &&
|
|
|
|
git rebase --merge -q master >output.out 2>&1 &&
|
|
|
|
test_must_be_empty output.out
|
|
|
|
'
|
|
|
|
|
2009-08-05 03:31:59 +00:00
|
|
|
test_expect_success 'Rebase a commit that sprinkles CRs in' '
|
|
|
|
(
|
2018-07-02 00:23:58 +00:00
|
|
|
echo "One" &&
|
|
|
|
echo "TwoQ" &&
|
|
|
|
echo "Three" &&
|
|
|
|
echo "FQur" &&
|
2009-08-05 03:31:59 +00:00
|
|
|
echo "Five"
|
|
|
|
) | q_to_cr >CR &&
|
|
|
|
git add CR &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -a -m "A file with a line with CR" &&
|
|
|
|
git tag file-with-cr &&
|
|
|
|
git checkout HEAD^0 &&
|
|
|
|
git rebase --onto HEAD^^ HEAD^ &&
|
|
|
|
git diff --exit-code file-with-cr:CR HEAD:CR
|
|
|
|
'
|
|
|
|
|
2010-03-12 17:04:33 +00:00
|
|
|
test_expect_success 'rebase can copy notes' '
|
|
|
|
git config notes.rewrite.rebase true &&
|
|
|
|
git config notes.rewriteRef "refs/notes/*" &&
|
|
|
|
test_commit n1 &&
|
|
|
|
test_commit n2 &&
|
|
|
|
test_commit n3 &&
|
|
|
|
git notes add -m"a note" n3 &&
|
|
|
|
git rebase --onto n1 n2 &&
|
|
|
|
test "a note" = "$(git notes show HEAD)"
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'rebase -m can copy notes' '
|
|
|
|
git reset --hard n3 &&
|
|
|
|
git rebase -m --onto n1 n2 &&
|
|
|
|
test "a note" = "$(git notes show HEAD)"
|
|
|
|
'
|
|
|
|
|
2012-02-02 21:41:43 +00:00
|
|
|
test_expect_success 'rebase commit with an ancient timestamp' '
|
|
|
|
git reset --hard &&
|
|
|
|
|
|
|
|
>old.one && git add old.one && test_tick &&
|
|
|
|
git commit --date="@12345 +0400" -m "Old one" &&
|
|
|
|
>old.two && git add old.two && test_tick &&
|
|
|
|
git commit --date="@23456 +0500" -m "Old two" &&
|
|
|
|
>old.three && git add old.three && test_tick &&
|
|
|
|
git commit --date="@34567 +0600" -m "Old three" &&
|
|
|
|
|
|
|
|
git cat-file commit HEAD^^ >actual &&
|
|
|
|
grep "author .* 12345 +0400$" actual &&
|
|
|
|
git cat-file commit HEAD^ >actual &&
|
|
|
|
grep "author .* 23456 +0500$" actual &&
|
|
|
|
git cat-file commit HEAD >actual &&
|
|
|
|
grep "author .* 34567 +0600$" actual &&
|
|
|
|
|
|
|
|
git rebase --onto HEAD^^ HEAD^ &&
|
|
|
|
|
|
|
|
git cat-file commit HEAD >actual &&
|
|
|
|
grep "author .* 34567 +0600$" actual
|
|
|
|
'
|
|
|
|
|
2017-11-18 01:01:16 +00:00
|
|
|
test_expect_success 'rebase with "From " line in commit message' '
|
|
|
|
git checkout -b preserve-from master~1 &&
|
|
|
|
cat >From_.msg <<EOF &&
|
|
|
|
Somebody embedded an mbox in a commit message
|
|
|
|
|
|
|
|
This is from so-and-so:
|
|
|
|
|
|
|
|
From a@b Mon Sep 17 00:00:00 2001
|
|
|
|
From: John Doe <nobody@example.com>
|
|
|
|
Date: Sat, 11 Nov 2017 00:00:00 +0000
|
|
|
|
Subject: not this message
|
|
|
|
|
|
|
|
something
|
|
|
|
EOF
|
|
|
|
>From_ &&
|
|
|
|
git add From_ &&
|
|
|
|
git commit -F From_.msg &&
|
|
|
|
git rebase master &&
|
|
|
|
git log -1 --pretty=format:%B >out &&
|
|
|
|
test_cmp From_.msg out
|
|
|
|
'
|
|
|
|
|
2020-02-15 21:36:41 +00:00
|
|
|
test_expect_success 'rebase --apply and --show-current-patch' '
|
2018-02-11 09:43:27 +00:00
|
|
|
test_create_repo conflict-apply &&
|
|
|
|
(
|
|
|
|
cd conflict-apply &&
|
|
|
|
test_commit init &&
|
|
|
|
echo one >>init.t &&
|
|
|
|
git commit -a -m one &&
|
|
|
|
echo two >>init.t &&
|
|
|
|
git commit -a -m two &&
|
|
|
|
git tag two &&
|
2020-02-15 21:36:41 +00:00
|
|
|
test_must_fail git rebase --apply -f --onto init HEAD^ &&
|
2018-02-11 09:43:27 +00:00
|
|
|
GIT_TRACE=1 git rebase --show-current-patch >/dev/null 2>stderr &&
|
|
|
|
grep "show.*$(git rev-parse two)" stderr
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2020-02-15 21:36:41 +00:00
|
|
|
test_expect_success 'rebase --apply and .gitattributes' '
|
2019-09-02 22:39:44 +00:00
|
|
|
test_create_repo attributes &&
|
|
|
|
(
|
|
|
|
cd attributes &&
|
|
|
|
test_commit init &&
|
|
|
|
git config filter.test.clean "sed -e '\''s/smudged/clean/g'\''" &&
|
|
|
|
git config filter.test.smudge "sed -e '\''s/clean/smudged/g'\''" &&
|
|
|
|
|
|
|
|
test_commit second &&
|
|
|
|
git checkout -b test HEAD^ &&
|
|
|
|
|
|
|
|
echo "*.txt filter=test" >.gitattributes &&
|
|
|
|
git add .gitattributes &&
|
|
|
|
test_commit third &&
|
|
|
|
|
|
|
|
echo "This text is smudged." >a.txt &&
|
|
|
|
git add a.txt &&
|
|
|
|
test_commit fourth &&
|
|
|
|
|
|
|
|
git checkout -b removal HEAD^ &&
|
|
|
|
git rm .gitattributes &&
|
|
|
|
git add -u &&
|
|
|
|
test_commit fifth &&
|
|
|
|
git cherry-pick test &&
|
|
|
|
|
|
|
|
git checkout test &&
|
|
|
|
git rebase master &&
|
|
|
|
grep "smudged" a.txt &&
|
|
|
|
|
|
|
|
git checkout removal &&
|
|
|
|
git reset --hard &&
|
|
|
|
git rebase master &&
|
|
|
|
grep "clean" a.txt
|
|
|
|
)
|
|
|
|
'
|
|
|
|
|
2018-02-11 09:43:27 +00:00
|
|
|
test_expect_success 'rebase--merge.sh and --show-current-patch' '
|
|
|
|
test_create_repo conflict-merge &&
|
|
|
|
(
|
|
|
|
cd conflict-merge &&
|
|
|
|
test_commit init &&
|
|
|
|
echo one >>init.t &&
|
|
|
|
git commit -a -m one &&
|
|
|
|
echo two >>init.t &&
|
|
|
|
git commit -a -m two &&
|
|
|
|
git tag two &&
|
|
|
|
test_must_fail git rebase --merge --onto init HEAD^ &&
|
|
|
|
git rebase --show-current-patch >actual.patch &&
|
|
|
|
GIT_TRACE=1 git rebase --show-current-patch >/dev/null 2>stderr &&
|
2018-02-11 09:43:28 +00:00
|
|
|
grep "show.*REBASE_HEAD" stderr &&
|
|
|
|
test "$(git rev-parse REBASE_HEAD)" = "$(git rev-parse two)"
|
2018-02-11 09:43:27 +00:00
|
|
|
)
|
|
|
|
'
|
|
|
|
|
rebase: remove the rebase.useBuiltin setting
Remove the rebase.useBuiltin setting, which was added as an escape
hatch to disable the builtin version of rebase first released with Git
2.20.
See [1] for the initial implementation of rebase.useBuiltin, and [2]
and [3] for the documentation and corresponding
GIT_TEST_REBASE_USE_BUILTIN option.
Carrying the legacy version is a maintenance burden as seen in
7e097e27d3 ("legacy-rebase: backport -C<n> and --whitespace=<option>
checks", 2018-11-20) and 9aea5e9286 ("rebase: fix regression in
rebase.useBuiltin=false test mode", 2019-02-13). Since the built-in
version has been shown to be stable enough let's remove the legacy
version.
As noted in [3] having use_builtin_rebase() shell out to get its
config doesn't make any sense anymore, that was done for the purposes
of spawning the legacy rebase without having modified any global
state. Let's instead handle this case in rebase_config().
There's still a bunch of references to git-legacy-rebase in po/*.po,
but those will be dealt with in time by the i18n effort.
Even though this configuration variable only existed two releases
let's not entirely delete the entry from the docs, but note its
absence. Individual versions of git tend to be around for a while due
to distro packaging timelines, so e.g. if we're "lucky" a given
version like 2.21 might be installed on say OSX for half a decade.
That'll mean some people probably setting this in config, and then
when they later wonder if it's needed they can Google search the
config option name or check it in git-config. It also allows us to
refer to the docs from the warning for details.
1. 55071ea248 ("rebase: start implementing it as a builtin",
2018-08-07)
2. d8d0a546f0 ("rebase doc: document rebase.useBuiltin", 2018-11-14)
3. 62c23938fa ("tests: add a special setup where rebase.useBuiltin is
off", 2018-11-14)
3. https://public-inbox.org/git/nycvar.QRO.7.76.6.1903141544110.41@tvgsbejvaqbjf.bet/
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-03-18 11:01:52 +00:00
|
|
|
test_expect_success 'rebase -c rebase.useBuiltin=false warning' '
|
|
|
|
expected="rebase.useBuiltin support has been removed" &&
|
|
|
|
|
|
|
|
# Only warn when the legacy rebase is requested...
|
|
|
|
test_must_fail git -c rebase.useBuiltin=false rebase 2>err &&
|
|
|
|
test_i18ngrep "$expected" err &&
|
|
|
|
test_must_fail env GIT_TEST_REBASE_USE_BUILTIN=false git rebase 2>err &&
|
|
|
|
test_i18ngrep "$expected" err &&
|
|
|
|
|
|
|
|
# ...not when we would have used the built-in anyway
|
|
|
|
test_must_fail git -c rebase.useBuiltin=true rebase 2>err &&
|
|
|
|
test_must_be_empty err &&
|
|
|
|
test_must_fail env GIT_TEST_REBASE_USE_BUILTIN=true git rebase 2>err &&
|
|
|
|
test_must_be_empty err
|
|
|
|
'
|
|
|
|
|
2020-02-23 10:14:07 +00:00
|
|
|
test_expect_success 'switch to branch checked out here' '
|
|
|
|
git checkout master &&
|
|
|
|
git rebase master master
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'switch to branch not checked out' '
|
|
|
|
git checkout master &&
|
|
|
|
git branch other &&
|
|
|
|
git rebase master other
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'refuse to switch to branch checked out elsewhere' '
|
|
|
|
git checkout master &&
|
|
|
|
git worktree add wt &&
|
|
|
|
test_must_fail git -C wt rebase master master 2>err &&
|
|
|
|
test_i18ngrep "already checked out" err
|
|
|
|
'
|
|
|
|
|
2005-12-14 22:48:19 +00:00
|
|
|
test_done
|