2022-04-13 15:32:29 +00:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
test_description='verify safe.directory checks'
|
|
|
|
|
leak tests: mark passing SANITIZE=leak tests as leak-free
Mark those remaining tests that pass when run under SANITIZE=leak with
TEST_PASSES_SANITIZE_LEAK=true, these were either omitted in
f346fcb62a0 (Merge branch 'ab/mark-leak-free-tests-even-more',
2021-12-15) and 5a4f8381b68 (Merge branch 'ab/mark-leak-free-tests',
2021-10-25), or have had their memory leaks fixed since then.
With this change there's now a a one-to-one mapping between those
tests that we have opted-in via "TEST_PASSES_SANITIZE_LEAK=true", and
those that pass with the new "check" mode:
GIT_TEST_PASSING_SANITIZE_LEAK=check \
GIT_TEST_SANITIZE_LEAK_LOG=true \
make test SANITIZE=leak
Note that the "GIT_TEST_SANITIZE_LEAK_LOG=true" is needed due to the
edge cases noted in a preceding commit, i.e. in some cases we'd pass
the test itself, but still have outstanding leaks due to ignored exit
codes.
The "GIT_TEST_SANITIZE_LEAK_LOG=true" corrects for that, we're only
marking those tests as passing that really don't have any leaks,
whether that was reflected in their exit code or not.
Note that the change here to "t9100-git-svn-basic.sh" is marking that
test as passing under SANITIZE=leak, we're removing a
"TEST_FAILS_SANITIZE_LEAK=true" line, not
"TEST_PASSES_SANITIZE_LEAK=true". See 7a98d9ab00d (revisions API: have
release_revisions() release "cmdline", 2022-04-13) for the
introduction of that t/lib-git-svn.sh-specific variable.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2022-07-27 23:13:41 +00:00
|
|
|
TEST_PASSES_SANITIZE_LEAK=true
|
2022-04-13 15:32:29 +00:00
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
GIT_TEST_ASSUME_DIFFERENT_OWNER=1
|
|
|
|
export GIT_TEST_ASSUME_DIFFERENT_OWNER
|
|
|
|
|
|
|
|
expect_rejected_dir () {
|
|
|
|
test_must_fail git status 2>err &&
|
2022-06-27 19:36:11 +00:00
|
|
|
grep "dubious ownership" err
|
2022-04-13 15:32:29 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
test_expect_success 'safe.directory is not set' '
|
|
|
|
expect_rejected_dir
|
|
|
|
'
|
|
|
|
|
2022-07-14 21:28:00 +00:00
|
|
|
test_expect_success 'safe.directory on the command line' '
|
|
|
|
git -c safe.directory="$(pwd)" status
|
2022-04-27 17:06:48 +00:00
|
|
|
'
|
|
|
|
|
2022-07-14 21:28:00 +00:00
|
|
|
test_expect_success 'safe.directory in the environment' '
|
|
|
|
env GIT_CONFIG_COUNT=1 \
|
|
|
|
GIT_CONFIG_KEY_0="safe.directory" \
|
|
|
|
GIT_CONFIG_VALUE_0="$(pwd)" \
|
|
|
|
git status
|
2022-04-27 17:06:49 +00:00
|
|
|
'
|
|
|
|
|
2022-07-14 21:28:00 +00:00
|
|
|
test_expect_success 'safe.directory in GIT_CONFIG_PARAMETERS' '
|
|
|
|
env GIT_CONFIG_PARAMETERS="${SQ}safe.directory${SQ}=${SQ}$(pwd)${SQ}" \
|
|
|
|
git status
|
2022-04-27 17:06:49 +00:00
|
|
|
'
|
|
|
|
|
2022-04-27 17:06:48 +00:00
|
|
|
test_expect_success 'ignoring safe.directory in repo config' '
|
|
|
|
(
|
|
|
|
unset GIT_TEST_ASSUME_DIFFERENT_OWNER &&
|
|
|
|
git config safe.directory "$(pwd)"
|
|
|
|
) &&
|
|
|
|
expect_rejected_dir
|
|
|
|
'
|
|
|
|
|
2022-04-13 15:32:29 +00:00
|
|
|
test_expect_success 'safe.directory does not match' '
|
|
|
|
git config --global safe.directory bogus &&
|
|
|
|
expect_rejected_dir
|
|
|
|
'
|
|
|
|
|
2022-04-13 15:32:30 +00:00
|
|
|
test_expect_success 'path exist as different key' '
|
|
|
|
git config --global foo.bar "$(pwd)" &&
|
|
|
|
expect_rejected_dir
|
|
|
|
'
|
|
|
|
|
2022-04-13 15:32:29 +00:00
|
|
|
test_expect_success 'safe.directory matches' '
|
|
|
|
git config --global --add safe.directory "$(pwd)" &&
|
|
|
|
git status
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'safe.directory matches, but is reset' '
|
|
|
|
git config --global --add safe.directory "" &&
|
|
|
|
expect_rejected_dir
|
|
|
|
'
|
|
|
|
|
2022-04-13 15:32:31 +00:00
|
|
|
test_expect_success 'safe.directory=*' '
|
|
|
|
git config --global --add safe.directory "*" &&
|
|
|
|
git status
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'safe.directory=*, but is reset' '
|
|
|
|
git config --global --add safe.directory "" &&
|
|
|
|
expect_rejected_dir
|
|
|
|
'
|
|
|
|
|
2022-04-13 15:32:29 +00:00
|
|
|
test_done
|