2008-07-25 16:28:41 +00:00
|
|
|
#include "cache.h"
|
|
|
|
#include "strbuf.h"
|
|
|
|
#include "run-command.h"
|
|
|
|
|
2008-07-25 16:28:42 +00:00
|
|
|
int launch_editor(const char *path, struct strbuf *buffer, const char *const *env)
|
2008-07-25 16:28:41 +00:00
|
|
|
{
|
Do not use VISUAL editor on dumb terminals
Refuse to use $VISUAL and fall back to $EDITOR if TERM is unset
or set to "dumb". Traditionally, VISUAL is set to a screen
editor and EDITOR to a line-based editor, which should be more
useful in that situation.
vim, for example, is happy to assume a terminal supports ANSI
sequences even if TERM is dumb (e.g., when running from a text
editor like Acme). git already refuses to fall back to vi on a
dumb terminal if GIT_EDITOR, core.editor, VISUAL, and EDITOR are
unset, but without this patch, that check is suppressed by
VISUAL=vi.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-11-11 23:56:07 +00:00
|
|
|
const char *editor = getenv("GIT_EDITOR");
|
|
|
|
const char *terminal = getenv("TERM");
|
|
|
|
int terminal_is_dumb = !terminal || !strcmp(terminal, "dumb");
|
2008-07-25 16:28:41 +00:00
|
|
|
|
|
|
|
if (!editor && editor_program)
|
|
|
|
editor = editor_program;
|
Do not use VISUAL editor on dumb terminals
Refuse to use $VISUAL and fall back to $EDITOR if TERM is unset
or set to "dumb". Traditionally, VISUAL is set to a screen
editor and EDITOR to a line-based editor, which should be more
useful in that situation.
vim, for example, is happy to assume a terminal supports ANSI
sequences even if TERM is dumb (e.g., when running from a text
editor like Acme). git already refuses to fall back to vi on a
dumb terminal if GIT_EDITOR, core.editor, VISUAL, and EDITOR are
unset, but without this patch, that check is suppressed by
VISUAL=vi.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-11-11 23:56:07 +00:00
|
|
|
if (!editor && !terminal_is_dumb)
|
2008-07-25 16:28:41 +00:00
|
|
|
editor = getenv("VISUAL");
|
|
|
|
if (!editor)
|
|
|
|
editor = getenv("EDITOR");
|
|
|
|
|
Do not use VISUAL editor on dumb terminals
Refuse to use $VISUAL and fall back to $EDITOR if TERM is unset
or set to "dumb". Traditionally, VISUAL is set to a screen
editor and EDITOR to a line-based editor, which should be more
useful in that situation.
vim, for example, is happy to assume a terminal supports ANSI
sequences even if TERM is dumb (e.g., when running from a text
editor like Acme). git already refuses to fall back to vi on a
dumb terminal if GIT_EDITOR, core.editor, VISUAL, and EDITOR are
unset, but without this patch, that check is suppressed by
VISUAL=vi.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2009-11-11 23:56:07 +00:00
|
|
|
if (!editor && terminal_is_dumb)
|
|
|
|
return error("terminal is dumb, but EDITOR unset");
|
2008-07-25 16:28:41 +00:00
|
|
|
|
|
|
|
if (!editor)
|
|
|
|
editor = "vi";
|
|
|
|
|
|
|
|
if (strcmp(editor, ":")) {
|
|
|
|
size_t len = strlen(editor);
|
|
|
|
int i = 0;
|
2008-07-25 16:28:42 +00:00
|
|
|
int failed;
|
2008-07-25 16:28:41 +00:00
|
|
|
const char *args[6];
|
2008-10-09 19:12:12 +00:00
|
|
|
struct strbuf arg0 = STRBUF_INIT;
|
2008-07-25 16:28:41 +00:00
|
|
|
|
2009-10-31 01:24:04 +00:00
|
|
|
if (strcspn(editor, "|&;<>()$`\\\"' \t\n*?[#~=%") != len) {
|
2008-07-25 16:28:41 +00:00
|
|
|
/* there are specials */
|
|
|
|
strbuf_addf(&arg0, "%s \"$@\"", editor);
|
|
|
|
args[i++] = "sh";
|
|
|
|
args[i++] = "-c";
|
|
|
|
args[i++] = arg0.buf;
|
|
|
|
}
|
|
|
|
args[i++] = editor;
|
|
|
|
args[i++] = path;
|
|
|
|
args[i] = NULL;
|
|
|
|
|
2008-07-25 16:28:42 +00:00
|
|
|
failed = run_command_v_opt_cd_env(args, 0, NULL, env);
|
2008-07-25 16:28:41 +00:00
|
|
|
strbuf_release(&arg0);
|
2008-07-25 16:28:42 +00:00
|
|
|
if (failed)
|
|
|
|
return error("There was a problem with the editor '%s'.",
|
|
|
|
editor);
|
2008-07-25 16:28:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!buffer)
|
2008-07-25 16:28:42 +00:00
|
|
|
return 0;
|
2008-07-25 16:28:41 +00:00
|
|
|
if (strbuf_read_file(buffer, path, 0) < 0)
|
2008-07-25 16:28:42 +00:00
|
|
|
return error("could not read file '%s': %s",
|
|
|
|
path, strerror(errno));
|
|
|
|
return 0;
|
2008-07-25 16:28:41 +00:00
|
|
|
}
|