git/t/chainlint/multi-line-string.test

(
	x="line 1
		line 2
		line 3" &&
# LINT: missing "&&" on assignment
	y='line 1
		line2'
	foobar
) &&
(
# LINT: apostrophe (in a contraction) within string not misinterpreted as
# LINT: starting multi-line single-quoted string
	echo "there's nothing to see here" &&
	exit
) &&
(
	echo "xyz" "abc
		def
		ghi" &&
	echo 'xyz' 'abc
		def
		ghi' &&
	echo 'xyz' "abc
		def
		ghi" &&
	barfoo
)
t/chainlint: add chainlint "basic" test cases The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2018-07-11 06:46:35 +00:00			`(`
			`x="line 1`
			`line 2`
			`line 3" &&`
			`# LINT: missing "&&" on assignment`
			`y='line 1`
			`line2'`
			`foobar`
			`) &&`
			`(`
			`# LINT: apostrophe (in a contraction) within string not misinterpreted as`
			`# LINT: starting multi-line single-quoted string`
			`echo "there's nothing to see here" &&`
			`exit`
chainlint: recognize multi-line quoted strings more robustly chainlint.sed recognizes multi-line quoted strings within subshells: echo "abc def" >out && so it can avoid incorrectly classifying lines internal to the string as breaking the &&-chain. To identify the first line of a multi-line string, it checks if the line contains a single quote. However, this is fragile and can be easily fooled by a line containing multiple strings: echo "xyz" "abc def" >out && Make detection more robust by checking for an odd number of quotes rather than only a single one. (Escaped quotes are not handled, but support may be added later.) The original multi-line string recognizer rather cavalierly threw away all but the final quote, whereas the new one is careful to retain all quotes, so the "expected" output of a couple existing chainlint tests is updated to account for this new behavior. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2018-08-13 08:47:38 +00:00			`) &&`
			`(`
			`echo "xyz" "abc`
			`def`
			`ghi" &&`
			`echo 'xyz' 'abc`
			`def`
			`ghi' &&`
			`echo 'xyz' "abc`
			`def`
			`ghi" &&`
			`barfoo`
t/chainlint: add chainlint "basic" test cases The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2018-07-11 06:46:35 +00:00			`)`