2006-05-07 18:19:47 +00:00
|
|
|
#!/bin/sh
|
|
|
|
|
#
|
|
|
|
|
# Copyright (C) 2006 Martin Waitz <tali@admingilde.org>
|
|
|
|
|
#
|
|
|
|
|
|
|
|
|
|
test_description='test transitive info/alternate entries'
|
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
2016-01-04 09:10:51 +00:00
|
|
|
base_dir=$(pwd)
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
test_expect_success 'preparing first repository' \
|
|
|
|
|
'test_create_repo A && cd A &&
|
|
|
|
|
echo "Hello World" > file1 &&
|
|
|
|
|
git add file1 &&
|
|
|
|
|
git commit -m "Initial commit" file1 &&
|
|
|
|
|
git repack -a -d &&
|
2007-01-22 05:29:44 +00:00
|
|
|
git prune'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
|
|
|
|
test_expect_success 'preparing second repository' \
|
|
|
|
|
'git clone -l -s A B && cd B &&
|
|
|
|
|
echo "foo bar" > file2 &&
|
|
|
|
|
git add file2 &&
|
|
|
|
|
git commit -m "next commit" file2 &&
|
|
|
|
|
git repack -a -d -l &&
|
2007-01-22 05:29:44 +00:00
|
|
|
git prune'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
|
|
|
|
test_expect_success 'preparing third repository' \
|
|
|
|
|
'git clone -l -s B C && cd C &&
|
|
|
|
|
echo "Goodbye, cruel world" > file3 &&
|
|
|
|
|
git add file3 &&
|
|
|
|
|
git commit -m "one more" file3 &&
|
|
|
|
|
git repack -a -d -l &&
|
2007-01-22 05:29:44 +00:00
|
|
|
git prune'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
2008-01-21 20:53:25 +00:00
|
|
|
test_expect_success 'creating too deep nesting' \
|
2006-05-07 18:19:47 +00:00
|
|
|
'git clone -l -s C D &&
|
|
|
|
|
git clone -l -s D E &&
|
|
|
|
|
git clone -l -s E F &&
|
|
|
|
|
git clone -l -s F G &&
|
clone: drop connectivity check for local clones
Commit 0433ad1 (clone: run check_everything_connected,
2013-03-25) added the same connectivity check to clone that
we use for fetching. The intent was to provide enough safety
checks that "git clone git://..." could be counted on to
detect bit errors and other repo corruption, and not
silently propagate them to the clone.
For local clones, this turns out to be a bad idea, for two
reasons:
1. Local clones use hard linking (or even shared object
stores), and so complete far more quickly. The time
spent on the connectivity check is therefore
proportionally much more painful.
2. Local clones do not actually meet our safety guarantee
anyway. The connectivity check makes sure we have all
of the objects we claim to, but it does not check for
bit errors. We will notice bit errors in commits and
trees, but we do not load blob objects at all. Whereas
over the pack transport, we actually recompute the sha1
of each object in the incoming packfile; bit errors
change the sha1 of the object, which is then caught by
the connectivity check.
This patch drops the connectivity check in the local case.
Note that we have to revert the changes from 0433ad1 to
t5710, as we no longer notice the corruption during clone.
We could go a step further and provide a "verify even local
clones" option, but it is probably not worthwhile. You can
already spell that as "cd foo.git && git fsck && git clone ."
or as "git clone --no-local foo.git".
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-07-08 07:30:41 +00:00
|
|
|
git clone --bare -l -s G H'
|
|
|
|
|
|
|
|
|
|
test_expect_success 'invalidity of deepest repository' \
|
|
|
|
|
'cd H && {
|
2016-10-03 20:33:58 +00:00
|
|
|
git fsck
|
clone: drop connectivity check for local clones
Commit 0433ad1 (clone: run check_everything_connected,
2013-03-25) added the same connectivity check to clone that
we use for fetching. The intent was to provide enough safety
checks that "git clone git://..." could be counted on to
detect bit errors and other repo corruption, and not
silently propagate them to the clone.
For local clones, this turns out to be a bad idea, for two
reasons:
1. Local clones use hard linking (or even shared object
stores), and so complete far more quickly. The time
spent on the connectivity check is therefore
proportionally much more painful.
2. Local clones do not actually meet our safety guarantee
anyway. The connectivity check makes sure we have all
of the objects we claim to, but it does not check for
bit errors. We will notice bit errors in commits and
trees, but we do not load blob objects at all. Whereas
over the pack transport, we actually recompute the sha1
of each object in the incoming packfile; bit errors
change the sha1 of the object, which is then caught by
the connectivity check.
This patch drops the connectivity check in the local case.
Note that we have to revert the changes from 0433ad1 to
t5710, as we no longer notice the corruption during clone.
We could go a step further and provide a "verify even local
clones" option, but it is probably not worthwhile. You can
already spell that as "cd foo.git && git fsck && git clone ."
or as "git clone --no-local foo.git".
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-07-08 07:30:41 +00:00
|
|
|
test $? -ne 0
|
|
|
|
|
}'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
|
|
|
|
test_expect_success 'validity of third repository' \
|
|
|
|
|
'cd C &&
|
2016-10-03 20:33:58 +00:00
|
|
|
git fsck'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
|
|
|
|
test_expect_success 'validity of fourth repository' \
|
|
|
|
|
'cd D &&
|
2016-10-03 20:33:58 +00:00
|
|
|
git fsck'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
|
|
|
|
test_expect_success 'breaking of loops' \
|
2008-05-04 05:37:59 +00:00
|
|
|
'echo "$base_dir"/B/.git/objects >> "$base_dir"/A/.git/objects/info/alternates&&
|
2006-05-07 18:19:47 +00:00
|
|
|
cd C &&
|
2016-10-03 20:33:58 +00:00
|
|
|
git fsck'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
2008-02-01 09:50:53 +00:00
|
|
|
test_expect_success 'that info/alternates is necessary' \
|
2006-05-07 18:19:47 +00:00
|
|
|
'cd C &&
|
2008-02-01 09:50:53 +00:00
|
|
|
rm -f .git/objects/info/alternates &&
|
2016-10-03 20:33:58 +00:00
|
|
|
! (git fsck)'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
|
|
|
|
test_expect_success 'that relative alternate is possible for current dir' \
|
|
|
|
|
'cd C &&
|
|
|
|
|
echo "../../../B/.git/objects" > .git/objects/info/alternates &&
|
2016-10-03 20:33:58 +00:00
|
|
|
git fsck'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
2008-02-01 09:50:53 +00:00
|
|
|
test_expect_success \
|
|
|
|
|
'that relative alternate is only possible for current dir' '
|
|
|
|
|
cd D &&
|
2016-10-03 20:33:58 +00:00
|
|
|
! (git fsck)
|
2008-02-01 09:50:53 +00:00
|
|
|
'
|
2006-05-07 18:19:47 +00:00
|
|
|
|
|
|
|
|
cd "$base_dir"
|
|
|
|
|
|
|
|
|
|
test_done
|
