2007-12-02 14:14:13 +00:00
|
|
|
/*
|
|
|
|
* "git fast-export" builtin command
|
|
|
|
*
|
|
|
|
* Copyright (C) 2007 Johannes E. Schindelin
|
|
|
|
*/
|
|
|
|
#include "builtin.h"
|
|
|
|
#include "cache.h"
|
2017-06-14 18:07:36 +00:00
|
|
|
#include "config.h"
|
2015-06-22 14:03:05 +00:00
|
|
|
#include "refs.h"
|
2007-12-02 14:14:13 +00:00
|
|
|
#include "commit.h"
|
|
|
|
#include "object.h"
|
|
|
|
#include "tag.h"
|
|
|
|
#include "diff.h"
|
|
|
|
#include "diffcore.h"
|
|
|
|
#include "log-tree.h"
|
|
|
|
#include "revision.h"
|
|
|
|
#include "decorate.h"
|
2008-07-21 18:03:49 +00:00
|
|
|
#include "string-list.h"
|
2007-12-02 14:14:13 +00:00
|
|
|
#include "utf8.h"
|
|
|
|
#include "parse-options.h"
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
#include "quote.h"
|
2014-04-20 18:59:24 +00:00
|
|
|
#include "remote.h"
|
2014-08-27 17:01:28 +00:00
|
|
|
#include "blob.h"
|
2007-12-02 14:14:13 +00:00
|
|
|
|
|
|
|
static const char *fast_export_usage[] = {
|
2012-08-20 12:32:08 +00:00
|
|
|
N_("git fast-export [rev-list-opts]"),
|
2007-12-02 14:14:13 +00:00
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
static int progress;
|
2013-04-14 10:57:06 +00:00
|
|
|
static enum { ABORT, VERBATIM, WARN, WARN_STRIP, STRIP } signed_tag_mode = ABORT;
|
2011-12-21 01:18:19 +00:00
|
|
|
static enum { ERROR, DROP, REWRITE } tag_of_filtered_mode = ERROR;
|
2008-12-20 00:00:27 +00:00
|
|
|
static int fake_missing_tagger;
|
2011-07-16 13:03:33 +00:00
|
|
|
static int use_done_feature;
|
2009-07-28 02:20:22 +00:00
|
|
|
static int no_data;
|
2010-07-17 17:00:51 +00:00
|
|
|
static int full_tree;
|
2013-09-01 07:05:47 +00:00
|
|
|
static struct string_list extra_refs = STRING_LIST_INIT_NODUP;
|
2014-04-20 18:59:24 +00:00
|
|
|
static struct refspec *refspecs;
|
|
|
|
static int refspecs_nr;
|
2014-08-27 17:01:28 +00:00
|
|
|
static int anonymize;
|
2007-12-02 14:14:13 +00:00
|
|
|
|
|
|
|
static int parse_opt_signed_tag_mode(const struct option *opt,
|
|
|
|
const char *arg, int unset)
|
|
|
|
{
|
|
|
|
if (unset || !strcmp(arg, "abort"))
|
|
|
|
signed_tag_mode = ABORT;
|
2007-12-03 22:44:39 +00:00
|
|
|
else if (!strcmp(arg, "verbatim") || !strcmp(arg, "ignore"))
|
|
|
|
signed_tag_mode = VERBATIM;
|
2007-12-02 14:14:13 +00:00
|
|
|
else if (!strcmp(arg, "warn"))
|
|
|
|
signed_tag_mode = WARN;
|
2013-04-14 10:57:06 +00:00
|
|
|
else if (!strcmp(arg, "warn-strip"))
|
|
|
|
signed_tag_mode = WARN_STRIP;
|
2007-12-02 14:14:13 +00:00
|
|
|
else if (!strcmp(arg, "strip"))
|
|
|
|
signed_tag_mode = STRIP;
|
|
|
|
else
|
2013-04-12 14:05:55 +00:00
|
|
|
return error("Unknown signed-tags mode: %s", arg);
|
2007-12-02 14:14:13 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-06-26 04:48:31 +00:00
|
|
|
static int parse_opt_tag_of_filtered_mode(const struct option *opt,
|
|
|
|
const char *arg, int unset)
|
|
|
|
{
|
|
|
|
if (unset || !strcmp(arg, "abort"))
|
2011-12-21 01:18:19 +00:00
|
|
|
tag_of_filtered_mode = ERROR;
|
2009-06-26 04:48:31 +00:00
|
|
|
else if (!strcmp(arg, "drop"))
|
|
|
|
tag_of_filtered_mode = DROP;
|
|
|
|
else if (!strcmp(arg, "rewrite"))
|
|
|
|
tag_of_filtered_mode = REWRITE;
|
|
|
|
else
|
|
|
|
return error("Unknown tag-of-filtered mode: %s", arg);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-12-02 14:14:13 +00:00
|
|
|
static struct decoration idnums;
|
|
|
|
static uint32_t last_idnum;
|
|
|
|
|
|
|
|
static int has_unshown_parent(struct commit *commit)
|
|
|
|
{
|
|
|
|
struct commit_list *parent;
|
|
|
|
|
|
|
|
for (parent = commit->parents; parent; parent = parent->next)
|
|
|
|
if (!(parent->item->object.flags & SHOWN) &&
|
|
|
|
!(parent->item->object.flags & UNINTERESTING))
|
|
|
|
return 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
struct anonymized_entry {
|
|
|
|
struct hashmap_entry hash;
|
|
|
|
const char *orig;
|
|
|
|
size_t orig_len;
|
|
|
|
const char *anon;
|
|
|
|
size_t anon_len;
|
|
|
|
};
|
|
|
|
|
2017-06-30 19:14:05 +00:00
|
|
|
static int anonymized_entry_cmp(const void *unused_cmp_data,
|
|
|
|
const void *va, const void *vb,
|
|
|
|
const void *unused_keydata)
|
2014-08-27 17:01:28 +00:00
|
|
|
{
|
|
|
|
const struct anonymized_entry *a = va, *b = vb;
|
|
|
|
return a->orig_len != b->orig_len ||
|
|
|
|
memcmp(a->orig, b->orig, a->orig_len);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Basically keep a cache of X->Y so that we can repeatedly replace
|
|
|
|
* the same anonymized string with another. The actual generation
|
|
|
|
* is farmed out to the generate function.
|
|
|
|
*/
|
|
|
|
static const void *anonymize_mem(struct hashmap *map,
|
|
|
|
void *(*generate)(const void *, size_t *),
|
|
|
|
const void *orig, size_t *len)
|
|
|
|
{
|
|
|
|
struct anonymized_entry key, *ret;
|
|
|
|
|
|
|
|
if (!map->cmpfn)
|
2017-06-30 19:14:05 +00:00
|
|
|
hashmap_init(map, anonymized_entry_cmp, NULL, 0);
|
2014-08-27 17:01:28 +00:00
|
|
|
|
|
|
|
hashmap_entry_init(&key, memhash(orig, *len));
|
|
|
|
key.orig = orig;
|
|
|
|
key.orig_len = *len;
|
|
|
|
ret = hashmap_get(map, &key, NULL);
|
|
|
|
|
|
|
|
if (!ret) {
|
|
|
|
ret = xmalloc(sizeof(*ret));
|
|
|
|
hashmap_entry_init(&ret->hash, key.hash.hash);
|
|
|
|
ret->orig = xstrdup(orig);
|
|
|
|
ret->orig_len = *len;
|
|
|
|
ret->anon = generate(orig, len);
|
|
|
|
ret->anon_len = *len;
|
|
|
|
hashmap_put(map, ret);
|
|
|
|
}
|
|
|
|
|
|
|
|
*len = ret->anon_len;
|
|
|
|
return ret->anon;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We anonymize each component of a path individually,
|
|
|
|
* so that paths a/b and a/c will share a common root.
|
|
|
|
* The paths are cached via anonymize_mem so that repeated
|
|
|
|
* lookups for "a" will yield the same value.
|
|
|
|
*/
|
|
|
|
static void anonymize_path(struct strbuf *out, const char *path,
|
|
|
|
struct hashmap *map,
|
|
|
|
void *(*generate)(const void *, size_t *))
|
|
|
|
{
|
|
|
|
while (*path) {
|
|
|
|
const char *end_of_component = strchrnul(path, '/');
|
|
|
|
size_t len = end_of_component - path;
|
|
|
|
const char *c = anonymize_mem(map, generate, path, &len);
|
|
|
|
strbuf_add(out, c, len);
|
|
|
|
path = end_of_component;
|
|
|
|
if (*path)
|
|
|
|
strbuf_addch(out, *path++);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-12-02 14:14:13 +00:00
|
|
|
/* Since intptr_t is C99, we do not use it here */
|
2008-06-11 11:17:04 +00:00
|
|
|
static inline uint32_t *mark_to_ptr(uint32_t mark)
|
2007-12-02 14:14:13 +00:00
|
|
|
{
|
2008-06-11 11:17:04 +00:00
|
|
|
return ((uint32_t *)NULL) + mark;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline uint32_t ptr_to_mark(void * mark)
|
|
|
|
{
|
|
|
|
return (uint32_t *)mark - (uint32_t *)NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void mark_object(struct object *object, uint32_t mark)
|
|
|
|
{
|
|
|
|
add_decoration(&idnums, object, mark_to_ptr(mark));
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void mark_next_object(struct object *object)
|
|
|
|
{
|
|
|
|
mark_object(object, ++last_idnum);
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int get_object_mark(struct object *object)
|
|
|
|
{
|
|
|
|
void *decoration = lookup_decoration(&idnums, object);
|
|
|
|
if (!decoration)
|
|
|
|
return 0;
|
2008-06-11 11:17:04 +00:00
|
|
|
return ptr_to_mark(decoration);
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void show_progress(void)
|
|
|
|
{
|
|
|
|
static int counter = 0;
|
|
|
|
if (!progress)
|
|
|
|
return;
|
|
|
|
if ((++counter % progress) == 0)
|
|
|
|
printf("progress %d objects\n", counter);
|
|
|
|
}
|
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
/*
|
|
|
|
* Ideally we would want some transformation of the blob data here
|
|
|
|
* that is unreversible, but would still be the same size and have
|
|
|
|
* the same data relationship to other blobs (so that we get the same
|
|
|
|
* delta and packing behavior as the original). But the first and last
|
|
|
|
* requirements there are probably mutually exclusive, so let's take
|
|
|
|
* the easy way out for now, and just generate arbitrary content.
|
|
|
|
*
|
|
|
|
* There's no need to cache this result with anonymize_mem, since
|
|
|
|
* we already handle blob content caching with marks.
|
|
|
|
*/
|
|
|
|
static char *anonymize_blob(unsigned long *size)
|
|
|
|
{
|
|
|
|
static int counter;
|
|
|
|
struct strbuf out = STRBUF_INIT;
|
|
|
|
strbuf_addf(&out, "anonymous blob %d", counter++);
|
|
|
|
*size = out.len;
|
|
|
|
return strbuf_detach(&out, NULL);
|
|
|
|
}
|
|
|
|
|
2017-02-21 23:47:23 +00:00
|
|
|
static void export_blob(const struct object_id *oid)
|
2007-12-02 14:14:13 +00:00
|
|
|
{
|
|
|
|
unsigned long size;
|
|
|
|
enum object_type type;
|
|
|
|
char *buf;
|
|
|
|
struct object *object;
|
2013-03-17 08:38:57 +00:00
|
|
|
int eaten;
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2009-07-28 02:20:22 +00:00
|
|
|
if (no_data)
|
|
|
|
return;
|
|
|
|
|
2017-02-21 23:47:23 +00:00
|
|
|
if (is_null_oid(oid))
|
2007-12-02 14:14:13 +00:00
|
|
|
return;
|
|
|
|
|
2017-02-21 23:47:23 +00:00
|
|
|
object = lookup_object(oid->hash);
|
2013-03-17 08:38:57 +00:00
|
|
|
if (object && object->flags & SHOWN)
|
2007-12-02 14:14:13 +00:00
|
|
|
return;
|
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
if (anonymize) {
|
|
|
|
buf = anonymize_blob(&size);
|
2017-05-06 22:10:14 +00:00
|
|
|
object = (struct object *)lookup_blob(oid);
|
2014-08-27 17:01:28 +00:00
|
|
|
eaten = 0;
|
|
|
|
} else {
|
2017-02-21 23:47:23 +00:00
|
|
|
buf = read_sha1_file(oid->hash, &type, &size);
|
2014-08-27 17:01:28 +00:00
|
|
|
if (!buf)
|
2017-02-21 23:47:23 +00:00
|
|
|
die ("Could not read blob %s", oid_to_hex(oid));
|
|
|
|
if (check_sha1_signature(oid->hash, buf, size, typename(type)) < 0)
|
|
|
|
die("sha1 mismatch in blob %s", oid_to_hex(oid));
|
object: convert parse_object* to take struct object_id
Make parse_object, parse_object_or_die, and parse_object_buffer take a
pointer to struct object_id. Remove the temporary variables inserted
earlier, since they are no longer necessary. Transform all of the
callers using the following semantic patch:
@@
expression E1;
@@
- parse_object(E1.hash)
+ parse_object(&E1)
@@
expression E1;
@@
- parse_object(E1->hash)
+ parse_object(E1)
@@
expression E1, E2;
@@
- parse_object_or_die(E1.hash, E2)
+ parse_object_or_die(&E1, E2)
@@
expression E1, E2;
@@
- parse_object_or_die(E1->hash, E2)
+ parse_object_or_die(E1, E2)
@@
expression E1, E2, E3, E4, E5;
@@
- parse_object_buffer(E1.hash, E2, E3, E4, E5)
+ parse_object_buffer(&E1, E2, E3, E4, E5)
@@
expression E1, E2, E3, E4, E5;
@@
- parse_object_buffer(E1->hash, E2, E3, E4, E5)
+ parse_object_buffer(E1, E2, E3, E4, E5)
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-06 22:10:38 +00:00
|
|
|
object = parse_object_buffer(oid, type, size, buf, &eaten);
|
2014-08-27 17:01:28 +00:00
|
|
|
}
|
|
|
|
|
2013-03-17 08:38:57 +00:00
|
|
|
if (!object)
|
2017-02-21 23:47:23 +00:00
|
|
|
die("Could not read blob %s", oid_to_hex(oid));
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2008-06-11 11:17:04 +00:00
|
|
|
mark_next_object(object);
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2008-07-03 15:52:09 +00:00
|
|
|
printf("blob\nmark :%"PRIu32"\ndata %lu\n", last_idnum, size);
|
2007-12-11 22:01:28 +00:00
|
|
|
if (size && fwrite(buf, size, 1, stdout) != 1)
|
2017-02-21 23:47:23 +00:00
|
|
|
die_errno ("Could not write blob '%s'", oid_to_hex(oid));
|
2007-12-02 14:14:13 +00:00
|
|
|
printf("\n");
|
|
|
|
|
|
|
|
show_progress();
|
|
|
|
|
|
|
|
object->flags |= SHOWN;
|
2013-03-17 08:38:57 +00:00
|
|
|
if (!eaten)
|
|
|
|
free(buf);
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
|
2010-07-09 13:10:55 +00:00
|
|
|
static int depth_first(const void *a_, const void *b_)
|
|
|
|
{
|
|
|
|
const struct diff_filepair *a = *((const struct diff_filepair **)a_);
|
|
|
|
const struct diff_filepair *b = *((const struct diff_filepair **)b_);
|
|
|
|
const char *name_a, *name_b;
|
|
|
|
int len_a, len_b, len;
|
|
|
|
int cmp;
|
|
|
|
|
|
|
|
name_a = a->one ? a->one->path : a->two->path;
|
|
|
|
name_b = b->one ? b->one->path : b->two->path;
|
|
|
|
|
|
|
|
len_a = strlen(name_a);
|
|
|
|
len_b = strlen(name_b);
|
|
|
|
len = (len_a < len_b) ? len_a : len_b;
|
|
|
|
|
|
|
|
/* strcmp will sort 'd' before 'd/e', we want 'd/e' before 'd' */
|
|
|
|
cmp = memcmp(name_a, name_b, len);
|
|
|
|
if (cmp)
|
|
|
|
return cmp;
|
2010-09-07 19:33:02 +00:00
|
|
|
cmp = len_b - len_a;
|
|
|
|
if (cmp)
|
|
|
|
return cmp;
|
|
|
|
/*
|
|
|
|
* Move 'R'ename entries last so that all references of the file
|
|
|
|
* appear in the output before it is renamed (e.g., when a file
|
|
|
|
* was copied and renamed in the same commit).
|
|
|
|
*/
|
|
|
|
return (a->status == 'R') - (b->status == 'R');
|
2010-07-09 13:10:55 +00:00
|
|
|
}
|
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
static void print_path_1(const char *path)
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
{
|
|
|
|
int need_quote = quote_c_style(path, NULL, NULL, 0);
|
|
|
|
if (need_quote)
|
|
|
|
quote_c_style(path, NULL, stdout, 0);
|
2012-06-27 21:58:01 +00:00
|
|
|
else if (strchr(path, ' '))
|
|
|
|
printf("\"%s\"", path);
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
else
|
|
|
|
printf("%s", path);
|
|
|
|
}
|
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
static void *anonymize_path_component(const void *path, size_t *len)
|
|
|
|
{
|
|
|
|
static int counter;
|
|
|
|
struct strbuf out = STRBUF_INIT;
|
|
|
|
strbuf_addf(&out, "path%d", counter++);
|
|
|
|
return strbuf_detach(&out, len);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void print_path(const char *path)
|
|
|
|
{
|
|
|
|
if (!anonymize)
|
|
|
|
print_path_1(path);
|
|
|
|
else {
|
|
|
|
static struct hashmap paths;
|
|
|
|
static struct strbuf anon = STRBUF_INIT;
|
|
|
|
|
|
|
|
anonymize_path(&anon, path, &paths, anonymize_path_component);
|
|
|
|
print_path_1(anon.buf);
|
|
|
|
strbuf_reset(&anon);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-02-21 23:47:23 +00:00
|
|
|
static void *generate_fake_oid(const void *old, size_t *len)
|
2014-08-27 17:01:28 +00:00
|
|
|
{
|
|
|
|
static uint32_t counter = 1; /* avoid null sha1 */
|
2017-02-21 23:47:23 +00:00
|
|
|
unsigned char *out = xcalloc(GIT_SHA1_RAWSZ, 1);
|
|
|
|
put_be32(out + GIT_SHA1_RAWSZ - 4, counter++);
|
2014-08-27 17:01:28 +00:00
|
|
|
return out;
|
|
|
|
}
|
|
|
|
|
2017-02-21 23:47:23 +00:00
|
|
|
static const unsigned char *anonymize_sha1(const struct object_id *oid)
|
2014-08-27 17:01:28 +00:00
|
|
|
{
|
|
|
|
static struct hashmap sha1s;
|
2017-02-21 23:47:23 +00:00
|
|
|
size_t len = GIT_SHA1_RAWSZ;
|
|
|
|
return anonymize_mem(&sha1s, generate_fake_oid, oid, &len);
|
2014-08-27 17:01:28 +00:00
|
|
|
}
|
|
|
|
|
2007-12-02 14:14:13 +00:00
|
|
|
static void show_filemodify(struct diff_queue_struct *q,
|
|
|
|
struct diff_options *options, void *data)
|
|
|
|
{
|
|
|
|
int i;
|
2017-09-20 23:55:02 +00:00
|
|
|
struct string_list *changed = data;
|
2010-07-09 13:10:55 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Handle files below a directory first, in case they are all deleted
|
|
|
|
* and the directory changes to a file or symlink.
|
|
|
|
*/
|
2016-09-29 15:27:31 +00:00
|
|
|
QSORT(q->queue, q->nr, depth_first);
|
2010-07-09 13:10:55 +00:00
|
|
|
|
2007-12-02 14:14:13 +00:00
|
|
|
for (i = 0; i < q->nr; i++) {
|
2008-07-26 20:52:54 +00:00
|
|
|
struct diff_filespec *ospec = q->queue[i]->one;
|
2007-12-02 14:14:13 +00:00
|
|
|
struct diff_filespec *spec = q->queue[i]->two;
|
2008-07-26 20:52:54 +00:00
|
|
|
|
|
|
|
switch (q->queue[i]->status) {
|
|
|
|
case DIFF_STATUS_DELETED:
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
printf("D ");
|
|
|
|
print_path(spec->path);
|
2017-09-20 23:55:02 +00:00
|
|
|
string_list_insert(changed, spec->path);
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
putchar('\n');
|
2008-07-26 20:52:54 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
case DIFF_STATUS_COPIED:
|
|
|
|
case DIFF_STATUS_RENAMED:
|
2017-09-20 23:55:02 +00:00
|
|
|
/*
|
|
|
|
* If a change in the file corresponding to ospec->path
|
|
|
|
* has been observed, we cannot trust its contents
|
|
|
|
* because the diff is calculated based on the prior
|
|
|
|
* contents, not the current contents. So, declare a
|
|
|
|
* copy or rename only if there was no change observed.
|
|
|
|
*/
|
|
|
|
if (!string_list_has_string(changed, ospec->path)) {
|
|
|
|
printf("%c ", q->queue[i]->status);
|
|
|
|
print_path(ospec->path);
|
|
|
|
putchar(' ');
|
|
|
|
print_path(spec->path);
|
|
|
|
string_list_insert(changed, spec->path);
|
|
|
|
putchar('\n');
|
|
|
|
|
|
|
|
if (!oidcmp(&ospec->oid, &spec->oid) &&
|
|
|
|
ospec->mode == spec->mode)
|
|
|
|
break;
|
|
|
|
}
|
2008-07-26 20:52:54 +00:00
|
|
|
/* fallthrough */
|
|
|
|
|
|
|
|
case DIFF_STATUS_TYPE_CHANGED:
|
|
|
|
case DIFF_STATUS_MODIFIED:
|
|
|
|
case DIFF_STATUS_ADDED:
|
2008-07-19 12:21:24 +00:00
|
|
|
/*
|
|
|
|
* Links refer to objects in another repositories;
|
|
|
|
* output the SHA-1 verbatim.
|
|
|
|
*/
|
2009-07-28 02:20:22 +00:00
|
|
|
if (no_data || S_ISGITLINK(spec->mode))
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
printf("M %06o %s ", spec->mode,
|
2014-08-27 17:01:28 +00:00
|
|
|
sha1_to_hex(anonymize ?
|
2017-02-21 23:47:23 +00:00
|
|
|
anonymize_sha1(&spec->oid) :
|
2016-06-24 23:09:23 +00:00
|
|
|
spec->oid.hash));
|
2008-07-19 12:21:24 +00:00
|
|
|
else {
|
2016-06-24 23:09:23 +00:00
|
|
|
struct object *object = lookup_object(spec->oid.hash);
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
printf("M %06o :%d ", spec->mode,
|
|
|
|
get_object_mark(object));
|
2008-07-19 12:21:24 +00:00
|
|
|
}
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
print_path(spec->path);
|
2017-09-20 23:55:02 +00:00
|
|
|
string_list_insert(changed, spec->path);
|
fast-export: quote paths in output
Many pathnames in a fast-import stream need to be quoted. In
particular:
1. Pathnames at the end of an "M" or "D" line need quoting
if they contain a LF or start with double-quote.
2. Pathnames on a "C" or "R" line need quoting as above,
but also if they contain spaces.
For (1), we weren't quoting at all. For (2), we put
double-quotes around the paths to handle spaces, but ignored
the possibility that they would need further quoting.
This patch checks whether each pathname needs c-style
quoting, and uses it. This is slightly overkill for (1),
which doesn't actually need to quote many characters that
vanilla c-style quoting does. However, it shouldn't hurt, as
any implementation needs to be ready to handle quoted
strings anyway.
In addition to adding a test, we have to tweak a test which
blindly assumed that case (2) would always use
double-quotes, whether it needed to or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-08-05 22:36:22 +00:00
|
|
|
putchar('\n');
|
2008-07-26 20:52:54 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
die("Unexpected comparison status '%c' for %s, %s",
|
|
|
|
q->queue[i]->status,
|
|
|
|
ospec->path ? ospec->path : "none",
|
|
|
|
spec->path ? spec->path : "none");
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static const char *find_encoding(const char *begin, const char *end)
|
|
|
|
{
|
|
|
|
const char *needle = "\nencoding ";
|
|
|
|
char *bol, *eol;
|
|
|
|
|
|
|
|
bol = memmem(begin, end ? end - begin : strlen(begin),
|
|
|
|
needle, strlen(needle));
|
|
|
|
if (!bol)
|
|
|
|
return git_commit_encoding;
|
|
|
|
bol += strlen(needle);
|
|
|
|
eol = strchrnul(bol, '\n');
|
|
|
|
*eol = '\0';
|
|
|
|
return bol;
|
|
|
|
}
|
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
static void *anonymize_ref_component(const void *old, size_t *len)
|
|
|
|
{
|
|
|
|
static int counter;
|
|
|
|
struct strbuf out = STRBUF_INIT;
|
|
|
|
strbuf_addf(&out, "ref%d", counter++);
|
|
|
|
return strbuf_detach(&out, len);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const char *anonymize_refname(const char *refname)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* If any of these prefixes is found, we will leave it intact
|
|
|
|
* so that tags remain tags and so forth.
|
|
|
|
*/
|
|
|
|
static const char *prefixes[] = {
|
|
|
|
"refs/heads/",
|
|
|
|
"refs/tags/",
|
|
|
|
"refs/remotes/",
|
|
|
|
"refs/"
|
|
|
|
};
|
|
|
|
static struct hashmap refs;
|
|
|
|
static struct strbuf anon = STRBUF_INIT;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We also leave "master" as a special case, since it does not reveal
|
|
|
|
* anything interesting.
|
|
|
|
*/
|
|
|
|
if (!strcmp(refname, "refs/heads/master"))
|
|
|
|
return refname;
|
|
|
|
|
|
|
|
strbuf_reset(&anon);
|
|
|
|
for (i = 0; i < ARRAY_SIZE(prefixes); i++) {
|
|
|
|
if (skip_prefix(refname, prefixes[i], &refname)) {
|
|
|
|
strbuf_addstr(&anon, prefixes[i]);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
anonymize_path(&anon, refname, &refs, anonymize_ref_component);
|
|
|
|
return anon.buf;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We do not even bother to cache commit messages, as they are unlikely
|
|
|
|
* to be repeated verbatim, and it is not that interesting when they are.
|
|
|
|
*/
|
|
|
|
static char *anonymize_commit_message(const char *old)
|
|
|
|
{
|
|
|
|
static int counter;
|
|
|
|
return xstrfmt("subject %d\n\nbody\n", counter++);
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct hashmap idents;
|
|
|
|
static void *anonymize_ident(const void *old, size_t *len)
|
|
|
|
{
|
|
|
|
static int counter;
|
|
|
|
struct strbuf out = STRBUF_INIT;
|
|
|
|
strbuf_addf(&out, "User %d <user%d@example.com>", counter, counter);
|
|
|
|
counter++;
|
|
|
|
return strbuf_detach(&out, len);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Our strategy here is to anonymize the names and email addresses,
|
|
|
|
* but keep timestamps intact, as they influence things like traversal
|
|
|
|
* order (and by themselves should not be too revealing).
|
|
|
|
*/
|
|
|
|
static void anonymize_ident_line(const char **beg, const char **end)
|
|
|
|
{
|
|
|
|
static struct strbuf buffers[] = { STRBUF_INIT, STRBUF_INIT };
|
|
|
|
static unsigned which_buffer;
|
|
|
|
|
|
|
|
struct strbuf *out;
|
|
|
|
struct ident_split split;
|
|
|
|
const char *end_of_header;
|
|
|
|
|
|
|
|
out = &buffers[which_buffer++];
|
|
|
|
which_buffer %= ARRAY_SIZE(buffers);
|
|
|
|
strbuf_reset(out);
|
|
|
|
|
|
|
|
/* skip "committer", "author", "tagger", etc */
|
|
|
|
end_of_header = strchr(*beg, ' ');
|
|
|
|
if (!end_of_header)
|
|
|
|
die("BUG: malformed line fed to anonymize_ident_line: %.*s",
|
|
|
|
(int)(*end - *beg), *beg);
|
|
|
|
end_of_header++;
|
|
|
|
strbuf_add(out, *beg, end_of_header - *beg);
|
|
|
|
|
|
|
|
if (!split_ident_line(&split, end_of_header, *end - end_of_header) &&
|
|
|
|
split.date_begin) {
|
|
|
|
const char *ident;
|
|
|
|
size_t len;
|
|
|
|
|
|
|
|
len = split.mail_end - split.name_begin;
|
|
|
|
ident = anonymize_mem(&idents, anonymize_ident,
|
|
|
|
split.name_begin, &len);
|
|
|
|
strbuf_add(out, ident, len);
|
|
|
|
strbuf_addch(out, ' ');
|
|
|
|
strbuf_add(out, split.date_begin, split.tz_end - split.date_begin);
|
|
|
|
} else {
|
|
|
|
strbuf_addstr(out, "Malformed Ident <malformed@example.com> 0 -0000");
|
|
|
|
}
|
|
|
|
|
|
|
|
*beg = out->buf;
|
|
|
|
*end = out->buf + out->len;
|
|
|
|
}
|
|
|
|
|
2017-09-20 23:55:02 +00:00
|
|
|
static void handle_commit(struct commit *commit, struct rev_info *rev,
|
|
|
|
struct string_list *paths_of_changed_objects)
|
2007-12-02 14:14:13 +00:00
|
|
|
{
|
|
|
|
int saved_output_format = rev->diffopt.output_format;
|
2014-06-10 21:41:51 +00:00
|
|
|
const char *commit_buffer;
|
2007-12-02 14:14:13 +00:00
|
|
|
const char *author, *author_end, *committer, *committer_end;
|
|
|
|
const char *encoding, *message;
|
|
|
|
char *reencoded = NULL;
|
|
|
|
struct commit_list *p;
|
2014-08-27 17:01:28 +00:00
|
|
|
const char *refname;
|
2007-12-02 14:14:13 +00:00
|
|
|
int i;
|
|
|
|
|
|
|
|
rev->diffopt.output_format = DIFF_FORMAT_CALLBACK;
|
|
|
|
|
2013-10-24 08:53:46 +00:00
|
|
|
parse_commit_or_die(commit);
|
2014-06-10 21:44:13 +00:00
|
|
|
commit_buffer = get_commit_buffer(commit, NULL);
|
2014-06-10 21:41:51 +00:00
|
|
|
author = strstr(commit_buffer, "\nauthor ");
|
2007-12-02 14:14:13 +00:00
|
|
|
if (!author)
|
|
|
|
die ("Could not find author in commit %s",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&commit->object.oid));
|
2007-12-02 14:14:13 +00:00
|
|
|
author++;
|
|
|
|
author_end = strchrnul(author, '\n');
|
|
|
|
committer = strstr(author_end, "\ncommitter ");
|
|
|
|
if (!committer)
|
|
|
|
die ("Could not find committer in commit %s",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&commit->object.oid));
|
2007-12-02 14:14:13 +00:00
|
|
|
committer++;
|
|
|
|
committer_end = strchrnul(committer, '\n');
|
|
|
|
message = strstr(committer_end, "\n\n");
|
|
|
|
encoding = find_encoding(committer_end, message);
|
|
|
|
if (message)
|
|
|
|
message += 2;
|
|
|
|
|
2009-03-25 23:53:23 +00:00
|
|
|
if (commit->parents &&
|
2010-07-17 17:00:50 +00:00
|
|
|
get_object_mark(&commit->parents->item->object) != 0 &&
|
|
|
|
!full_tree) {
|
2013-10-24 08:53:46 +00:00
|
|
|
parse_commit_or_die(commit->parents->item);
|
2017-05-30 17:31:03 +00:00
|
|
|
diff_tree_oid(&commit->parents->item->tree->object.oid,
|
|
|
|
&commit->tree->object.oid, "", &rev->diffopt);
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
else
|
2017-05-30 17:30:57 +00:00
|
|
|
diff_root_tree_oid(&commit->tree->object.oid,
|
|
|
|
"", &rev->diffopt);
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2008-07-19 12:21:24 +00:00
|
|
|
/* Export the referenced blobs, and remember the marks. */
|
2007-12-02 14:14:13 +00:00
|
|
|
for (i = 0; i < diff_queued_diff.nr; i++)
|
2008-07-19 12:21:24 +00:00
|
|
|
if (!S_ISGITLINK(diff_queued_diff.queue[i]->two->mode))
|
2017-02-21 23:47:23 +00:00
|
|
|
export_blob(&diff_queued_diff.queue[i]->two->oid);
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
refname = commit->util;
|
|
|
|
if (anonymize) {
|
|
|
|
refname = anonymize_refname(refname);
|
|
|
|
anonymize_ident_line(&committer, &committer_end);
|
|
|
|
anonymize_ident_line(&author, &author_end);
|
|
|
|
}
|
|
|
|
|
2008-06-11 11:17:04 +00:00
|
|
|
mark_next_object(&commit->object);
|
2014-08-27 17:01:28 +00:00
|
|
|
if (anonymize)
|
|
|
|
reencoded = anonymize_commit_message(message);
|
|
|
|
else if (!is_encoding_utf8(encoding))
|
2007-12-02 14:14:13 +00:00
|
|
|
reencoded = reencode_string(message, "UTF-8", encoding);
|
2008-06-13 04:38:55 +00:00
|
|
|
if (!commit->parents)
|
2014-08-27 17:01:28 +00:00
|
|
|
printf("reset %s\n", refname);
|
2008-07-03 15:52:09 +00:00
|
|
|
printf("commit %s\nmark :%"PRIu32"\n%.*s\n%.*s\ndata %u\n%s",
|
2014-08-27 17:01:28 +00:00
|
|
|
refname, last_idnum,
|
2007-12-02 14:14:13 +00:00
|
|
|
(int)(author_end - author), author,
|
|
|
|
(int)(committer_end - committer), committer,
|
|
|
|
(unsigned)(reencoded
|
|
|
|
? strlen(reencoded) : message
|
|
|
|
? strlen(message) : 0),
|
|
|
|
reencoded ? reencoded : message ? message : "");
|
Avoid unnecessary "if-before-free" tests.
This change removes all obvious useless if-before-free tests.
E.g., it replaces code like this:
if (some_expression)
free (some_expression);
with the now-equivalent:
free (some_expression);
It is equivalent not just because POSIX has required free(NULL)
to work for a long time, but simply because it has worked for
so long that no reasonable porting target fails the test.
Here's some evidence from nearly 1.5 years ago:
http://www.winehq.org/pipermail/wine-patches/2006-October/031544.html
FYI, the change below was prepared by running the following:
git ls-files -z | xargs -0 \
perl -0x3b -pi -e \
's/\bif\s*\(\s*(\S+?)(?:\s*!=\s*NULL)?\s*\)\s+(free\s*\(\s*\1\s*\))/$2/s'
Note however, that it doesn't handle brace-enclosed blocks like
"if (x) { free (x); }". But that's ok, since there were none like
that in git sources.
Beware: if you do use the above snippet, note that it can
produce syntactically invalid C code. That happens when the
affected "if"-statement has a matching "else".
E.g., it would transform this
if (x)
free (x);
else
foo ();
into this:
free (x);
else
foo ();
There were none of those here, either.
If you're interested in automating detection of the useless
tests, you might like the useless-if-before-free script in gnulib:
[it *does* detect brace-enclosed free statements, and has a --name=S
option to make it detect free-like functions with different names]
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=blob;f=build-aux/useless-if-before-free
Addendum:
Remove one more (in imap-send.c), spotted by Jean-Luc Herren <jlh@gmx.ch>.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-31 17:26:32 +00:00
|
|
|
free(reencoded);
|
2014-06-10 21:41:51 +00:00
|
|
|
unuse_commit_buffer(commit, commit_buffer);
|
2007-12-02 14:14:13 +00:00
|
|
|
|
|
|
|
for (i = 0, p = commit->parents; p; p = p->next) {
|
|
|
|
int mark = get_object_mark(&p->item->object);
|
|
|
|
if (!mark)
|
|
|
|
continue;
|
|
|
|
if (i == 0)
|
|
|
|
printf("from :%d\n", mark);
|
|
|
|
else
|
2008-05-24 23:21:53 +00:00
|
|
|
printf("merge :%d\n", mark);
|
2007-12-02 14:14:13 +00:00
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
2010-07-17 17:00:50 +00:00
|
|
|
if (full_tree)
|
|
|
|
printf("deleteall\n");
|
2007-12-02 14:14:13 +00:00
|
|
|
log_tree_diff_flush(rev);
|
2017-09-20 23:55:02 +00:00
|
|
|
string_list_clear(paths_of_changed_objects, 0);
|
2007-12-02 14:14:13 +00:00
|
|
|
rev->diffopt.output_format = saved_output_format;
|
|
|
|
|
|
|
|
printf("\n");
|
|
|
|
|
|
|
|
show_progress();
|
|
|
|
}
|
|
|
|
|
2014-08-27 17:01:28 +00:00
|
|
|
static void *anonymize_tag(const void *old, size_t *len)
|
|
|
|
{
|
|
|
|
static int counter;
|
|
|
|
struct strbuf out = STRBUF_INIT;
|
|
|
|
strbuf_addf(&out, "tag message %d", counter++);
|
|
|
|
return strbuf_detach(&out, len);
|
|
|
|
}
|
|
|
|
|
2017-09-20 23:55:02 +00:00
|
|
|
static void handle_tail(struct object_array *commits, struct rev_info *revs,
|
|
|
|
struct string_list *paths_of_changed_objects)
|
2007-12-02 14:14:13 +00:00
|
|
|
{
|
|
|
|
struct commit *commit;
|
|
|
|
while (commits->nr) {
|
object_array: add and use `object_array_pop()`
In a couple of places, we pop objects off an object array `foo` by
decreasing `foo.nr`. We access `foo.nr` in many places, but most if not
all other times we do so read-only, e.g., as we iterate over the array.
But when we change `foo.nr` behind the array's back, it feels a bit
nasty and looks like it might leak memory.
Leaks happen if the popped element has an allocated `name` or `path`.
At the moment, that is not the case. Still, 1) the object array might
gain more fields that want to be freed, 2) a code path where we pop
might start using names or paths, 3) one of these code paths might be
copied to somewhere where we do, and 4) using a dedicated function for
popping is conceptually cleaner.
Introduce and use `object_array_pop()` instead. Release memory in the
new function. Document that popping an object leaves the associated
elements in limbo.
The converted places were identified by grepping for "\.nr\>" and
looking for "--".
Make the new function return NULL on an empty array. This is consistent
with `pop_commit()` and allows the following:
while ((o = object_array_pop(&foo)) != NULL) {
// do something
}
But as noted above, we don't need to go out of our way to avoid reading
`foo.nr`. This is probably more readable:
while (foo.nr) {
... o = object_array_pop(&foo);
// do something
}
The name of `object_array_pop()` does not quite align with
`add_object_array()`. That is unfortunate. On the other hand, it matches
`object_array_clear()`. Arguably it's `add_...` that is the odd one out,
since it reads like it's used to "add" an "object array". For that
reason, side with `object_array_clear()`.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-09-22 23:34:53 +00:00
|
|
|
commit = (struct commit *)object_array_pop(commits);
|
2007-12-02 14:14:13 +00:00
|
|
|
if (has_unshown_parent(commit))
|
|
|
|
return;
|
2017-09-20 23:55:02 +00:00
|
|
|
handle_commit(commit, revs, paths_of_changed_objects);
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void handle_tag(const char *name, struct tag *tag)
|
|
|
|
{
|
|
|
|
unsigned long size;
|
|
|
|
enum object_type type;
|
|
|
|
char *buf;
|
|
|
|
const char *tagger, *tagger_end, *message;
|
|
|
|
size_t message_size = 0;
|
2009-06-26 04:48:28 +00:00
|
|
|
struct object *tagged;
|
2009-06-26 04:48:31 +00:00
|
|
|
int tagged_mark;
|
|
|
|
struct commit *p;
|
2009-06-26 04:48:28 +00:00
|
|
|
|
2013-07-29 08:18:21 +00:00
|
|
|
/* Trees have no identifier in fast-export output, thus we have no way
|
2009-06-26 04:48:28 +00:00
|
|
|
* to output tags of trees, tags of tags of trees, etc. Simply omit
|
|
|
|
* such tags.
|
|
|
|
*/
|
|
|
|
tagged = tag->tagged;
|
|
|
|
while (tagged->type == OBJ_TAG) {
|
|
|
|
tagged = ((struct tag *)tagged)->tagged;
|
|
|
|
}
|
|
|
|
if (tagged->type == OBJ_TREE) {
|
|
|
|
warning("Omitting tag %s,\nsince tags of trees (or tags of tags of trees, etc.) are not supported.",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&tag->object.oid));
|
2009-06-26 04:48:28 +00:00
|
|
|
return;
|
|
|
|
}
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2015-11-10 02:22:29 +00:00
|
|
|
buf = read_sha1_file(tag->object.oid.hash, &type, &size);
|
2007-12-02 14:14:13 +00:00
|
|
|
if (!buf)
|
2015-11-10 02:22:28 +00:00
|
|
|
die ("Could not read tag %s", oid_to_hex(&tag->object.oid));
|
2007-12-02 14:14:13 +00:00
|
|
|
message = memmem(buf, size, "\n\n", 2);
|
|
|
|
if (message) {
|
|
|
|
message += 2;
|
|
|
|
message_size = strlen(message);
|
|
|
|
}
|
|
|
|
tagger = memmem(buf, message ? message - buf : size, "\ntagger ", 8);
|
2008-12-20 00:00:27 +00:00
|
|
|
if (!tagger) {
|
|
|
|
if (fake_missing_tagger)
|
|
|
|
tagger = "tagger Unspecified Tagger "
|
|
|
|
"<unspecified-tagger> 0 +0000";
|
|
|
|
else
|
|
|
|
tagger = "";
|
|
|
|
tagger_end = tagger + strlen(tagger);
|
|
|
|
} else {
|
|
|
|
tagger++;
|
|
|
|
tagger_end = strchrnul(tagger, '\n');
|
2014-08-27 17:01:28 +00:00
|
|
|
if (anonymize)
|
|
|
|
anonymize_ident_line(&tagger, &tagger_end);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (anonymize) {
|
|
|
|
name = anonymize_refname(name);
|
|
|
|
if (message) {
|
|
|
|
static struct hashmap tags;
|
|
|
|
message = anonymize_mem(&tags, anonymize_tag,
|
|
|
|
message, &message_size);
|
|
|
|
}
|
2008-12-20 00:00:27 +00:00
|
|
|
}
|
2007-12-02 14:14:13 +00:00
|
|
|
|
|
|
|
/* handle signed tags */
|
|
|
|
if (message) {
|
|
|
|
const char *signature = strstr(message,
|
|
|
|
"\n-----BEGIN PGP SIGNATURE-----\n");
|
|
|
|
if (signature)
|
|
|
|
switch(signed_tag_mode) {
|
|
|
|
case ABORT:
|
|
|
|
die ("Encountered signed tag %s; use "
|
2013-04-12 14:05:55 +00:00
|
|
|
"--signed-tags=<mode> to handle it.",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&tag->object.oid));
|
2007-12-02 14:14:13 +00:00
|
|
|
case WARN:
|
|
|
|
warning ("Exporting signed tag %s",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&tag->object.oid));
|
2007-12-02 14:14:13 +00:00
|
|
|
/* fallthru */
|
2007-12-03 22:44:39 +00:00
|
|
|
case VERBATIM:
|
2007-12-02 14:14:13 +00:00
|
|
|
break;
|
2013-04-14 10:57:06 +00:00
|
|
|
case WARN_STRIP:
|
|
|
|
warning ("Stripping signature from tag %s",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&tag->object.oid));
|
2013-04-14 10:57:06 +00:00
|
|
|
/* fallthru */
|
2007-12-02 14:14:13 +00:00
|
|
|
case STRIP:
|
|
|
|
message_size = signature + 1 - message;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-06-26 04:48:31 +00:00
|
|
|
/* handle tag->tagged having been filtered out due to paths specified */
|
|
|
|
tagged = tag->tagged;
|
|
|
|
tagged_mark = get_object_mark(tagged);
|
|
|
|
if (!tagged_mark) {
|
|
|
|
switch(tag_of_filtered_mode) {
|
|
|
|
case ABORT:
|
|
|
|
die ("Tag %s tags unexported object; use "
|
|
|
|
"--tag-of-filtered-object=<mode> to handle it.",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&tag->object.oid));
|
2009-06-26 04:48:31 +00:00
|
|
|
case DROP:
|
|
|
|
/* Ignore this tag altogether */
|
2017-05-04 13:57:33 +00:00
|
|
|
free(buf);
|
2009-06-26 04:48:31 +00:00
|
|
|
return;
|
|
|
|
case REWRITE:
|
|
|
|
if (tagged->type != OBJ_COMMIT) {
|
|
|
|
die ("Tag %s tags unexported %s!",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&tag->object.oid),
|
2009-06-26 04:48:31 +00:00
|
|
|
typename(tagged->type));
|
|
|
|
}
|
|
|
|
p = (struct commit *)tagged;
|
|
|
|
for (;;) {
|
|
|
|
if (p->parents && p->parents->next)
|
|
|
|
break;
|
|
|
|
if (p->object.flags & UNINTERESTING)
|
|
|
|
break;
|
|
|
|
if (!(p->object.flags & TREESAME))
|
|
|
|
break;
|
|
|
|
if (!p->parents)
|
|
|
|
die ("Can't find replacement commit for tag %s\n",
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&tag->object.oid));
|
2009-06-26 04:48:31 +00:00
|
|
|
p = p->parents->item;
|
|
|
|
}
|
|
|
|
tagged_mark = get_object_mark(&p->object);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-11-30 20:55:40 +00:00
|
|
|
if (starts_with(name, "refs/tags/"))
|
2007-12-02 14:14:13 +00:00
|
|
|
name += 10;
|
2008-12-20 00:00:27 +00:00
|
|
|
printf("tag %s\nfrom :%d\n%.*s%sdata %d\n%.*s\n",
|
2009-06-26 04:48:31 +00:00
|
|
|
name, tagged_mark,
|
2007-12-02 14:14:13 +00:00
|
|
|
(int)(tagger_end - tagger), tagger,
|
2008-12-20 00:00:27 +00:00
|
|
|
tagger == tagger_end ? "" : "\n",
|
2007-12-02 14:14:13 +00:00
|
|
|
(int)message_size, (int)message_size, message ? message : "");
|
2017-05-04 13:57:33 +00:00
|
|
|
free(buf);
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
|
2013-09-01 07:05:48 +00:00
|
|
|
static struct commit *get_commit(struct rev_cmdline_entry *e, char *full_name)
|
|
|
|
{
|
|
|
|
switch (e->item->type) {
|
|
|
|
case OBJ_COMMIT:
|
|
|
|
return (struct commit *)e->item;
|
|
|
|
case OBJ_TAG: {
|
|
|
|
struct tag *tag = (struct tag *)e->item;
|
|
|
|
|
|
|
|
/* handle nested tags */
|
|
|
|
while (tag && tag->object.type == OBJ_TAG) {
|
object: convert parse_object* to take struct object_id
Make parse_object, parse_object_or_die, and parse_object_buffer take a
pointer to struct object_id. Remove the temporary variables inserted
earlier, since they are no longer necessary. Transform all of the
callers using the following semantic patch:
@@
expression E1;
@@
- parse_object(E1.hash)
+ parse_object(&E1)
@@
expression E1;
@@
- parse_object(E1->hash)
+ parse_object(E1)
@@
expression E1, E2;
@@
- parse_object_or_die(E1.hash, E2)
+ parse_object_or_die(&E1, E2)
@@
expression E1, E2;
@@
- parse_object_or_die(E1->hash, E2)
+ parse_object_or_die(E1, E2)
@@
expression E1, E2, E3, E4, E5;
@@
- parse_object_buffer(E1.hash, E2, E3, E4, E5)
+ parse_object_buffer(&E1, E2, E3, E4, E5)
@@
expression E1, E2, E3, E4, E5;
@@
- parse_object_buffer(E1->hash, E2, E3, E4, E5)
+ parse_object_buffer(E1, E2, E3, E4, E5)
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-06 22:10:38 +00:00
|
|
|
parse_object(&tag->object.oid);
|
2013-09-01 07:05:48 +00:00
|
|
|
string_list_append(&extra_refs, full_name)->util = tag;
|
|
|
|
tag = (struct tag *)tag->tagged;
|
|
|
|
}
|
|
|
|
if (!tag)
|
|
|
|
die("Tag %s points nowhere?", e->name);
|
|
|
|
return (struct commit *)tag;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-01 07:05:47 +00:00
|
|
|
static void get_tags_and_duplicates(struct rev_cmdline_info *info)
|
2007-12-02 14:14:13 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
fast-export: don't handle uninteresting refs
They have been marked as UNINTERESTING for a reason, lets respect
that. Currently the first ref is handled properly, but not the
rest. Assuming that all the refs point at the same commit in the
following example:
% git fast-export master ^uninteresting ^foo ^bar
reset refs/heads/bar
from :0
reset refs/heads/foo
from :0
reset refs/heads/uninteresting
from :0
% git fast-export ^uninteresting ^foo ^bar master
reset refs/heads/master
from :0
reset refs/heads/bar
from :0
reset refs/heads/foo
from :0
Clearly this is wrong; the negative refs should be ignored.
After this patch:
% git fast-export ^uninteresting ^foo ^bar master
# nothing
% git fast-export master ^uninteresting ^foo ^bar
# nothing
And even more, it would only happen if the ref is pointing to exactly
the same commit, but not otherwise:
% git fast-export ^next next
reset refs/heads/next
from :0
% git fast-export ^next next^{commit}
# nothing
% git fast-export ^next next~0
# nothing
% git fast-export ^next next~1
# nothing
% git fast-export ^next next~2
# nothing
The reason this happens is that before traversing the commits,
fast-export checks if any of the refs point to the same object, and any
duplicated ref gets added to a list in order to issue 'reset' commands
after the traversing. Unfortunately, it's not even checking if the
commit is flagged as UNINTERESTING. The fix of course, is to check it.
However, in order to do it properly we need to get the UNINTERESTING
flag from the command line, not from the commit object, because
"^foo bar" will mark the commit 'bar' uninteresting if foo and bar
points at the same commit. rev_cmdline_info, which was introduced
exactly to handle this situation, contains all the information we
need for get_tags_and_duplicates(), plus the ref flag. This way the
rest of the positive refs will remain untouched; it's only the
negative ones that change in behavior.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-11-28 22:23:59 +00:00
|
|
|
for (i = 0; i < info->nr; i++) {
|
|
|
|
struct rev_cmdline_entry *e = info->rev + i;
|
2017-02-21 23:47:23 +00:00
|
|
|
struct object_id oid;
|
2012-11-28 22:11:08 +00:00
|
|
|
struct commit *commit;
|
2007-12-02 14:14:13 +00:00
|
|
|
char *full_name;
|
|
|
|
|
fast-export: don't handle uninteresting refs
They have been marked as UNINTERESTING for a reason, lets respect
that. Currently the first ref is handled properly, but not the
rest. Assuming that all the refs point at the same commit in the
following example:
% git fast-export master ^uninteresting ^foo ^bar
reset refs/heads/bar
from :0
reset refs/heads/foo
from :0
reset refs/heads/uninteresting
from :0
% git fast-export ^uninteresting ^foo ^bar master
reset refs/heads/master
from :0
reset refs/heads/bar
from :0
reset refs/heads/foo
from :0
Clearly this is wrong; the negative refs should be ignored.
After this patch:
% git fast-export ^uninteresting ^foo ^bar master
# nothing
% git fast-export master ^uninteresting ^foo ^bar
# nothing
And even more, it would only happen if the ref is pointing to exactly
the same commit, but not otherwise:
% git fast-export ^next next
reset refs/heads/next
from :0
% git fast-export ^next next^{commit}
# nothing
% git fast-export ^next next~0
# nothing
% git fast-export ^next next~1
# nothing
% git fast-export ^next next~2
# nothing
The reason this happens is that before traversing the commits,
fast-export checks if any of the refs point to the same object, and any
duplicated ref gets added to a list in order to issue 'reset' commands
after the traversing. Unfortunately, it's not even checking if the
commit is flagged as UNINTERESTING. The fix of course, is to check it.
However, in order to do it properly we need to get the UNINTERESTING
flag from the command line, not from the commit object, because
"^foo bar" will mark the commit 'bar' uninteresting if foo and bar
points at the same commit. rev_cmdline_info, which was introduced
exactly to handle this situation, contains all the information we
need for get_tags_and_duplicates(), plus the ref flag. This way the
rest of the positive refs will remain untouched; it's only the
negative ones that change in behavior.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-11-28 22:23:59 +00:00
|
|
|
if (e->flags & UNINTERESTING)
|
|
|
|
continue;
|
|
|
|
|
2017-10-15 22:06:57 +00:00
|
|
|
if (dwim_ref(e->name, strlen(e->name), &oid, &full_name) != 1)
|
2007-12-02 14:14:13 +00:00
|
|
|
continue;
|
|
|
|
|
2014-04-20 18:59:24 +00:00
|
|
|
if (refspecs) {
|
|
|
|
char *private;
|
|
|
|
private = apply_refspecs(refspecs, refspecs_nr, full_name);
|
|
|
|
if (private) {
|
|
|
|
free(full_name);
|
|
|
|
full_name = private;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-01 07:05:48 +00:00
|
|
|
commit = get_commit(e, full_name);
|
|
|
|
if (!commit) {
|
2009-03-23 12:53:07 +00:00
|
|
|
warning("%s: Unexpected object of type %s, skipping.",
|
|
|
|
e->name,
|
|
|
|
typename(e->item->type));
|
|
|
|
continue;
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
fast-export: make sure updated refs get updated
When an object has already been exported (and thus is in the marks) it's
flagged as SHOWN, so it will not be exported again, even if in a later
time it's exported through a different ref.
We don't need the object to be exported again, but we want the ref
updated, which doesn't happen.
Since we can't know if a ref was exported or not, let's just assume that
if the commit was marked (flags & SHOWN), the user still wants the ref
updated.
IOW: If it's specified in the command line, it will get updated,
regardless of whether or not the object was marked.
So:
% git branch test master
% git fast-export $mark_flags master
% git fast-export $mark_flags test
Would export 'test' properly.
Additionally, this fixes issues with remote helpers; now they can push
refs whose objects have already been exported, and a few other issues as
well. Update the tests accordingly.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-11-28 22:24:00 +00:00
|
|
|
|
2013-09-01 07:05:48 +00:00
|
|
|
switch(commit->object.type) {
|
|
|
|
case OBJ_COMMIT:
|
|
|
|
break;
|
|
|
|
case OBJ_BLOB:
|
2017-02-21 23:47:23 +00:00
|
|
|
export_blob(&commit->object.oid);
|
2013-09-01 07:05:48 +00:00
|
|
|
continue;
|
|
|
|
default: /* OBJ_TAG (nested tags) is already handled */
|
|
|
|
warning("Tag points to object of unexpected type %s, skipping.",
|
|
|
|
typename(commit->object.type));
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
fast-export: make sure updated refs get updated
When an object has already been exported (and thus is in the marks) it's
flagged as SHOWN, so it will not be exported again, even if in a later
time it's exported through a different ref.
We don't need the object to be exported again, but we want the ref
updated, which doesn't happen.
Since we can't know if a ref was exported or not, let's just assume that
if the commit was marked (flags & SHOWN), the user still wants the ref
updated.
IOW: If it's specified in the command line, it will get updated,
regardless of whether or not the object was marked.
So:
% git branch test master
% git fast-export $mark_flags master
% git fast-export $mark_flags test
Would export 'test' properly.
Additionally, this fixes issues with remote helpers; now they can push
refs whose objects have already been exported, and a few other issues as
well. Update the tests accordingly.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-11-28 22:24:00 +00:00
|
|
|
/*
|
|
|
|
* This ref will not be updated through a commit, lets make
|
|
|
|
* sure it gets properly updated eventually.
|
|
|
|
*/
|
|
|
|
if (commit->util || commit->object.flags & SHOWN)
|
2013-09-01 07:05:47 +00:00
|
|
|
string_list_append(&extra_refs, full_name)->util = commit;
|
fast-export: make sure updated refs get updated
When an object has already been exported (and thus is in the marks) it's
flagged as SHOWN, so it will not be exported again, even if in a later
time it's exported through a different ref.
We don't need the object to be exported again, but we want the ref
updated, which doesn't happen.
Since we can't know if a ref was exported or not, let's just assume that
if the commit was marked (flags & SHOWN), the user still wants the ref
updated.
IOW: If it's specified in the command line, it will get updated,
regardless of whether or not the object was marked.
So:
% git branch test master
% git fast-export $mark_flags master
% git fast-export $mark_flags test
Would export 'test' properly.
Additionally, this fixes issues with remote helpers; now they can push
refs whose objects have already been exported, and a few other issues as
well. Update the tests accordingly.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-11-28 22:24:00 +00:00
|
|
|
if (!commit->util)
|
2007-12-02 14:14:13 +00:00
|
|
|
commit->util = full_name;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-01 07:05:47 +00:00
|
|
|
static void handle_tags_and_duplicates(void)
|
2007-12-02 14:14:13 +00:00
|
|
|
{
|
|
|
|
struct commit *commit;
|
|
|
|
int i;
|
|
|
|
|
2013-09-01 07:05:47 +00:00
|
|
|
for (i = extra_refs.nr - 1; i >= 0; i--) {
|
|
|
|
const char *name = extra_refs.items[i].string;
|
|
|
|
struct object *object = extra_refs.items[i].util;
|
2007-12-02 14:14:13 +00:00
|
|
|
switch (object->type) {
|
|
|
|
case OBJ_TAG:
|
|
|
|
handle_tag(name, (struct tag *)object);
|
|
|
|
break;
|
|
|
|
case OBJ_COMMIT:
|
2014-08-27 17:01:28 +00:00
|
|
|
if (anonymize)
|
|
|
|
name = anonymize_refname(name);
|
2007-12-02 14:14:13 +00:00
|
|
|
/* create refs pointing to already seen commits */
|
|
|
|
commit = (struct commit *)object;
|
|
|
|
printf("reset %s\nfrom :%d\n\n", name,
|
|
|
|
get_object_mark(&commit->object));
|
|
|
|
show_progress();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-06-11 11:17:04 +00:00
|
|
|
static void export_marks(char *file)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
uint32_t mark;
|
2017-12-08 00:14:24 +00:00
|
|
|
struct decoration_entry *deco = idnums.entries;
|
2008-06-11 11:17:04 +00:00
|
|
|
FILE *f;
|
2009-07-24 08:17:13 +00:00
|
|
|
int e = 0;
|
2008-06-11 11:17:04 +00:00
|
|
|
|
Handle more file writes correctly in shared repos
In shared repositories, we have to be careful when writing files whose
permissions do not allow users other than the owner to write them.
In particular, we force the marks file of fast-export and the FETCH_HEAD
when fetching to be rewritten from scratch.
This commit does not touch other calls to fopen() that want to
write files:
- commands that write to working tree files (core.sharedRepository
does not affect permission bits of working tree files),
e.g. .rej file created by "apply --reject", result of applying a
previous conflict resolution by "rerere", "git merge-file".
- git am, when splitting mails (git-am correctly cleans up its directory
after finishing, so there is no need to share those files between users)
- git submodule clone, when writing the .git file, because the file
will not be overwritten
- git_terminal_prompt() in compat/terminal.c, because it is not writing to
a file at all
- git diff --output, because the output file is clearly not intended to be
shared between the users of the current repository
- git fast-import, when writing a crash report, because the reports' file
names are unique due to an embedded process ID
- mailinfo() in mailinfo.c, because the output is clearly not intended to
be shared between the users of the current repository
- check_or_regenerate_marks() in remote-testsvn.c, because this is only
used for Git's internal testing
- git fsck, when writing lost&found blobs (this should probably be
changed, but left as a low-hanging fruit for future contributors).
Note that this patch does not touch callers of write_file() and
write_file_gently(), which would benefit from the same scrutiny as
to usage in shared repositories. Most notable users are branch,
daemon, submodule & worktree, and a worrisome call in transport.c
when updating one ref (which ignores the shared flag).
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2016-01-11 18:35:54 +00:00
|
|
|
f = fopen_for_writing(file);
|
2008-06-11 11:17:04 +00:00
|
|
|
if (!f)
|
2010-03-28 05:42:48 +00:00
|
|
|
die_errno("Unable to open marks file %s for writing.", file);
|
2008-06-11 11:17:04 +00:00
|
|
|
|
2008-07-03 07:25:23 +00:00
|
|
|
for (i = 0; i < idnums.size; i++) {
|
|
|
|
if (deco->base && deco->base->type == 1) {
|
2008-06-11 11:17:04 +00:00
|
|
|
mark = ptr_to_mark(deco->decoration);
|
2009-07-24 08:17:13 +00:00
|
|
|
if (fprintf(f, ":%"PRIu32" %s\n", mark,
|
2015-11-10 02:22:28 +00:00
|
|
|
oid_to_hex(&deco->base->oid)) < 0) {
|
2009-07-24 08:17:13 +00:00
|
|
|
e = 1;
|
|
|
|
break;
|
|
|
|
}
|
2008-06-11 11:17:04 +00:00
|
|
|
}
|
2008-07-03 07:25:23 +00:00
|
|
|
deco++;
|
2008-06-11 11:17:04 +00:00
|
|
|
}
|
|
|
|
|
2009-07-24 08:17:13 +00:00
|
|
|
e |= ferror(f);
|
|
|
|
e |= fclose(f);
|
|
|
|
if (e)
|
2008-06-11 11:17:04 +00:00
|
|
|
error("Unable to write marks file %s.", file);
|
|
|
|
}
|
|
|
|
|
2008-07-03 07:25:23 +00:00
|
|
|
static void import_marks(char *input_file)
|
2008-06-11 11:17:04 +00:00
|
|
|
{
|
|
|
|
char line[512];
|
2017-05-03 10:16:46 +00:00
|
|
|
FILE *f = xfopen(input_file, "r");
|
2008-06-11 11:17:04 +00:00
|
|
|
|
|
|
|
while (fgets(line, sizeof(line), f)) {
|
|
|
|
uint32_t mark;
|
|
|
|
char *line_end, *mark_end;
|
2017-02-21 23:47:23 +00:00
|
|
|
struct object_id oid;
|
2008-06-11 11:17:04 +00:00
|
|
|
struct object *object;
|
2013-05-05 22:38:54 +00:00
|
|
|
struct commit *commit;
|
2013-05-05 22:38:53 +00:00
|
|
|
enum object_type type;
|
2008-06-11 11:17:04 +00:00
|
|
|
|
|
|
|
line_end = strchr(line, '\n');
|
|
|
|
if (line[0] != ':' || !line_end)
|
|
|
|
die("corrupt mark line: %s", line);
|
2008-07-03 07:25:23 +00:00
|
|
|
*line_end = '\0';
|
2008-06-11 11:17:04 +00:00
|
|
|
|
|
|
|
mark = strtoumax(line + 1, &mark_end, 10);
|
|
|
|
if (!mark || mark_end == line + 1
|
2017-02-21 23:47:23 +00:00
|
|
|
|| *mark_end != ' ' || get_oid_hex(mark_end + 1, &oid))
|
2008-06-11 11:17:04 +00:00
|
|
|
die("corrupt mark line: %s", line);
|
|
|
|
|
2013-04-06 17:04:31 +00:00
|
|
|
if (last_idnum < mark)
|
|
|
|
last_idnum = mark;
|
|
|
|
|
2017-02-21 23:47:23 +00:00
|
|
|
type = sha1_object_info(oid.hash, NULL);
|
2013-05-05 22:38:53 +00:00
|
|
|
if (type < 0)
|
2017-02-21 23:47:23 +00:00
|
|
|
die("object not found: %s", oid_to_hex(&oid));
|
2013-05-05 22:38:53 +00:00
|
|
|
|
|
|
|
if (type != OBJ_COMMIT)
|
|
|
|
/* only commits */
|
2013-04-06 17:04:31 +00:00
|
|
|
continue;
|
2008-06-11 11:17:04 +00:00
|
|
|
|
Convert lookup_commit* to struct object_id
Convert lookup_commit, lookup_commit_or_die,
lookup_commit_reference, and lookup_commit_reference_gently to take
struct object_id arguments.
Introduce a temporary in parse_object buffer in order to convert this
function. This is required since in order to convert parse_object and
parse_object_buffer, lookup_commit_reference_gently and
lookup_commit_or_die would need to be converted. Not introducing a
temporary would therefore require that lookup_commit_or_die take a
struct object_id *, but lookup_commit would take unsigned char *,
leaving a confusing and hard-to-use interface.
parse_object_buffer will lose this temporary in a later patch.
This commit was created with manual changes to commit.c, commit.h, and
object.c, plus the following semantic patch:
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1.hash, E2)
+ lookup_commit_reference_gently(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1->hash, E2)
+ lookup_commit_reference_gently(E1, E2)
@@
expression E1;
@@
- lookup_commit_reference(E1.hash)
+ lookup_commit_reference(&E1)
@@
expression E1;
@@
- lookup_commit_reference(E1->hash)
+ lookup_commit_reference(E1)
@@
expression E1;
@@
- lookup_commit(E1.hash)
+ lookup_commit(&E1)
@@
expression E1;
@@
- lookup_commit(E1->hash)
+ lookup_commit(E1)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1.hash, E2)
+ lookup_commit_or_die(&E1, E2)
@@
expression E1, E2;
@@
- lookup_commit_or_die(E1->hash, E2)
+ lookup_commit_or_die(E1, E2)
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-05-06 22:10:10 +00:00
|
|
|
commit = lookup_commit(&oid);
|
2013-05-05 22:38:54 +00:00
|
|
|
if (!commit)
|
2017-02-21 23:47:23 +00:00
|
|
|
die("not a commit? can't happen: %s", oid_to_hex(&oid));
|
2013-05-05 22:38:54 +00:00
|
|
|
|
|
|
|
object = &commit->object;
|
2013-05-05 22:38:53 +00:00
|
|
|
|
2008-06-11 11:17:04 +00:00
|
|
|
if (object->flags & SHOWN)
|
2017-02-21 23:47:23 +00:00
|
|
|
error("Object %s already has a mark", oid_to_hex(&oid));
|
2008-06-11 11:17:04 +00:00
|
|
|
|
|
|
|
mark_object(object, mark);
|
|
|
|
|
|
|
|
object->flags |= SHOWN;
|
|
|
|
}
|
|
|
|
fclose(f);
|
|
|
|
}
|
|
|
|
|
2014-04-20 18:59:28 +00:00
|
|
|
static void handle_deletes(void)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
for (i = 0; i < refspecs_nr; i++) {
|
|
|
|
struct refspec *refspec = &refspecs[i];
|
|
|
|
if (*refspec->src)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
printf("reset %s\nfrom %s\n\n",
|
|
|
|
refspec->dst, sha1_to_hex(null_sha1));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-12-02 14:14:13 +00:00
|
|
|
int cmd_fast_export(int argc, const char **argv, const char *prefix)
|
|
|
|
{
|
|
|
|
struct rev_info revs;
|
2010-08-29 02:04:17 +00:00
|
|
|
struct object_array commits = OBJECT_ARRAY_INIT;
|
2007-12-02 14:14:13 +00:00
|
|
|
struct commit *commit;
|
2008-06-11 11:17:04 +00:00
|
|
|
char *export_filename = NULL, *import_filename = NULL;
|
2013-04-06 17:04:31 +00:00
|
|
|
uint32_t lastimportid;
|
2014-04-20 18:59:24 +00:00
|
|
|
struct string_list refspecs_list = STRING_LIST_INIT_NODUP;
|
2017-09-20 23:55:02 +00:00
|
|
|
struct string_list paths_of_changed_objects = STRING_LIST_INIT_DUP;
|
2007-12-02 14:14:13 +00:00
|
|
|
struct option options[] = {
|
|
|
|
OPT_INTEGER(0, "progress", &progress,
|
2012-08-20 12:32:08 +00:00
|
|
|
N_("show progress after <n> objects")),
|
|
|
|
OPT_CALLBACK(0, "signed-tags", &signed_tag_mode, N_("mode"),
|
|
|
|
N_("select handling of signed tags"),
|
2007-12-02 14:14:13 +00:00
|
|
|
parse_opt_signed_tag_mode),
|
2012-08-20 12:32:08 +00:00
|
|
|
OPT_CALLBACK(0, "tag-of-filtered-object", &tag_of_filtered_mode, N_("mode"),
|
|
|
|
N_("select handling of tags that tag filtered objects"),
|
2009-06-26 04:48:31 +00:00
|
|
|
parse_opt_tag_of_filtered_mode),
|
2012-08-20 12:32:08 +00:00
|
|
|
OPT_STRING(0, "export-marks", &export_filename, N_("file"),
|
|
|
|
N_("Dump marks to this file")),
|
|
|
|
OPT_STRING(0, "import-marks", &import_filename, N_("file"),
|
|
|
|
N_("Import marks from this file")),
|
2013-08-03 11:51:19 +00:00
|
|
|
OPT_BOOL(0, "fake-missing-tagger", &fake_missing_tagger,
|
|
|
|
N_("Fake a tagger when tags lack one")),
|
|
|
|
OPT_BOOL(0, "full-tree", &full_tree,
|
|
|
|
N_("Output full tree for each commit")),
|
|
|
|
OPT_BOOL(0, "use-done-feature", &use_done_feature,
|
2012-08-20 12:32:08 +00:00
|
|
|
N_("Use the done feature to terminate the stream")),
|
|
|
|
OPT_BOOL(0, "no-data", &no_data, N_("Skip output of blob data")),
|
2014-04-20 18:59:24 +00:00
|
|
|
OPT_STRING_LIST(0, "refspec", &refspecs_list, N_("refspec"),
|
|
|
|
N_("Apply refspec to exported refs")),
|
2014-08-27 17:01:28 +00:00
|
|
|
OPT_BOOL(0, "anonymize", &anonymize, N_("anonymize output")),
|
2007-12-02 14:14:13 +00:00
|
|
|
OPT_END()
|
|
|
|
};
|
|
|
|
|
2009-01-03 03:59:12 +00:00
|
|
|
if (argc == 1)
|
|
|
|
usage_with_options (fast_export_usage, options);
|
|
|
|
|
2007-12-02 14:14:13 +00:00
|
|
|
/* we handle encodings */
|
2008-05-14 17:46:53 +00:00
|
|
|
git_config(git_default_config, NULL);
|
2007-12-02 14:14:13 +00:00
|
|
|
|
|
|
|
init_revisions(&revs, prefix);
|
2009-06-26 04:48:27 +00:00
|
|
|
revs.topo_order = 1;
|
2009-06-26 04:48:29 +00:00
|
|
|
revs.show_source = 1;
|
2009-06-26 04:48:30 +00:00
|
|
|
revs.rewrite_parents = 1;
|
2014-04-20 18:59:23 +00:00
|
|
|
argc = parse_options(argc, argv, prefix, options, fast_export_usage,
|
|
|
|
PARSE_OPT_KEEP_ARGV0 | PARSE_OPT_KEEP_UNKNOWN);
|
2007-12-02 14:14:13 +00:00
|
|
|
argc = setup_revisions(argc, argv, &revs, NULL);
|
|
|
|
if (argc > 1)
|
|
|
|
usage_with_options (fast_export_usage, options);
|
|
|
|
|
2014-04-20 18:59:24 +00:00
|
|
|
if (refspecs_list.nr) {
|
|
|
|
const char **refspecs_str;
|
|
|
|
int i;
|
|
|
|
|
2016-02-22 22:44:25 +00:00
|
|
|
ALLOC_ARRAY(refspecs_str, refspecs_list.nr);
|
2014-04-20 18:59:24 +00:00
|
|
|
for (i = 0; i < refspecs_list.nr; i++)
|
|
|
|
refspecs_str[i] = refspecs_list.items[i].string;
|
|
|
|
|
|
|
|
refspecs_nr = refspecs_list.nr;
|
|
|
|
refspecs = parse_fetch_refspec(refspecs_nr, refspecs_str);
|
|
|
|
|
|
|
|
string_list_clear(&refspecs_list, 1);
|
|
|
|
free(refspecs_str);
|
|
|
|
}
|
|
|
|
|
2011-07-16 13:03:33 +00:00
|
|
|
if (use_done_feature)
|
|
|
|
printf("feature done\n");
|
|
|
|
|
2008-06-11 11:17:04 +00:00
|
|
|
if (import_filename)
|
|
|
|
import_marks(import_filename);
|
2013-04-06 17:04:31 +00:00
|
|
|
lastimportid = last_idnum;
|
2008-06-11 11:17:04 +00:00
|
|
|
|
2010-12-17 12:43:06 +00:00
|
|
|
if (import_filename && revs.prune_data.nr)
|
2010-07-17 17:00:50 +00:00
|
|
|
full_tree = 1;
|
|
|
|
|
2013-09-01 07:05:47 +00:00
|
|
|
get_tags_and_duplicates(&revs.cmdline);
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2008-02-18 07:31:56 +00:00
|
|
|
if (prepare_revision_walk(&revs))
|
|
|
|
die("revision walk setup failed");
|
2007-12-02 14:14:13 +00:00
|
|
|
revs.diffopt.format_callback = show_filemodify;
|
2017-09-20 23:55:02 +00:00
|
|
|
revs.diffopt.format_callback_data = &paths_of_changed_objects;
|
2017-10-31 18:19:11 +00:00
|
|
|
revs.diffopt.flags.recursive = 1;
|
2007-12-02 14:14:13 +00:00
|
|
|
while ((commit = get_revision(&revs))) {
|
|
|
|
if (has_unshown_parent(commit)) {
|
|
|
|
add_object_array(&commit->object, NULL, &commits);
|
|
|
|
}
|
|
|
|
else {
|
2017-09-20 23:55:02 +00:00
|
|
|
handle_commit(commit, &revs, &paths_of_changed_objects);
|
|
|
|
handle_tail(&commits, &revs, &paths_of_changed_objects);
|
2007-12-02 14:14:13 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-01 07:05:47 +00:00
|
|
|
handle_tags_and_duplicates();
|
2014-04-20 18:59:28 +00:00
|
|
|
handle_deletes();
|
2007-12-02 14:14:13 +00:00
|
|
|
|
2013-04-06 17:04:31 +00:00
|
|
|
if (export_filename && lastimportid != last_idnum)
|
2008-06-11 11:17:04 +00:00
|
|
|
export_marks(export_filename);
|
|
|
|
|
2011-07-16 13:03:33 +00:00
|
|
|
if (use_done_feature)
|
|
|
|
printf("done\n");
|
|
|
|
|
2014-04-20 18:59:24 +00:00
|
|
|
free_refspec(refspecs_nr, refspecs);
|
|
|
|
|
2007-12-02 14:14:13 +00:00
|
|
|
return 0;
|
|
|
|
}
|