git/contrib/coccinelle/free.cocci

@@
expression E;
@@
- if (E)
  free(E);

@@
expression E;
@@
- if (!E)
  free(E);

@@
expression E;
@@
- free(E);
+ FREE_AND_NULL(E);
- E = NULL;
remove unnecessary NULL check before free(3) free(3) handles NULL pointers just fine. Add a semantic patch for removing unnecessary NULL checks before calling this function, and apply it on the code base. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2016-10-08 14:14:57 +00:00			`@@`
			`expression E;`
			`@@`
			`- if (E)`
			`free(E);`
cocci: detect useless free(3) calls Add a semantic patch for removing checks that cause free(3) to only be called with a NULL pointer, as that must be a programming mistake. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2017-02-11 13:58:44 +00:00
			`@@`
			`expression E;`
			`@@`
			`- if (!E)`
			`free(E);`
coccinelle: add a rule to make "type" code use FREE_AND_NULL() Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2017-06-15 23:15:45 +00:00
coccinelle: add a rule to make "expression" code use FREE_AND_NULL() A follow-up to the existing "type" rule added in an earlier change. This catches some occurrences that are missed by the previous rule. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2017-06-15 23:15:47 +00:00			`@@`
			`expression E;`
			`@@`
			`- free(E);`
			`+ FREE_AND_NULL(E);`
coccinelle: polish FREE_AND_NULL rules There are two rules for using FREE_AND_NULL in free.cocci, one for pointer types and one for expressions. Both cause coccinelle to remove empty lines and even newline characters between replacements for some reason; consecutive "free(x);/x=NULL;" sequences end up as multiple FREE_AND_NULL calls on the same time. Remove the type rule, as the expression rule already covers it, and rearrange the lines of the latter to place the addition of FREE_AND_NULL between the removals, which causes coccinelle to leave surrounding whitespace untouched. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2017-06-25 08:01:04 +00:00			`- E = NULL;`