git/t/chainlint/inline-comment.test

(
# LINT: swallow inline comment (leaving command intact)
	foobar && # comment 1
# LINT: mispositioned "&&" (correctly) swallowed with comment
	barfoo # wrong position for &&
# LINT: "#" in string not misinterpreted as comment
	flibble "not a # comment"
) &&

# LINT: "#" in string in cuddled subshell not misinterpreted as comment
(cd foo &&
	flibble "not a # comment")
t/chainlint: add chainlint "whitespace" test cases The --chain-lint option uses heuristics and knowledge of shell syntax to detect broken &&-chains in subshells by pure textual inspection. The heuristics handle a range of stylistic variations in existing tests (evolved over the years), however, they are still best-guesses. As such, it is possible for future changes to accidentally break assumptions upon which the heuristics are based. Protect against this possibility by adding tests which check the linter itself for correctness. In addition to protecting against regressions, these tests help document (for humans) expected behavior, which is important since the linter's implementation language ('sed') does not necessarily lend itself to easy comprehension. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2018-07-11 06:46:36 +00:00			`(`
			`# LINT: swallow inline comment (leaving command intact)`
			`foobar && # comment 1`
			`# LINT: mispositioned "&&" (correctly) swallowed with comment`
			`barfoo # wrong position for &&`
			`# LINT: "#" in string not misinterpreted as comment`
			`flibble "not a # comment"`
			`) &&`

			`# LINT: "#" in string in cuddled subshell not misinterpreted as comment`
			`(cd foo &&`
			`flibble "not a # comment")`