git/t/chainlint/t7900-subtree.test

(
	chks="sub1
sub2
sub3
sub4" &&
	chks_sub=$(cat <<TXT | sed "s,^,sub dir/,"
$chks
TXT
) &&
	chkms="main-sub1
main-sub2
main-sub3
main-sub4" &&
	chkms_sub=$(cat <<TXT | sed "s,^,sub dir/,"
$chkms
TXT
) &&

	subfiles=$(git ls-files) &&
	check_equal "$subfiles" "$chkms
$chks"
)
chainlint: add test of pathological case which triggered false positive This extract from contrib/subtree/t7900 triggered a false positive due to three chainlint limitations: * recognizing only a "blessed" set of here-doc tag names in a subshell ("EOF", "EOT", "INPUT_END"), of which "TXT" is not a member * inability to recognize multi-line $(...) when the first statement of the body is cuddled with the opening "$(" * inability to recognize multiple constructs on a single line, such as opening a multi-line $(...) and starting a here-doc Now that all of these shortcomings have been addressed, turn this rather pathological bit of shell coding into a chainlint test case. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2018-08-13 08:47:39 +00:00			`(`
			`chks="sub1`
			`sub2`
			`sub3`
			`sub4" &&`
t/chainlint/*.test: fix invalid test cases due to mixing quote types The chainlint self-test code snippets are supposed to represent the body of a test_expect_success() or test_expect_failure(), yet the contents of a few tests would have caused the shell to report syntax errors had they been real test bodies due to the mix of single- and double-quotes. Although chainlint.sed, with its simplistic heuristics, is blind to this problem, a future more robust chainlint implementation might not have such a limitation. Therefore, stop mixing quote types haphazardly in those tests and unify quoting throughout. While at it, drop chunks of tests which merely repeat what is already tested elsewhere but with alternative quotes. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2021-12-13 06:30:46 +00:00			`chks_sub=$(cat <<TXT \| sed "s,^,sub dir/,"`
chainlint: add test of pathological case which triggered false positive This extract from contrib/subtree/t7900 triggered a false positive due to three chainlint limitations: * recognizing only a "blessed" set of here-doc tag names in a subshell ("EOF", "EOT", "INPUT_END"), of which "TXT" is not a member * inability to recognize multi-line $(...) when the first statement of the body is cuddled with the opening "$(" * inability to recognize multiple constructs on a single line, such as opening a multi-line $(...) and starting a here-doc Now that all of these shortcomings have been addressed, turn this rather pathological bit of shell coding into a chainlint test case. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2018-08-13 08:47:39 +00:00			`$chks`
			`TXT`
			`) &&`
			`chkms="main-sub1`
			`main-sub2`
			`main-sub3`
			`main-sub4" &&`
t/chainlint/*.test: fix invalid test cases due to mixing quote types The chainlint self-test code snippets are supposed to represent the body of a test_expect_success() or test_expect_failure(), yet the contents of a few tests would have caused the shell to report syntax errors had they been real test bodies due to the mix of single- and double-quotes. Although chainlint.sed, with its simplistic heuristics, is blind to this problem, a future more robust chainlint implementation might not have such a limitation. Therefore, stop mixing quote types haphazardly in those tests and unify quoting throughout. While at it, drop chunks of tests which merely repeat what is already tested elsewhere but with alternative quotes. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2021-12-13 06:30:46 +00:00			`chkms_sub=$(cat <<TXT \| sed "s,^,sub dir/,"`
chainlint: add test of pathological case which triggered false positive This extract from contrib/subtree/t7900 triggered a false positive due to three chainlint limitations: * recognizing only a "blessed" set of here-doc tag names in a subshell ("EOF", "EOT", "INPUT_END"), of which "TXT" is not a member * inability to recognize multi-line $(...) when the first statement of the body is cuddled with the opening "$(" * inability to recognize multiple constructs on a single line, such as opening a multi-line $(...) and starting a here-doc Now that all of these shortcomings have been addressed, turn this rather pathological bit of shell coding into a chainlint test case. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2018-08-13 08:47:39 +00:00			`$chkms`
			`TXT`
			`) &&`

			`subfiles=$(git ls-files) &&`
			`check_equal "$subfiles" "$chkms`
			`$chks"`
			`)`