git/t/chainlint/loop-detect-failure.test

git init r1 &&
# LINT: loop handles failure explicitly with "|| return 1"
for n in 1 2 3 4 5
do
	echo "This is file: $n" > r1/file.$n &&
	git -C r1 add file.$n &&
	git -C r1 commit -m "$n" || return 1
done &&

git init r2 &&
# LINT: loop fails to handle failure explicitly with "|| return 1"
for n in 1000 10000
do
	printf "%"$n"s" X > r2/large.$n &&
	git -C r2 add large.$n &&
	git -C r2 commit -m "$n"
done
chainlint.pl: complain about loops lacking explicit failure handling Shell `for` and `while` loops do not terminate automatically just because a command fails within the loop body. Instead, the loop continues to iterate and eventually returns the exit status of the final command of the final iteration, which may not be the command which failed, thus it is possible for failures to go undetected. Consequently, it is important for test authors to explicitly handle failure within the loop body by terminating the loop manually upon failure. This can be done by returning a non-zero exit code from within the loop body (i.e. `\|\| return 1`) or exiting (i.e. `\|\| exit 1`) if the loop is within a subshell, or by manually checking `$?` and taking some appropriate action. Therefore, add logic to detect and complain about loops which lack explicit `return` or `exit`, or `$?` check. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> 2022-09-01 00:29:50 +00:00			`git init r1 &&`
			`# LINT: loop handles failure explicitly with "\|\| return 1"`
			`for n in 1 2 3 4 5`
			`do`
			`echo "This is file: $n" > r1/file.$n &&`
			`git -C r1 add file.$n &&`
			`git -C r1 commit -m "$n" \|\| return 1`
			`done &&`

			`git init r2 &&`
			`# LINT: loop fails to handle failure explicitly with "\|\| return 1"`
			`for n in 1000 10000`
			`do`
			`printf "%"$n"s" X > r2/large.$n &&`
			`git -C r2 add large.$n &&`
			`git -C r2 commit -m "$n"`
			`done`